From: Greg KH <gregkh@linuxfoundation.org>
To: Tree Davies <tdavies@darkphysics.net>
Cc: philipp.g.hortmann@gmail.com, anjan@momi.ca, error27@gmail.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/5] Staging: rtl8192e: Rename function ResetBaEntry
Date: Thu, 27 Jul 2023 10:05:49 +0200 [thread overview]
Message-ID: <2023072731-turtle-reassure-568d@gregkh> (raw)
In-Reply-To: <20230727061948.579480-6-tdavies@darkphysics.net>
On Wed, Jul 26, 2023 at 11:19:48PM -0700, Tree Davies wrote:
> Rename function ResetBaEntry to reset_ba_entry in order to Fix checkpatch
> warning: Avoid CamelCase
>
> Signed-off-by: Tree Davies <tdavies@darkphysics.net>
> ---
> v2: Sent with git send-email
> drivers/staging/rtl8192e/rtl819x_BAProc.c | 2 +-
> drivers/staging/rtl8192e/rtl819x_TSProc.c | 6 +++---
> drivers/staging/rtl8192e/rtllib.h | 2 +-
> 3 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c
> index 9662d75257ce..cb6450206763 100644
> --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
> +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
> @@ -54,7 +54,7 @@ static u8 rx_ts_delete_ba(struct rtllib_device *ieee, struct rx_ts_record *pRxTs
> return bSendDELBA;
> }
>
> -void ResetBaEntry(struct ba_record *pBA)
> +void reset_ba_entry(struct ba_record *pBA)
> {
> pBA->b_valid = false;
> pBA->ba_param_set.short_data = 0;
> diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c b/drivers/staging/rtl8192e/rtl819x_TSProc.c
> index c61fdf73c572..21ffbb6b231f 100644
> --- a/drivers/staging/rtl8192e/rtl819x_TSProc.c
> +++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c
> @@ -117,8 +117,8 @@ static void ResetTxTsEntry(struct tx_ts_record *pTS)
> pTS->bAddBaReqDelayed = false;
> pTS->bUsingBa = false;
> pTS->bDisable_AddBa = false;
> - ResetBaEntry(&pTS->TxAdmittedBARecord);
> - ResetBaEntry(&pTS->TxPendingBARecord);
> + reset_ba_entry(&pTS->TxAdmittedBARecord);
> + reset_ba_entry(&pTS->TxPendingBARecord);
> }
>
> static void ResetRxTsEntry(struct rx_ts_record *pTS)
> @@ -126,7 +126,7 @@ static void ResetRxTsEntry(struct rx_ts_record *pTS)
> ResetTsCommonInfo(&pTS->ts_common_info);
> pTS->rx_indicate_seq = 0xffff;
> pTS->rx_timeout_indicate_seq = 0xffff;
> - ResetBaEntry(&pTS->rx_admitted_ba_record);
> + reset_ba_entry(&pTS->rx_admitted_ba_record);
> }
>
> void TSInitialize(struct rtllib_device *ieee)
> diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
> index e3ce4431d460..ccc9e7bbbcbb 100644
> --- a/drivers/staging/rtl8192e/rtllib.h
> +++ b/drivers/staging/rtl8192e/rtllib.h
> @@ -2016,7 +2016,7 @@ void TsInitDelBA(struct rtllib_device *ieee,
> void BaSetupTimeOut(struct timer_list *t);
> void TxBaInactTimeout(struct timer_list *t);
> void RxBaInactTimeout(struct timer_list *t);
> -void ResetBaEntry(struct ba_record *pBA);
> +void reset_ba_entry(struct ba_record *pBA);
Again, this is a global symbol name, please prefix it with rtllib_
thanks,
greg k-h
prev parent reply other threads:[~2023-07-27 8:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 6:19 [PATCH v2 0/5] Staging: rtl8192e: Function name cleanup series 1 Tree Davies
2023-07-27 6:19 ` [PATCH v2 1/5] Staging: rtl8192e: Rename function ActivateBAEntry Tree Davies
2023-07-27 6:19 ` [PATCH v2 2/5] Staging: rtl8192e: Rename function DeActivateBAEntry Tree Davies
2023-07-27 6:19 ` [PATCH v2 3/5] Staging: rtl8192e: Rename function TxTsDeleteBA Tree Davies
2023-07-27 6:19 ` [PATCH v2 4/5] Staging: rtl8192e: Rename function RxTsDeleteBA Tree Davies
2023-07-27 6:19 ` [PATCH v2 5/5] Staging: rtl8192e: Rename function ResetBaEntry Tree Davies
2023-07-27 8:05 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023072731-turtle-reassure-568d@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=anjan@momi.ca \
--cc=error27@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=philipp.g.hortmann@gmail.com \
--cc=tdavies@darkphysics.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.