From: Jakub Kicinski <kuba@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "mengyuanlou@net-swift.com" <mengyuanlou@net-swift.com>,
"Russell King (Oracle)" <linux@armlinux.org.uk>,
Simon Horman <simon.horman@corigine.com>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH net-next 2/2] net: phy: add keep_data_connection to struct phydev
Date: Fri, 28 Jul 2023 08:11:10 -0700 [thread overview]
Message-ID: <20230728081110.18c8a0cd@kernel.org> (raw)
In-Reply-To: <ca9ab336-8ea9-43f5-8f3c-436832a9af2d@lunn.ch>
On Fri, 28 Jul 2023 11:48:36 +0200 Andrew Lunn wrote:
> > > All of this is usually in FW so we should be able to shape the
> > > implementation in the way we want...
> > >
> > We certainly can do all phy operations in Fw when we are using NCSI.
>
> I would actually prefer Linux does it, not firmware. My personal
> preference is also Linux driver the hardware, since it is then
> possible for the community to debug it, extend it with new
> functionality, etc. Firmware is a black box only the vendor can do
> anything with.
Just to be clear, my comment was more about NCSI commands (which
I don't think should be handled by the host), not PHY control.
next prev parent reply other threads:[~2023-07-28 15:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230724092544.73531-1-mengyuanlou@net-swift.com>
2023-07-24 9:24 ` [PATCH net-next 1/2] net: ngbe: add ncsi_enable flag for wangxun nics Mengyuan Lou
2023-07-25 23:22 ` Jakub Kicinski
2023-07-26 1:59 ` mengyuanlou
2023-07-26 2:44 ` Jakub Kicinski
2023-07-26 3:12 ` mengyuanlou
2023-07-26 3:23 ` Jakub Kicinski
2023-07-24 9:24 ` [PATCH net-next 2/2] net: phy: add keep_data_connection to struct phydev Mengyuan Lou
2023-07-25 12:05 ` Simon Horman
2023-07-25 13:12 ` Russell King (Oracle)
2023-07-26 2:35 ` mengyuanlou
2023-07-26 8:10 ` Russell King (Oracle)
2023-07-26 8:54 ` Andrew Lunn
2023-07-26 16:08 ` Jakub Kicinski
2023-07-26 16:43 ` Andrew Lunn
2023-07-26 18:29 ` Jakub Kicinski
2023-07-28 9:27 ` mengyuanlou
2023-07-28 9:48 ` Andrew Lunn
2023-07-28 15:11 ` Jakub Kicinski [this message]
2023-07-25 12:13 ` [PATCH net-next 1/2] net: ngbe: add ncsi_enable flag for wangxun nics Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230728081110.18c8a0cd@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.