Re: [Buildroot] [PATCH RFC 1/2] utils/docker-run: make it compatible with SELinux

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Christian,

On Thu, 27 Jul 2023 20:13:08 -0700
Christian Stewart <christian@paral.in> wrote:

> On Wed, Jul 26, 2023 at 2:20 PM Thomas Petazzoni
> <thomas.petazzoni@bootlin.com> wrote:
> > -    --mount "type=bind,src=${MAIN_DIR},dst=${MAIN_DIR}"
> > -    --mount "type=bind,src=${GIT_DIR},dst=${GIT_DIR}"
> > +    --volume "${MAIN_DIR}:${MAIN_DIR}:Z"
> > +    --volume "${GIT_DIR}:${GIT_DIR}:Z"
> >      --workdir "${MAIN_DIR}"  
> 
> What is the purpose of the GIT_DIR mount here, doesn't MAIN_DIR contain .git?

This is explained in 791c163b2f9f07d4c02b18eabd9b195918e1c603:

commit 791c163b2f9f07d4c02b18eabd9b195918e1c603
Author: Yann E. MORIN <yann.morin.1998@free.fr>
Date:   Sat May 6 23:46:18 2023 +0200

    utils/docker-run: make it work in workdirs/woktrees
    
    It is quite customary to use a single repository with multiple workdirs,
    one for each active branch, with either the aging 'git new-workdir' or
    the more recent 'git worktree'.
    
    However, in a workdir/worktree, most entries in .git/ are only symlinks
    to the actual files in the main repository.
    
    Currently, utils/docker-run only bind-mounts the current working copy.
    If that is a workdir/worktree, then it is going to be missing the actual
    git data, resulting in errors like:
    
        $ ./utils/docker-run make check-package
        fatal: not a git repository (or any parent up to mount point [....]/buildroot)
        Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
        No files to check style
        make: *** [Makefile:1257: check-package] Error 1
    
    So, we also bind-mount the actual git directory. If that is a subdir
    of the current working copy, then it is already mounted and thus the
    bind-mount is superfluous but harmless; for simplicity, we mount it
    unconditionally.
    
    Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
    Cc: Ricardo Martincoski <ricardo.martincoski@datacom.com.br>

> I think this mount might be causing some unpredictable behavior in the
> host-go package, but it's just a hunch at the moment.

Did you confirm this?

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot