From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1BFDC0015E for ; Fri, 28 Jul 2023 10:32:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235329AbjG1Kc3 (ORCPT ); Fri, 28 Jul 2023 06:32:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235588AbjG1KcK (ORCPT ); Fri, 28 Jul 2023 06:32:10 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0462B469A for ; Fri, 28 Jul 2023 03:30:20 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8B0C1620D5 for ; Fri, 28 Jul 2023 10:29:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A3206C433C8; Fri, 28 Jul 2023 10:29:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690540176; bh=n6hLoJoxaHRZl2gwtQqqv7qOvBWSxA2vMdfkwL9PGdU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qm4fn49ckb/huwQHZkpuU6XUdygL0x4SJ0Pk6j7ZIhPC+WgpgR/QUmQZb3tdSTKGI OsEnht4nqo2vyxNwKzqs0k7EFMQS2xYN21NBZeQFvnFSuDBdIURnmBPKfidHgvToik gdn1y4C0XMhC/2KaP8Sri8S8AAYzRgFQ4yGZd3d6hCuZRsAdDeYLaJ4B+fgLZB0MHv JxZTBEtmK3F434HFNuwTInqzBCb9ZAyPsVpoVsnUw0+o7oUtKpztsUYJ/h9WYy3rAJ JEeVU1qM8E3x//UceZdgPeDWLpA6bqjIUvEwnZNkv8Dpn59aqWidS38fSeUt0ctEHC UA1d6qdT++Bhg== Date: Fri, 28 Jul 2023 11:29:31 +0100 From: Lee Jones To: Biju Das Cc: Geert Uytterhoeven , Pavel Machek , Prabhakar Mahadev Lad , linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH] mfd: rz-mtu3: Replace raw_spin_lock->spin_lock() Message-ID: <20230728102931.GJ8175@google.com> References: <20230719124729.270393-1-biju.das.jz@bp.renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230719124729.270393-1-biju.das.jz@bp.renesas.com> Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org On Wed, 19 Jul 2023, Biju Das wrote: > As per kernel documentation, use raw_spinlock_t only in real critical core > code, low-level interrupt handling, and places where disabling preemption > or interrupts is required. Here the lock is for concurrent register access > from different drivers, hence spin_lock() is sufficient. > > Reported-by: Pavel Machek > Closes: https://patchwork.kernel.org/project/linux-renesas-soc/patch/20230717120333.165219-1-biju.das.jz@bp.renesas.com/ > Signed-off-by: Biju Das > --- > This patch depend upon [1] > [1] https://patchwork.kernel.org/project/linux-renesas-soc/patch/20230717120333.165219-1-biju.das.jz@bp.renesas.com/ > --- > drivers/mfd/rz-mtu3.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) Doesn't apply. Please rebase and resend -- Lee Jones [李琼斯]