From: Jakub Kicinski <kuba@kernel.org>
To: Michael Chan <michael.chan@broadcom.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, gospo@broadcom.com, bpf@vger.kernel.org,
somnath.kotur@broadcom.com,
Jesper Dangaard Brouer <hawk@kernel.org>
Subject: Re: [PATCH net-next 3/3] bnxt_en: Let the page pool manage the DMA mapping
Date: Fri, 28 Jul 2023 17:42:12 -0700 [thread overview]
Message-ID: <20230728174212.64000bdc@kernel.org> (raw)
In-Reply-To: <20230728231829.235716-4-michael.chan@broadcom.com>
On Fri, 28 Jul 2023 16:18:29 -0700 Michael Chan wrote:
> + pp.dma_dir = bp->rx_dir;
> + pp.max_len = BNXT_RX_PAGE_SIZE;
I _think_ you need PAGE_SIZE here.
This should be smaller than PAGE_SIZE only if you're wasting the rest
of the buffer, e.g. MTU is 3k so you know last 1k will never get used.
PAGE_SIZE is always a multiple of BNXT_RX_PAGE so you waste nothing.
Adding Jesper to CC to keep me honest.
> + pp.flags = PP_FLAG_DMA_MAP | PP_FLAG_DMA_SYNC_DEV;
next prev parent reply other threads:[~2023-07-29 0:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 23:18 [PATCH net-next 0/3] bnxt_en: Add support for page pool Michael Chan
2023-07-28 23:18 ` [PATCH net-next 1/3] bnxt_en: Fix page pool logic for page size >= 64K Michael Chan
2023-07-29 0:35 ` Jakub Kicinski
2023-07-28 23:18 ` [PATCH net-next 2/3] bnxt_en: Use the unified RX page pool buffers for XDP and non-XDP Michael Chan
2023-07-28 23:18 ` [PATCH net-next 3/3] bnxt_en: Let the page pool manage the DMA mapping Michael Chan
2023-07-29 0:42 ` Jakub Kicinski [this message]
2023-07-31 17:47 ` Jesper Dangaard Brouer
2023-07-31 18:00 ` Jakub Kicinski
2023-07-31 18:16 ` Michael Chan
2023-07-31 18:44 ` Jakub Kicinski
2023-07-31 20:20 ` Michael Chan
2023-07-31 20:44 ` Jakub Kicinski
2023-07-31 21:11 ` Michael Chan
2023-08-01 17:06 ` Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230728174212.64000bdc@kernel.org \
--to=kuba@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gospo@broadcom.com \
--cc=hawk@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=somnath.kotur@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.