From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Christian Stewart via buildroot <buildroot@buildroot.org>
Cc: Romain Naour <romain.naour@gmail.com>,
Anisse Astier <anisse@astier.eu>,
Christian Stewart <christian@aperture.us>,
"Yann E . MORIN" <yann.morin.1998@free.fr>
Subject: Re: [Buildroot] [PATCH v2 1/1] package/go: fix go-bootstrap when parent dir contains invalid .git
Date: Fri, 28 Jul 2023 21:28:27 +0200 [thread overview]
Message-ID: <20230728212827.310d9a8e@windsurf> (raw)
In-Reply-To: <20230728045411.1023408-1-christian@aperture.us>
On Thu, 27 Jul 2023 21:54:11 -0700
Christian Stewart via buildroot <buildroot@buildroot.org> wrote:
> Building host-go within docker fails:
>
> error obtaining VCS status: exit status 128
> Use -buildvcs=false to disable VCS stamping.
>
> Reproduction of the issue:
>
> mkdir go-issue-61620
> cd ./go-issue-61620
> wget https://go.dev/dl/go1.19.11.src.tar.gz
> mkdir go-bootstrap
> tar -xf go1.19.11.src.tar.gz -C ./go-bootstrap --strip-components=1
> cd ./go-bootstrap/src/
> bash make.bash
> cd ../../
> wget https://go.dev/dl/go1.20.6.src.tar.gz
> mkdir go
> tar -xf go1.20.6.src.tar.gz -C ./go/ --strip-components=1
> printf "gitdir: ../../does/not/exist/.git" > ./.git
> cd ./go/src/
> GOROOT_BOOTSTRAP=$(pwd)/../../go-bootstrap/ bash make.bash
>
> The error only occurs when the .git that git detects in the parent directory of
> the GOROOT_BOOTSTRAP is invalid or not present causing errors when running `git`
> commands within GOROOT_BOOTSTRAP.
>
> Report: https://lists.buildroot.org/pipermail/buildroot/2023-July/671344.html
> Fixes: https://gitlab.com/buildroot.org/buildroot/-/jobs/4725186525
> Upstream issue: https://github.com/golang/go/issues/61620
> Upstream PR: https://github.com/golang/go/pull/61621
>
> Signed-off-by: Christian Stewart <christian@aperture.us>
>
> ---
Applied to master after dropping the change in go.mk, as you specified.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-07-28 19:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 4:54 [Buildroot] [PATCH v2 1/1] package/go: fix go-bootstrap when parent dir contains invalid .git Christian Stewart via buildroot
2023-07-28 4:55 ` Christian Stewart via buildroot
2023-07-28 19:28 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230728212827.310d9a8e@windsurf \
--to=buildroot@buildroot.org \
--cc=anisse@astier.eu \
--cc=christian@aperture.us \
--cc=romain.naour@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.