All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [jirislaby:devel 61/98] drivers/tty/tty_buffer.c:325:28: sparse: sparse: incompatible types in comparison expression (different type sizes):
Date: Sat, 29 Jul 2023 06:03:51 +0800	[thread overview]
Message-ID: <202307290552.htfsP9es-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jirislaby/linux.git devel
head:   2400f7abb9deab7a2207b19d1fad47d9910077a9
commit: 58dea2bfdf65b65a29a79d6227bff708ea95dc7c [61/98] tty: tty_buffer: use min() instead of min_t()
config: nios2-randconfig-r091-20230728 (https://download.01.org/0day-ci/archive/20230729/202307290552.htfsP9es-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230729/202307290552.htfsP9es-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307290552.htfsP9es-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> drivers/tty/tty_buffer.c:325:28: sparse: sparse: incompatible types in comparison expression (different type sizes):
>> drivers/tty/tty_buffer.c:325:28: sparse:    unsigned int *
>> drivers/tty/tty_buffer.c:325:28: sparse:    unsigned long *
   drivers/tty/tty_buffer.c:363:28: sparse: sparse: incompatible types in comparison expression (different type sizes):
   drivers/tty/tty_buffer.c:363:28: sparse:    unsigned int *
   drivers/tty/tty_buffer.c:363:28: sparse:    unsigned long *

vim +325 drivers/tty/tty_buffer.c

   305	
   306	/**
   307	 * tty_insert_flip_string_fixed_flag - add characters to the tty buffer
   308	 * @port: tty port
   309	 * @chars: characters
   310	 * @flag: flag value for each character
   311	 * @size: size
   312	 *
   313	 * Queue a series of bytes to the tty buffering. All the characters passed are
   314	 * marked with the supplied flag.
   315	 *
   316	 * Returns: the number added.
   317	 */
   318	int tty_insert_flip_string_fixed_flag(struct tty_port *port, const u8 *chars,
   319					      u8 flag, size_t size)
   320	{
   321		int copied = 0;
   322		bool flags = flag != TTY_NORMAL;
   323	
   324		do {
 > 325			int goal = min(size - copied, TTY_BUFFER_PAGE);
   326			int space = __tty_buffer_request_room(port, goal, flags);
   327			struct tty_buffer *tb = port->buf.tail;
   328	
   329			if (unlikely(space == 0))
   330				break;
   331			memcpy(char_buf_ptr(tb, tb->used), chars, space);
   332			if (tb->flags)
   333				memset(flag_buf_ptr(tb, tb->used), flag, space);
   334			tb->used += space;
   335			copied += space;
   336			chars += space;
   337			/* There is a small chance that we need to split the data over
   338			 * several buffers. If this is the case we must loop.
   339			 */
   340		} while (unlikely(size > copied));
   341		return copied;
   342	}
   343	EXPORT_SYMBOL(tty_insert_flip_string_fixed_flag);
   344	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2023-07-28 22:04 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202307290552.htfsP9es-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=jirislaby@kernel.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.