From: kernel test robot <lkp@intel.com>
To: Shenwei Wang <shenwei.wang@nxp.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Vinod Koul <vkoul@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>
Cc: oe-kbuild-all@lists.linux.dev, netdev@vger.kernel.org,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Bhupesh Sharma <bhupesh.sharma@linaro.org>,
Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>,
Simon Horman <simon.horman@corigine.com>,
Andrew Halaney <ahalaney@redhat.com>,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
Shenwei Wang <shenwei.wang@nxp.com>,
Wong Vee Khee <veekhee@apple.com>
Subject: Re: [PATCH v2 net 1/2] net: stmmac: add new mode parameter for fix_mac_speed
Date: Sat, 29 Jul 2023 06:14:31 +0800 [thread overview]
Message-ID: <202307290635.TOWvHdhK-lkp@intel.com> (raw)
In-Reply-To: <20230727152503.2199550-2-shenwei.wang@nxp.com>
Hi Shenwei,
kernel test robot noticed the following build errors:
[auto build test ERROR on net/main]
url: https://github.com/intel-lab-lkp/linux/commits/Shenwei-Wang/net-stmmac-add-new-mode-parameter-for-fix_mac_speed/20230727-232922
base: net/main
patch link: https://lore.kernel.org/r/20230727152503.2199550-2-shenwei.wang%40nxp.com
patch subject: [PATCH v2 net 1/2] net: stmmac: add new mode parameter for fix_mac_speed
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20230729/202307290635.TOWvHdhK-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230729/202307290635.TOWvHdhK-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307290635.TOWvHdhK-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c: In function 'starfive_dwmac_probe':
>> drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c:132:41: error: assignment to 'void (*)(void *, uint, uint)' {aka 'void (*)(void *, unsigned int, unsigned int)'} from incompatible pointer type 'void (*)(void *, unsigned int)' [-Werror=incompatible-pointer-types]
132 | plat_dat->fix_mac_speed = starfive_dwmac_fix_mac_speed;
| ^
cc1: some warnings being treated as errors
--
drivers/net/ethernet/stmicro/stmmac/dwmac-sti.c: In function 'sti_dwmac_probe':
>> drivers/net/ethernet/stmicro/stmmac/dwmac-sti.c:296:33: error: assignment to 'void (*)(void *, uint, uint)' {aka 'void (*)(void *, unsigned int, unsigned int)'} from incompatible pointer type 'void (*)(void *, unsigned int)' [-Werror=incompatible-pointer-types]
296 | plat_dat->fix_mac_speed = data->fix_retime_src;
| ^
cc1: some warnings being treated as errors
--
drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c: In function 'tegra_eqos_probe':
>> drivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c:359:29: error: assignment to 'void (*)(void *, uint, uint)' {aka 'void (*)(void *, unsigned int, unsigned int)'} from incompatible pointer type 'void (*)(void *, unsigned int)' [-Werror=incompatible-pointer-types]
359 | data->fix_mac_speed = tegra_eqos_fix_speed;
| ^
cc1: some warnings being treated as errors
--
drivers/net/ethernet/stmicro/stmmac/dwmac-intel-plat.c: In function 'intel_eth_plat_probe':
>> drivers/net/ethernet/stmicro/stmmac/dwmac-intel-plat.c:108:49: error: assignment to 'void (*)(void *, uint, uint)' {aka 'void (*)(void *, unsigned int, unsigned int)'} from incompatible pointer type 'void (*)(void *, unsigned int)' [-Werror=incompatible-pointer-types]
108 | plat_dat->fix_mac_speed = dwmac->data->fix_mac_speed;
| ^
cc1: some warnings being treated as errors
vim +132 drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c
b4a5afa51ceeca Samin Guo 2023-04-17 92
4bd3bb7b452690 Samin Guo 2023-04-17 93 static int starfive_dwmac_probe(struct platform_device *pdev)
4bd3bb7b452690 Samin Guo 2023-04-17 94 {
4bd3bb7b452690 Samin Guo 2023-04-17 95 struct plat_stmmacenet_data *plat_dat;
4bd3bb7b452690 Samin Guo 2023-04-17 96 struct stmmac_resources stmmac_res;
4bd3bb7b452690 Samin Guo 2023-04-17 97 struct starfive_dwmac *dwmac;
4bd3bb7b452690 Samin Guo 2023-04-17 98 struct clk *clk_gtx;
4bd3bb7b452690 Samin Guo 2023-04-17 99 int err;
4bd3bb7b452690 Samin Guo 2023-04-17 100
4bd3bb7b452690 Samin Guo 2023-04-17 101 err = stmmac_get_platform_resources(pdev, &stmmac_res);
4bd3bb7b452690 Samin Guo 2023-04-17 102 if (err)
4bd3bb7b452690 Samin Guo 2023-04-17 103 return dev_err_probe(&pdev->dev, err,
4bd3bb7b452690 Samin Guo 2023-04-17 104 "failed to get resources\n");
4bd3bb7b452690 Samin Guo 2023-04-17 105
4bd3bb7b452690 Samin Guo 2023-04-17 106 plat_dat = stmmac_probe_config_dt(pdev, stmmac_res.mac);
4bd3bb7b452690 Samin Guo 2023-04-17 107 if (IS_ERR(plat_dat))
4bd3bb7b452690 Samin Guo 2023-04-17 108 return dev_err_probe(&pdev->dev, PTR_ERR(plat_dat),
4bd3bb7b452690 Samin Guo 2023-04-17 109 "dt configuration failed\n");
4bd3bb7b452690 Samin Guo 2023-04-17 110
4bd3bb7b452690 Samin Guo 2023-04-17 111 dwmac = devm_kzalloc(&pdev->dev, sizeof(*dwmac), GFP_KERNEL);
4bd3bb7b452690 Samin Guo 2023-04-17 112 if (!dwmac)
4bd3bb7b452690 Samin Guo 2023-04-17 113 return -ENOMEM;
4bd3bb7b452690 Samin Guo 2023-04-17 114
4bd3bb7b452690 Samin Guo 2023-04-17 115 dwmac->clk_tx = devm_clk_get_enabled(&pdev->dev, "tx");
4bd3bb7b452690 Samin Guo 2023-04-17 116 if (IS_ERR(dwmac->clk_tx))
4bd3bb7b452690 Samin Guo 2023-04-17 117 return dev_err_probe(&pdev->dev, PTR_ERR(dwmac->clk_tx),
4bd3bb7b452690 Samin Guo 2023-04-17 118 "error getting tx clock\n");
4bd3bb7b452690 Samin Guo 2023-04-17 119
4bd3bb7b452690 Samin Guo 2023-04-17 120 clk_gtx = devm_clk_get_enabled(&pdev->dev, "gtx");
4bd3bb7b452690 Samin Guo 2023-04-17 121 if (IS_ERR(clk_gtx))
4bd3bb7b452690 Samin Guo 2023-04-17 122 return dev_err_probe(&pdev->dev, PTR_ERR(clk_gtx),
4bd3bb7b452690 Samin Guo 2023-04-17 123 "error getting gtx clock\n");
4bd3bb7b452690 Samin Guo 2023-04-17 124
4bd3bb7b452690 Samin Guo 2023-04-17 125 /* Generally, the rgmii_tx clock is provided by the internal clock,
4bd3bb7b452690 Samin Guo 2023-04-17 126 * which needs to match the corresponding clock frequency according
4bd3bb7b452690 Samin Guo 2023-04-17 127 * to different speeds. If the rgmii_tx clock is provided by the
4bd3bb7b452690 Samin Guo 2023-04-17 128 * external rgmii_rxin, there is no need to configure the clock
4bd3bb7b452690 Samin Guo 2023-04-17 129 * internally, because rgmii_rxin will be adaptively adjusted.
4bd3bb7b452690 Samin Guo 2023-04-17 130 */
4bd3bb7b452690 Samin Guo 2023-04-17 131 if (!device_property_read_bool(&pdev->dev, "starfive,tx-use-rgmii-clk"))
4bd3bb7b452690 Samin Guo 2023-04-17 @132 plat_dat->fix_mac_speed = starfive_dwmac_fix_mac_speed;
4bd3bb7b452690 Samin Guo 2023-04-17 133
4bd3bb7b452690 Samin Guo 2023-04-17 134 dwmac->dev = &pdev->dev;
4bd3bb7b452690 Samin Guo 2023-04-17 135 plat_dat->bsp_priv = dwmac;
4bd3bb7b452690 Samin Guo 2023-04-17 136 plat_dat->dma_cfg->dche = true;
4bd3bb7b452690 Samin Guo 2023-04-17 137
b4a5afa51ceeca Samin Guo 2023-04-17 138 err = starfive_dwmac_set_mode(plat_dat);
b4a5afa51ceeca Samin Guo 2023-04-17 139 if (err)
b4a5afa51ceeca Samin Guo 2023-04-17 140 return err;
b4a5afa51ceeca Samin Guo 2023-04-17 141
4bd3bb7b452690 Samin Guo 2023-04-17 142 err = stmmac_dvr_probe(&pdev->dev, plat_dat, &stmmac_res);
4bd3bb7b452690 Samin Guo 2023-04-17 143 if (err) {
4bd3bb7b452690 Samin Guo 2023-04-17 144 stmmac_remove_config_dt(pdev, plat_dat);
4bd3bb7b452690 Samin Guo 2023-04-17 145 return err;
4bd3bb7b452690 Samin Guo 2023-04-17 146 }
4bd3bb7b452690 Samin Guo 2023-04-17 147
4bd3bb7b452690 Samin Guo 2023-04-17 148 return 0;
4bd3bb7b452690 Samin Guo 2023-04-17 149 }
4bd3bb7b452690 Samin Guo 2023-04-17 150
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2023-07-28 22:15 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 15:25 [PATCH v2 net 0/2] update stmmac fix_mac_speed Shenwei Wang
2023-07-27 15:25 ` Shenwei Wang
2023-07-27 15:25 ` Shenwei Wang
2023-07-27 15:25 ` [PATCH v2 net 1/2] net: stmmac: add new mode parameter for fix_mac_speed Shenwei Wang
2023-07-27 15:25 ` Shenwei Wang
2023-07-27 15:25 ` Shenwei Wang
2023-07-28 16:01 ` kernel test robot
2023-07-28 22:14 ` kernel test robot [this message]
2023-07-27 15:25 ` [PATCH v2 net 2/2] net: stmmac: dwmac-imx: pause the TXC clock in fixed-link Shenwei Wang
2023-07-27 15:25 ` Shenwei Wang
2023-07-27 15:25 ` Shenwei Wang
2023-07-27 18:36 ` Andrew Halaney
2023-07-27 18:36 ` Andrew Halaney
2023-07-27 18:36 ` Andrew Halaney
2023-07-28 14:59 ` [EXT] " Shenwei Wang
2023-07-28 14:59 ` Shenwei Wang
2023-07-28 14:59 ` Shenwei Wang
2023-07-28 15:22 ` Russell King (Oracle)
2023-07-28 15:22 ` Russell King (Oracle)
2023-07-28 15:22 ` Russell King (Oracle)
2023-07-28 15:36 ` Will Deacon
2023-07-28 15:36 ` Will Deacon
2023-07-28 15:36 ` Will Deacon
2023-07-28 16:09 ` [EXT] " Shenwei Wang
2023-07-28 16:09 ` Shenwei Wang
2023-07-28 16:09 ` Shenwei Wang
2023-07-28 16:29 ` Frank Li
2023-07-28 16:29 ` Frank Li
2023-07-28 16:29 ` Frank Li
2023-07-28 19:33 ` Russell King (Oracle)
2023-07-28 19:33 ` Russell King (Oracle)
2023-07-28 19:33 ` Russell King (Oracle)
2023-07-28 11:00 ` Fabio Estevam
2023-07-28 11:00 ` Fabio Estevam
2023-07-28 11:00 ` Fabio Estevam
2023-07-28 15:09 ` [EXT] " Shenwei Wang
2023-07-28 15:09 ` Shenwei Wang
2023-07-28 15:09 ` Shenwei Wang
2023-07-28 16:55 ` Andrew Lunn
2023-07-28 16:55 ` Andrew Lunn
2023-07-28 16:55 ` Andrew Lunn
2023-07-28 17:01 ` Shenwei Wang
2023-07-28 17:01 ` Shenwei Wang
2023-07-28 17:01 ` Shenwei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202307290635.TOWvHdhK-lkp@intel.com \
--to=lkp@intel.com \
--cc=ahalaney@redhat.com \
--cc=alexandre.torgue@foss.st.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=bhupesh.sharma@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=festevam@gmail.com \
--cc=jbrunet@baylibre.com \
--cc=jernej.skrabec@gmail.com \
--cc=joabreu@synopsys.com \
--cc=kernel@pengutronix.de \
--cc=khilman@baylibre.com \
--cc=kuba@kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux@armlinux.org.uk \
--cc=martin.blumenstingl@googlemail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=neil.armstrong@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=nobuhiro1.iwamatsu@toshiba.co.jp \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=s.hauer@pengutronix.de \
--cc=samuel@sholland.org \
--cc=shawnguo@kernel.org \
--cc=shenwei.wang@nxp.com \
--cc=simon.horman@corigine.com \
--cc=veekhee@apple.com \
--cc=vkoul@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.