From: kernel test robot <lkp@intel.com>
To: Janne Grunau <j@jannau.net>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
Hector Martin <marcan@marcan.st>
Subject: [asahilinux:bits/200-dcp 95/107] drivers/gpu/drm/apple/iomfb.c:150:6: warning: no previous prototype for function 'dcp_push'
Date: Sat, 29 Jul 2023 07:16:14 +0800 [thread overview]
Message-ID: <202307290756.RfSnmNsS-lkp@intel.com> (raw)
tree: https://github.com/AsahiLinux/linux bits/200-dcp
head: 9fbd4119b479213bf020ab631beb0b0468bbdf61
commit: df317c7881a9c77c2c07a9aac27c92b2150be1f5 [95/107] drm/apple: Add support for the macOS 13.2 DCP firmware
config: arm64-allyesconfig (https://download.01.org/0day-ci/archive/20230729/202307290756.RfSnmNsS-lkp@intel.com/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a)
reproduce: (https://download.01.org/0day-ci/archive/20230729/202307290756.RfSnmNsS-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307290756.RfSnmNsS-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/gpu/drm/apple/iomfb.c:150:6: warning: no previous prototype for function 'dcp_push' [-Wmissing-prototypes]
150 | void dcp_push(struct apple_dcp *dcp, bool oob, const struct dcp_method_entry *call,
| ^
drivers/gpu/drm/apple/iomfb.c:150:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
150 | void dcp_push(struct apple_dcp *dcp, bool oob, const struct dcp_method_entry *call,
| ^
| static
>> drivers/gpu/drm/apple/iomfb.c:192:5: warning: no previous prototype for function 'dcp_parse_tag' [-Wmissing-prototypes]
192 | int dcp_parse_tag(char tag[4])
| ^
drivers/gpu/drm/apple/iomfb.c:192:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
192 | int dcp_parse_tag(char tag[4])
| ^
| static
>> drivers/gpu/drm/apple/iomfb.c:211:6: warning: no previous prototype for function 'dcp_ack' [-Wmissing-prototypes]
211 | void dcp_ack(struct apple_dcp *dcp, enum dcp_context_id context)
| ^
drivers/gpu/drm/apple/iomfb.c:211:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
211 | void dcp_ack(struct apple_dcp *dcp, enum dcp_context_id context)
| ^
| static
>> drivers/gpu/drm/apple/iomfb.c:220:6: warning: no previous prototype for function 'dcp_sleep' [-Wmissing-prototypes]
220 | void dcp_sleep(struct apple_dcp *dcp)
| ^
drivers/gpu/drm/apple/iomfb.c:220:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
220 | void dcp_sleep(struct apple_dcp *dcp)
| ^
| static
>> drivers/gpu/drm/apple/iomfb.c:394:17: warning: no previous prototype for function 'drm_to_dcp_rect' [-Wmissing-prototypes]
394 | struct dcp_rect drm_to_dcp_rect(struct drm_rect *rect)
| ^
drivers/gpu/drm/apple/iomfb.c:394:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
394 | struct dcp_rect drm_to_dcp_rect(struct drm_rect *rect)
| ^
| static
>> drivers/gpu/drm/apple/iomfb.c:402:5: warning: no previous prototype for function 'drm_format_to_dcp' [-Wmissing-prototypes]
402 | u32 drm_format_to_dcp(u32 drm)
| ^
drivers/gpu/drm/apple/iomfb.c:402:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
402 | u32 drm_format_to_dcp(u32 drm)
| ^
| static
>> drivers/gpu/drm/apple/iomfb.c:448:26: warning: no previous prototype for function 'lookup_mode' [-Wmissing-prototypes]
448 | struct dcp_display_mode *lookup_mode(struct apple_dcp *dcp,
| ^
drivers/gpu/drm/apple/iomfb.c:448:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
448 | struct dcp_display_mode *lookup_mode(struct apple_dcp *dcp,
| ^
| static
>> drivers/gpu/drm/apple/iomfb.c:517:6: warning: no previous prototype for function 'iomfb_start' [-Wmissing-prototypes]
517 | void iomfb_start(struct apple_dcp *dcp)
| ^
drivers/gpu/drm/apple/iomfb.c:517:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
517 | void iomfb_start(struct apple_dcp *dcp)
| ^
| static
8 warnings generated.
vim +/dcp_push +150 drivers/gpu/drm/apple/iomfb.c
148
149 /* Call a DCP function given by a tag */
> 150 void dcp_push(struct apple_dcp *dcp, bool oob, const struct dcp_method_entry *call,
151 u32 in_len, u32 out_len, void *data, dcp_callback_t cb,
152 void *cookie)
153 {
154 enum dcp_context_id context = dcp_call_context(dcp, oob);
155 struct dcp_channel *ch = dcp_get_channel(dcp, context);
156
157 struct dcp_packet_header header = {
158 .in_len = in_len,
159 .out_len = out_len,
160
161 /* Tag is reversed due to endianness of the fourcc */
162 .tag[0] = call->tag[3],
163 .tag[1] = call->tag[2],
164 .tag[2] = call->tag[1],
165 .tag[3] = call->tag[0],
166 };
167
168 u8 depth = dcp_push_depth(&ch->depth);
169 u16 offset = dcp_packet_start(ch, depth);
170
171 void *out = dcp->shmem + dcp_tx_offset(context) + offset;
172 void *out_data = out + sizeof(header);
173 size_t data_len = sizeof(header) + in_len + out_len;
174
175 memcpy(out, &header, sizeof(header));
176
177 if (in_len > 0)
178 memcpy(out_data, data, in_len);
179
180 trace_iomfb_push(dcp, call, context, offset, depth);
181
182 ch->callbacks[depth] = cb;
183 ch->cookies[depth] = cookie;
184 ch->output[depth] = out + sizeof(header) + in_len;
185 ch->end[depth] = offset + ALIGN(data_len, DCP_PACKET_ALIGNMENT);
186
187 dcp_send_message(dcp, IOMFB_ENDPOINT,
188 dcpep_msg(context, data_len, offset));
189 }
190
191 /* Parse a callback tag "D123" into the ID 123. Returns -EINVAL on failure. */
> 192 int dcp_parse_tag(char tag[4])
193 {
194 u32 d[3];
195 int i;
196
197 if (tag[3] != 'D')
198 return -EINVAL;
199
200 for (i = 0; i < 3; ++i) {
201 d[i] = (u32)(tag[i] - '0');
202
203 if (d[i] > 9)
204 return -EINVAL;
205 }
206
207 return d[0] + (d[1] * 10) + (d[2] * 100);
208 }
209
210 /* Ack a callback from the DCP */
> 211 void dcp_ack(struct apple_dcp *dcp, enum dcp_context_id context)
212 {
213 struct dcp_channel *ch = dcp_get_channel(dcp, context);
214
215 dcp_pop_depth(&ch->depth);
216 dcp_send_message(dcp, IOMFB_ENDPOINT,
217 dcpep_ack(context));
218 }
219
> 220 void dcp_sleep(struct apple_dcp *dcp)
221 {
222 switch (dcp->fw_compat) {
223 case DCP_FIRMWARE_V_12_3:
224 iomfb_sleep_v12_3(dcp);
225 break;
226 case DCP_FIRMWARE_V_13_2:
227 iomfb_sleep_v13_2(dcp);
228 break;
229 default:
230 WARN_ONCE(true, "Unexpected firmware version: %u\n", dcp->fw_compat);
231 break;
232 }
233 }
234
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2023-07-28 23:16 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202307290756.RfSnmNsS-lkp@intel.com \
--to=lkp@intel.com \
--cc=j@jannau.net \
--cc=llvm@lists.linux.dev \
--cc=marcan@marcan.st \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.