From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 23DE7C001E0 for ; Sun, 30 Jul 2023 03:05:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KS8Xvu2yPIQS/8BbB0KoFhMj0b5w/xLV3THQgwOONmg=; b=BzKb4wTQ6nfyVI 5px5V8Sf12rfDtz3FSLqR1o7ds6o453zgzexVV2Ke3bdVIgWY/lup/RYOlZoCOtvXRWkRknfTlB65 2tfgOJGDrMg5NbLiRAM3LJLqT/gCAkYi4pmwyRfcEfLC6uuiSt0/rEnrWiHDd0ZP/SsLvs1lQmyEr hC4EIde2hx566wgvja6Ahbpkf9ZppRAgbmTiqBgBQOAL4faOLIcSW6I52jTmCFTmRO4lsh6iXu6TR o6j/95GRIuXWLww4JhKw+hywF4E24z/KGzAgOg/gDn+d+Ejk5QP8Sc7Dr5NMlW0jwCZyoPfuOyqSh bnxOlmSSdx3UBwnAjlpw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qPwjg-009lZq-2k; Sun, 30 Jul 2023 03:04:48 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qPwjd-009lZQ-0v for linux-arm-kernel@lists.infradead.org; Sun, 30 Jul 2023 03:04:46 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 69ACB602F1; Sun, 30 Jul 2023 03:04:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4FF3DC433C7; Sun, 30 Jul 2023 03:04:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690686283; bh=XCxytUv15QG7HcusHOJ5Fk2+EpLtcAQKZgoCyEga+HM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aZyjTugRZgJmIUBOqtcLYNhG8MM3e2k840ITznMTguA0Yvv4UQf9DiVQ947HIsXdg F7DSkRN2LI3p91vRxkDFW9hap/llVm/VrnnJ2bb3YSPlSO73dLwtDBgyWzN7RF55fB AKOpbbmJ+ICB5GlOhFdmog4a8KicXo9AX8NridKRwhZ/1tqwq+aPOcXpZ2wkzb460M QwxAKDDhQXx5q/rz1CBDbk2uwCEF7c4g9/PjEC125eMGQr+LUqjwWYJqeTBgxlwprY v0Vf1brnXQa6uIQ6Yvcq+vjGCVOk4BoDqUDnLFVCdq8MM9mAvL2ixl2AnVgw6Iga4T O3qAJu+W1O0ZQ== Date: Sun, 30 Jul 2023 11:04:30 +0800 From: Shawn Guo To: Bough Chen Cc: "Peng Fan (OSS)" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "festevam@gmail.com" , dl-linux-imx , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Sherry Sun , Peng Fan Subject: Re: [PATCH 09/10] arm64: dts: imx8ulp-evk: add 100MHz/200MHz pinctrl setting for eMMC Message-ID: <20230730030430.GT151430@dragon> References: <20230625124238.4071717-1-peng.fan@oss.nxp.com> <20230625124238.4071717-10-peng.fan@oss.nxp.com> <20230718033227.GE9559@dragon> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230729_200445_431334_83512874 X-CRM114-Status: GOOD ( 20.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBKdWwgMjQsIDIwMjMgYXQgMDY6NTE6MTdBTSArMDAwMCwgQm91Z2ggQ2hlbiB3cm90 ZToKPiA+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tCj4gPiBGcm9tOiBTaGF3biBHdW8gPHNo YXduZ3VvQGtlcm5lbC5vcmc+Cj4gPiBTZW50OiAyMDIz5bm0N+aciDE45pelIDExOjMyCj4gPiBU bzogUGVuZyBGYW4gKE9TUykgPHBlbmcuZmFuQG9zcy5ueHAuY29tPgo+ID4gQ2M6IHJvYmgrZHRA a2VybmVsLm9yZzsga3J6eXN6dG9mLmtvemxvd3NraStkdEBsaW5hcm8ub3JnOwo+ID4gcy5oYXVl ckBwZW5ndXRyb25peC5kZTsga2VybmVsQHBlbmd1dHJvbml4LmRlOyBmZXN0ZXZhbUBnbWFpbC5j b207Cj4gPiBkbC1saW51eC1pbXggPGxpbnV4LWlteEBueHAuY29tPjsgZGV2aWNldHJlZUB2Z2Vy Lmtlcm5lbC5vcmc7Cj4gPiBsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmc7IGxp bnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc7IEJvdWdoCj4gPiBDaGVuIDxoYWliby5jaGVuQG54 cC5jb20+OyBTaGVycnkgU3VuIDxzaGVycnkuc3VuQG54cC5jb20+OyBQZW5nIEZhbgo+ID4gPHBl bmcuZmFuQG54cC5jb20+Cj4gPiBTdWJqZWN0OiBSZTogW1BBVENIIDA5LzEwXSBhcm02NDogZHRz OiBpbXg4dWxwLWV2azogYWRkIDEwME1Iei8yMDBNSHoKPiA+IHBpbmN0cmwgc2V0dGluZyBmb3Ig ZU1NQwo+ID4gCj4gPiBPbiBTdW4sIEp1biAyNSwgMjAyMyBhdCAwODo0MjozN1BNICswODAwLCBQ ZW5nIEZhbiAoT1NTKSB3cm90ZToKPiA+ID4gRnJvbTogSGFpYm8gQ2hlbiA8aGFpYm8uY2hlbkBu eHAuY29tPgo+ID4gPgo+ID4gPiBBZGQgMTAwTUh6IGFuZCAyMDBNSHogcGluY3RybCBzZXR0aW5n IGZvciBlTU1DLCBhbmQgZW5hYmxlIDggYml0IGJ1cwo+ID4gPiBtb2RlIHRvIGNvbmZpZyB0aGUg ZU1NQyB3b3JrIGF0IEhTNDAwRVMgbW9kZS4KPiA+ID4KPiA+ID4gQWxzbyB1cGRhdGUgdG8gdXNl IFN0YW5kYXJkIERyaXZlIFN0cmVuZ3RoIGZvciBVU0RIQyBwYWQgdG8gZ2V0IGEKPiA+ID4gYmV0 dGVyIHNpZ25hbCBxdWFsaXR5IHBlciBIYXJkd2FyZSB0ZWFtIHN1Z2dlc3RzLgo+ID4gPgo+ID4g PiBSZXZpZXdlZC1ieTogU2hlcnJ5IFN1biA8c2hlcnJ5LnN1bkBueHAuY29tPgo+ID4gPiBTaWdu ZWQtb2ZmLWJ5OiBIYWlibyBDaGVuIDxoYWliby5jaGVuQG54cC5jb20+Cj4gPiA+IFNpZ25lZC1v ZmYtYnk6IFBlbmcgRmFuIDxwZW5nLmZhbkBueHAuY29tPgo+ID4gPiAtLS0KPiA+ID4gIGFyY2gv YXJtNjQvYm9vdC9kdHMvZnJlZXNjYWxlL2lteDh1bHAtZXZrLmR0cyB8IDI2Cj4gPiA+ICsrKysr KysrKystLS0tLS0tLS0KPiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCAxNCBpbnNlcnRpb25zKCspLCAx MiBkZWxldGlvbnMoLSkKPiA+ID4KPiA+ID4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtNjQvYm9vdC9k dHMvZnJlZXNjYWxlL2lteDh1bHAtZXZrLmR0cwo+ID4gPiBiL2FyY2gvYXJtNjQvYm9vdC9kdHMv ZnJlZXNjYWxlL2lteDh1bHAtZXZrLmR0cwo+ID4gPiBpbmRleCBlNDU5ZGMzNWU0NjkuLmFiN2Fm NzA1YmJjYSAxMDA2NDQKPiA+ID4gLS0tIGEvYXJjaC9hcm02NC9ib290L2R0cy9mcmVlc2NhbGUv aW14OHVscC1ldmsuZHRzCj4gPiA+ICsrKyBiL2FyY2gvYXJtNjQvYm9vdC9kdHMvZnJlZXNjYWxl L2lteDh1bHAtZXZrLmR0cwo+ID4gPiBAQCAtMTIxLDkgKzEyMSwxMSBAQCAmbHB1YXJ0NSB7Cj4g PiA+ICB9Owo+ID4gPgo+ID4gPiAgJnVzZGhjMCB7Cj4gPiA+IC0JcGluY3RybC1uYW1lcyA9ICJk ZWZhdWx0IiwgInNsZWVwIjsKPiA+ID4gKwlwaW5jdHJsLW5hbWVzID0gImRlZmF1bHQiLCAic3Rh dGVfMTAwbWh6IiwgInN0YXRlXzIwMG1oeiIsICJzbGVlcCI7Cj4gPiA+ICAJcGluY3RybC0wID0g PCZwaW5jdHJsX3VzZGhjMD47Cj4gPiA+ICAJcGluY3RybC0xID0gPCZwaW5jdHJsX3VzZGhjMD47 Cj4gPiA+ICsJcGluY3RybC0yID0gPCZwaW5jdHJsX3VzZGhjMD47Cj4gPiA+ICsJcGluY3RybC0z ID0gPCZwaW5jdHJsX3VzZGhjMD47Cj4gPiAKPiA+IEFsbCB0aHJlZSBzcGVlZCBtb2RlcyB1c2Ug dGhlIHNhbWUgcGluY3RybD8KPiAKPiBZZXMsIHRoZSBJT01VWCBvbiBpbXg4dWxwIGRvIG5vdCBz dXBwb3J0IGNvbmZpZyBkaWZmZXJlbnQgZHJpdmUgc3RyZW5ndGguIFNvIGhlcmUgdXNlIHRoZSBz YW1lIHBpbmN0cmwuCgpNZW50aW9uIHRoYXQgaW4gdGhlIGNvbW1pdCBsb2cgb3Igd2l0aCBhIGNv bW1lbnQgd291bGQgYmUgaGVscGZ1bC4KClNoYXduCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51 eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5v cmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 967FCC0015E for ; Sun, 30 Jul 2023 03:04:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229521AbjG3DEq (ORCPT ); Sat, 29 Jul 2023 23:04:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229448AbjG3DEp (ORCPT ); Sat, 29 Jul 2023 23:04:45 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2CB71BCE; Sat, 29 Jul 2023 20:04:44 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7501160766; Sun, 30 Jul 2023 03:04:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4FF3DC433C7; Sun, 30 Jul 2023 03:04:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690686283; bh=XCxytUv15QG7HcusHOJ5Fk2+EpLtcAQKZgoCyEga+HM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aZyjTugRZgJmIUBOqtcLYNhG8MM3e2k840ITznMTguA0Yvv4UQf9DiVQ947HIsXdg F7DSkRN2LI3p91vRxkDFW9hap/llVm/VrnnJ2bb3YSPlSO73dLwtDBgyWzN7RF55fB AKOpbbmJ+ICB5GlOhFdmog4a8KicXo9AX8NridKRwhZ/1tqwq+aPOcXpZ2wkzb460M QwxAKDDhQXx5q/rz1CBDbk2uwCEF7c4g9/PjEC125eMGQr+LUqjwWYJqeTBgxlwprY v0Vf1brnXQa6uIQ6Yvcq+vjGCVOk4BoDqUDnLFVCdq8MM9mAvL2ixl2AnVgw6Iga4T O3qAJu+W1O0ZQ== Date: Sun, 30 Jul 2023 11:04:30 +0800 From: Shawn Guo To: Bough Chen Cc: "Peng Fan (OSS)" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "festevam@gmail.com" , dl-linux-imx , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Sherry Sun , Peng Fan Subject: Re: [PATCH 09/10] arm64: dts: imx8ulp-evk: add 100MHz/200MHz pinctrl setting for eMMC Message-ID: <20230730030430.GT151430@dragon> References: <20230625124238.4071717-1-peng.fan@oss.nxp.com> <20230625124238.4071717-10-peng.fan@oss.nxp.com> <20230718033227.GE9559@dragon> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Jul 24, 2023 at 06:51:17AM +0000, Bough Chen wrote: > > -----Original Message----- > > From: Shawn Guo > > Sent: 2023年7月18日 11:32 > > To: Peng Fan (OSS) > > Cc: robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; > > s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com; > > dl-linux-imx ; devicetree@vger.kernel.org; > > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; Bough > > Chen ; Sherry Sun ; Peng Fan > > > > Subject: Re: [PATCH 09/10] arm64: dts: imx8ulp-evk: add 100MHz/200MHz > > pinctrl setting for eMMC > > > > On Sun, Jun 25, 2023 at 08:42:37PM +0800, Peng Fan (OSS) wrote: > > > From: Haibo Chen > > > > > > Add 100MHz and 200MHz pinctrl setting for eMMC, and enable 8 bit bus > > > mode to config the eMMC work at HS400ES mode. > > > > > > Also update to use Standard Drive Strength for USDHC pad to get a > > > better signal quality per Hardware team suggests. > > > > > > Reviewed-by: Sherry Sun > > > Signed-off-by: Haibo Chen > > > Signed-off-by: Peng Fan > > > --- > > > arch/arm64/boot/dts/freescale/imx8ulp-evk.dts | 26 > > > ++++++++++--------- > > > 1 file changed, 14 insertions(+), 12 deletions(-) > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8ulp-evk.dts > > > b/arch/arm64/boot/dts/freescale/imx8ulp-evk.dts > > > index e459dc35e469..ab7af705bbca 100644 > > > --- a/arch/arm64/boot/dts/freescale/imx8ulp-evk.dts > > > +++ b/arch/arm64/boot/dts/freescale/imx8ulp-evk.dts > > > @@ -121,9 +121,11 @@ &lpuart5 { > > > }; > > > > > > &usdhc0 { > > > - pinctrl-names = "default", "sleep"; > > > + pinctrl-names = "default", "state_100mhz", "state_200mhz", "sleep"; > > > pinctrl-0 = <&pinctrl_usdhc0>; > > > pinctrl-1 = <&pinctrl_usdhc0>; > > > + pinctrl-2 = <&pinctrl_usdhc0>; > > > + pinctrl-3 = <&pinctrl_usdhc0>; > > > > All three speed modes use the same pinctrl? > > Yes, the IOMUX on imx8ulp do not support config different drive strength. So here use the same pinctrl. Mention that in the commit log or with a comment would be helpful. Shawn