From: Leon Romanovsky <leon@kernel.org>
To: Michal Schmidt <mschmidt@redhat.com>
Cc: netdev@vger.kernel.org, Abhijit Ayarekar <aayarekar@marvell.com>,
Veerasenareddy Burru <vburru@marvell.com>,
Vimlesh Kumar <vimleshk@marvell.com>,
Shinas Rasheed <srasheed@marvell.com>,
Sathesh Edara <sedara@marvell.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH net] octeon_ep: initialize mbox mutexes
Date: Sun, 30 Jul 2023 16:36:00 +0300 [thread overview]
Message-ID: <20230730133600.GI94048@unreal> (raw)
In-Reply-To: <20230729151516.24153-1-mschmidt@redhat.com>
On Sat, Jul 29, 2023 at 05:15:16PM +0200, Michal Schmidt wrote:
> The two mbox-related mutexes are destroyed in octep_ctrl_mbox_uninit(),
> but the corresponding mutex_init calls were missing.
> A "DEBUG_LOCKS_WARN_ON(lock->magic != lock)" warning was emitted with
> CONFIG_DEBUG_MUTEXES on.
>
> Initialize the two mutexes in octep_ctrl_mbox_init().
>
> Fixes: 577f0d1b1c5f ("octeon_ep: add separate mailbox command and response queues")
> Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
> ---
> drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_mbox.c | 3 +++
> 1 file changed, 3 insertions(+)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
next prev parent reply other threads:[~2023-07-30 13:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-29 15:15 [PATCH net] octeon_ep: initialize mbox mutexes Michal Schmidt
2023-07-30 13:36 ` Leon Romanovsky [this message]
2023-07-31 21:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230730133600.GI94048@unreal \
--to=leon@kernel.org \
--cc=aayarekar@marvell.com \
--cc=davem@davemloft.net \
--cc=mschmidt@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sedara@marvell.com \
--cc=srasheed@marvell.com \
--cc=vburru@marvell.com \
--cc=vimleshk@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.