All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "Guillaume W. Bres" <guillaume.bressaix@gmail.com>
Cc: buildroot@busybox.net
Subject: Re: [Buildroot] [PATCH 1/1] package/pixiewps: bump to version 1.4.2
Date: Sun, 30 Jul 2023 23:33:02 +0200	[thread overview]
Message-ID: <20230730233302.1a8b9d2b@windsurf> (raw)
In-Reply-To: <20230521082858.500-1-guillaume.bressaix@gmail.com>

Hello Guillaume,

On Sun, 21 May 2023 10:28:58 +0200
"Guillaume W. Bres" <guillaume.bressaix@gmail.com> wrote:

> -PIXIEWPS_VERSION = 9e5bdc6c86c8487b2a6107d5ab3559ed5c738c59
> -PIXIEWPS_SITE = $(call github,wiire-a,pixiewps,$(PIXIEWPS_VERSION))
> +PIXIEWPS_VERSION = 1.4.2
> +PIXIEWPS_SITE = $(call github,wiire-a,pixiewps,v$(PIXIEWPS_VERSION))

Hum, I'm sorry but this doesn't look like a bump. If we look at the
commit history of pixiewps (most recent commits first, older commits
last):

464326fbcc499ac92d4f04c3990a9cc9c5124e86 (HEAD -> master, origin/master, origin/HEAD) Update gitignore: add pixiewrapper binary
85af251806ab24454372134e7055823adebd5afa remove gmtime()-related code duplication
c1dd3a9ff6618b5f2e3535855cee9ffb10788b81 use gmtime_r() to mute code analysis tools (gmtime() is non-mt-safe)
a6b3fa514c0c9a6ad5dc931040218451c64ce150 add pixiewrapper
8964527b85f558465341d9daa8da8d8a94eb0967 add --cstart/cend switches for time_t range
9e5bdc6c86c8487b2a6107d5ab3559ed5c738c59 endianeness.h: fix logical bug which broke big endian   <--- we are currently here
28f68e694bdf5774300a1451c970578de0e19ce0 (tag: v1.4.2) Bumped version to 1.4.2                   <--- you propose to get back here

So in fact, you're proposing to go one commit back in time. Maybe it's
OK but you should explain why. And a "fix logical bug which broke big
endian" seems useful to have in Buildroot.

Could you clarify?

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-07-30 21:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-21  8:28 [Buildroot] [PATCH 1/1] package/pixiewps: bump to version 1.4.2 Guillaume W. Bres
2023-07-30 21:33 ` Thomas Petazzoni via buildroot [this message]
2023-07-31  7:45   ` Guillaume Bres

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230730233302.1a8b9d2b@windsurf \
    --to=buildroot@buildroot.org \
    --cc=buildroot@busybox.net \
    --cc=guillaume.bressaix@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.