Re: [PATCH v5 2/3] firmware: qcom_scm: Add support for Qualcomm Secure Execution Environment SCM interface

[kernel test robot <lkp@intel.com>]

Hi Maximilian,

kernel test robot noticed the following build errors:

[auto build test ERROR on linus/master]
[also build test ERROR on v6.5-rc3 next-20230728]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Maximilian-Luz/lib-ucs2_string-Add-UCS-2-strscpy-function/20230731-002132
base:   linus/master
patch link:    https://lore.kernel.org/r/20230730161906.606163-3-luzmaximilian%40gmail.com
patch subject: [PATCH v5 2/3] firmware: qcom_scm: Add support for Qualcomm Secure Execution Environment SCM interface
config: arc-randconfig-r023-20230731 (https://download.01.org/0day-ci/archive/20230731/202307310244.vaA3izJB-lkp@intel.com/config)
compiler: arc-elf-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230731/202307310244.vaA3izJB-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307310244.vaA3izJB-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

   drivers/firmware/qcom_qseecom.c: In function 'qseecom_client_release':
>> drivers/firmware/qcom_qseecom.c:24:9: error: implicit declaration of function 'kfree' [-Werror=implicit-function-declaration]
      24 |         kfree(client);
         |         ^~~~~
   drivers/firmware/qcom_qseecom.c: In function 'qseecom_client_register':
>> drivers/firmware/qcom_qseecom.c:50:18: error: implicit declaration of function 'kzalloc' [-Werror=implicit-function-declaration]
      50 |         client = kzalloc(sizeof(*client), GFP_KERNEL);
         |                  ^~~~~~~
>> drivers/firmware/qcom_qseecom.c:50:16: warning: assignment to 'struct qseecom_client *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
      50 |         client = kzalloc(sizeof(*client), GFP_KERNEL);
         |                ^
   cc1: some warnings being treated as errors


vim +/kfree +24 drivers/firmware/qcom_qseecom.c

    19	
    20	static void qseecom_client_release(struct device *dev)
    21	{
    22		struct qseecom_client *client = container_of(dev, struct qseecom_client, aux_dev.dev);
    23	
  > 24		kfree(client);
    25	}
    26	
    27	static void qseecom_client_remove(void *data)
    28	{
    29		struct qseecom_client *client = data;
    30	
    31		auxiliary_device_delete(&client->aux_dev);
    32		auxiliary_device_uninit(&client->aux_dev);
    33	}
    34	
    35	static int qseecom_client_register(struct platform_device *qseecom_dev,
    36					   const struct qseecom_app_desc *desc)
    37	{
    38		struct qseecom_client *client;
    39		u32 app_id;
    40		int ret;
    41	
    42		/* Try to find the app ID, skip device if not found */
    43		ret = qcom_scm_qseecom_app_get_id(desc->app_name, &app_id);
    44		if (ret)
    45			return ret == -ENOENT ? 0 : ret;
    46	
    47		dev_info(&qseecom_dev->dev, "setting up client for %s\n", desc->app_name);
    48	
    49		/* Allocate and set-up the client device */
  > 50		client = kzalloc(sizeof(*client), GFP_KERNEL);
    51		if (!client)
    52			return -ENOMEM;
    53	
    54		client->aux_dev.name = desc->dev_name;
    55		client->aux_dev.dev.parent = &qseecom_dev->dev;
    56		client->aux_dev.dev.release = qseecom_client_release;
    57		client->app_id = app_id;
    58	
    59		ret = auxiliary_device_init(&client->aux_dev);
    60		if (ret) {
    61			kfree(client);
    62			return ret;
    63		}
    64	
    65		ret = auxiliary_device_add(&client->aux_dev);
    66		if (ret) {
    67			auxiliary_device_uninit(&client->aux_dev);
    68			return ret;
    69		}
    70	
    71		ret = devm_add_action_or_reset(&qseecom_dev->dev, qseecom_client_remove, client);
    72		if (ret)
    73			return ret;
    74	
    75		return 0;
    76	}
    77	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki