From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83ECFC001DE for ; Mon, 31 Jul 2023 06:41:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229674AbjGaGlK (ORCPT ); Mon, 31 Jul 2023 02:41:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58364 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229501AbjGaGlK (ORCPT ); Mon, 31 Jul 2023 02:41:10 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 0A06BE57; Sun, 30 Jul 2023 23:41:09 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 38BE6809E; Mon, 31 Jul 2023 06:41:07 +0000 (UTC) Date: Mon, 31 Jul 2023 09:41:06 +0300 From: Tony Lindgren To: Rob Herring Cc: Russell King , linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] ARM: omap2: Explicitly include correct DT includes Message-ID: <20230731064106.GI5194@atomide.com> References: <20230720172743.2918601-1-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230720172743.2918601-1-robh@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org * Rob Herring [230720 20:27]: > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it was merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each other. They also include platform_device.h > and of.h. As a result, there's a pretty much random mix of those include > files used throughout the tree. In order to detangle these headers and > replace the implicit includes with struct declarations, users need to > explicitly include the correct includes. Applying into omap-for-v6.6/soc thanks. Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C32FFC001DE for ; Mon, 31 Jul 2023 06:41:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Qpv7X0YJPSHFxeXFCWgjZXocyR295XW7bO88QkzE0UE=; b=WLhmsew/Y3qTgx YNXnf/WObazokEjw6v8yik0+6lJCUjrUf0Jp5C8kkWrYJSertfyIIxEuNsZ6qJImHQFNkmAazVhOp Fo2kGvLP+kic3XegsVmQ8qVpHUeYHje4Fgt5ZxvFqFXA36zNS2Gdt3Gh01q5Is2Pzykysc6QiuRHQ pw4nC9tX06nkETkMtCTPk/fA+/uvaY1GmufhskUPLrl5QyV7kDIGUdbp+YRjAgsByM/0evLfWIfHQ Gph/Ws+kP+R29z3C25wpAGuU1APZPkvjwXPMwdysiU6uPCJyK8kG67HwySxmfxx9/pqppZ3+7SwII nEUnf0KUSOhnNHs4CiWw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qQMad-00E8aQ-2T; Mon, 31 Jul 2023 06:41:11 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qQMab-00E8a3-1Y for linux-arm-kernel@lists.infradead.org; Mon, 31 Jul 2023 06:41:11 +0000 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 38BE6809E; Mon, 31 Jul 2023 06:41:07 +0000 (UTC) Date: Mon, 31 Jul 2023 09:41:06 +0300 From: Tony Lindgren To: Rob Herring Cc: Russell King , linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] ARM: omap2: Explicitly include correct DT includes Message-ID: <20230731064106.GI5194@atomide.com> References: <20230720172743.2918601-1-robh@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230720172743.2918601-1-robh@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230730_234109_582304_C50B9611 X-CRM114-Status: UNSURE ( 9.34 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Rob Herring [230720 20:27]: > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it was merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each other. They also include platform_device.h > and of.h. As a result, there's a pretty much random mix of those include > files used throughout the tree. In order to detangle these headers and > replace the implicit includes with struct declarations, users need to > explicitly include the correct includes. Applying into omap-for-v6.6/soc thanks. Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel