All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
To: gregkh@linuxfoundation.org
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Jiri Slaby (SUSE)" <jirislaby@kernel.org>
Subject: [PATCH 4/7] tty: synclink_gt: drop info messages from init/exit functions
Date: Mon, 31 Jul 2023 10:59:59 +0200	[thread overview]
Message-ID: <20230731090002.15680-5-jirislaby@kernel.org> (raw)
In-Reply-To: <20230731090002.15680-1-jirislaby@kernel.org>

It is preferred NOT to print anything from init and exit functions of a
module. (If everything goes fine.)

Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
---
 drivers/tty/synclink_gt.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/drivers/tty/synclink_gt.c b/drivers/tty/synclink_gt.c
index a8716a81ac74..4a93e0e48156 100644
--- a/drivers/tty/synclink_gt.c
+++ b/drivers/tty/synclink_gt.c
@@ -3628,8 +3628,6 @@ static void slgt_cleanup(void)
 	struct slgt_info *info;
 	struct slgt_info *tmp;
 
-	printk(KERN_INFO "unload %s\n", driver_name);
-
 	if (serial_driver) {
 		for (info=slgt_device_list ; info != NULL ; info=info->next_device)
 			tty_unregister_device(serial_driver, info->line);
@@ -3671,8 +3669,6 @@ static int __init slgt_init(void)
 {
 	int rc;
 
-	printk(KERN_INFO "%s\n", driver_name);
-
 	serial_driver = tty_alloc_driver(MAX_DEVICES, TTY_DRIVER_REAL_RAW |
 			TTY_DRIVER_DYNAMIC_DEV);
 	if (IS_ERR(serial_driver)) {
@@ -3701,9 +3697,6 @@ static int __init slgt_init(void)
 		goto error;
 	}
 
-	printk(KERN_INFO "%s, tty major#%d\n",
-	       driver_name, serial_driver->major);
-
 	slgt_device_count = 0;
 	if ((rc = pci_register_driver(&pci_driver)) < 0) {
 		printk("%s pci_register_driver error=%d\n", driver_name, rc);
@@ -3711,9 +3704,6 @@ static int __init slgt_init(void)
 	}
 	pci_registered = true;
 
-	if (!slgt_device_list)
-		printk("%s no devices found\n",driver_name);
-
 	return 0;
 
 error:
-- 
2.41.0


  parent reply	other threads:[~2023-07-31  9:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-31  8:59 [PATCH 0/7] tty: synclink_gt: mark as BROKEN Jiri Slaby (SUSE)
2023-07-31  8:59 ` [PATCH 1/7] tty: synclink_gt: convert CALC_REGADDR() macro to an inline Jiri Slaby (SUSE)
2023-07-31  8:59 ` [PATCH 2/7] tty: synclink_gt: drop global slgt_driver_name array Jiri Slaby (SUSE)
2023-07-31  8:59 ` [PATCH 3/7] tty: synclink_gt: define global strings as const strings Jiri Slaby (SUSE)
2023-07-31  8:59 ` Jiri Slaby (SUSE) [this message]
2023-07-31  9:00 ` [PATCH 5/7] tty: synclink_gt: use PCI_VDEVICE Jiri Slaby (SUSE)
2023-07-31  9:00 ` [PATCH 6/7] tty: synclink_gt: make default_params const Jiri Slaby (SUSE)
2023-07-31  9:00 ` [PATCH 7/7] tty: synclink_gt: mark as BROKEN Jiri Slaby (SUSE)
2023-07-31 15:15 ` [PATCH 0/7] " Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230731090002.15680-5-jirislaby@kernel.org \
    --to=jirislaby@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.