From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Sanjay R Mehta <sanmehta@amd.com>
Cc: Sanjay R Mehta <sanju.mehta@amd.com>,
andreas.noever@gmail.com, michael.jamet@intel.com,
YehezkelShB@gmail.com, linux-usb@vger.kernel.org,
Sanath S <Sanath.S@amd.com>
Subject: Re: [PATCH V2] thunderbolt: Fix Thunderbolt 3 display flickering issue on 2nd hot plug onwards
Date: Mon, 31 Jul 2023 17:54:43 +0300 [thread overview]
Message-ID: <20230731145443.GJ14638@black.fi.intel.com> (raw)
In-Reply-To: <16994867-0b94-5ec7-f467-6f9fd6261a96@amd.com>
On Mon, Jul 31, 2023 at 06:37:16PM +0530, Sanjay R Mehta wrote:
>
>
> On 7/31/2023 4:45 PM, Mika Westerberg wrote:
> > On Wed, Jul 12, 2023 at 01:16:19PM -0500, Sanjay R Mehta wrote:
> >> Previously, on unplug events, the TMU mode was disabled first
> >> followed by the Time Synchronization Handshake, irrespective of
> >> whether the tb_switch_tmu_rate_write() API was successful or not.
> >>
> >> However, this caused a problem with Thunderbolt 3 (TBT3)
> >> devices, as the TSPacketInterval bits were always enabled by default,
> >> leading the host router to assume that the device router's TMU was
> >> already enabled and preventing it from initiating the Time
> >> Synchronization Handshake. As a result, TBT3 monitors experienced
> >> display flickering from the second hot plug onwards.
> >>
> >> To address this issue, we have modified the code to only disable the
> >> Time Synchronization Handshake during TMU disable if the
> >> tb_switch_tmu_rate_write() function is successful. This ensures that
> >> the TBT3 devices function correctly and eliminates the display
> >> flickering issue.
> >>
> >> Co-developed-by: Sanath S <Sanath.S@amd.com>
> >> Signed-off-by: Sanath S <Sanath.S@amd.com>
> >> Signed-off-by: Sanjay R Mehta <sanju.mehta@amd.com>
> >
> > Looks good.
> >
> > I suppose you want this in -stable too, right?
>
> Thanks. Yes Mika.
Hm, I get:
Applying: thunderbolt: Fix Thunderbolt 3 display flickering issue on 2nd hot plug onwards
error: patch failed: drivers/thunderbolt/tmu.c:415
error: drivers/thunderbolt/tmu.c: patch does not apply
Patch failed at 0001 thunderbolt: Fix Thunderbolt 3 display flickering issue on 2nd hot plug onwards
Is this based on v6.5-rcX or something else?
next prev parent reply other threads:[~2023-07-31 14:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 18:16 [PATCH V2] thunderbolt: Fix Thunderbolt 3 display flickering issue on 2nd hot plug onwards Sanjay R Mehta
2023-07-31 11:15 ` Mika Westerberg
2023-07-31 13:07 ` Sanjay R Mehta
2023-07-31 14:54 ` Mika Westerberg [this message]
2023-08-01 5:35 ` Sanjay R Mehta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230731145443.GJ14638@black.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=Sanath.S@amd.com \
--cc=YehezkelShB@gmail.com \
--cc=andreas.noever@gmail.com \
--cc=linux-usb@vger.kernel.org \
--cc=michael.jamet@intel.com \
--cc=sanju.mehta@amd.com \
--cc=sanmehta@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.