From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9B48C001DC for ; Mon, 31 Jul 2023 16:27:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233382AbjGaQ1d (ORCPT ); Mon, 31 Jul 2023 12:27:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231479AbjGaQ12 (ORCPT ); Mon, 31 Jul 2023 12:27:28 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22B2A173F; Mon, 31 Jul 2023 09:27:04 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 90AF268AA6; Mon, 31 Jul 2023 18:26:39 +0200 (CEST) Date: Mon, 31 Jul 2023 18:26:39 +0200 From: Christoph Hellwig To: Arnd Bergmann Cc: Christoph Hellwig , Luis Chamberlain , Greg Kroah-Hartman , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Ulf Hansson , Yangbo Lu , Joshua Kinard , Daniel Vetter , linux-arm-kernel@lists.infradead.org, open list , "linux-mmc @ vger . kernel . org" , Netdev , linux-rtc@vger.kernel.org, linux-modules@vger.kernel.org Subject: Re: [PATCH 1/5] ARM/pxa: use EXPORT_SYMBOL_GPL for sharpsl_battery_kick Message-ID: <20230731162639.GA9441@lst.de> References: <20230731083806.453036-1-hch@lst.de> <20230731083806.453036-2-hch@lst.de> <86b73242-94bb-4537-92ec-51da02127848@app.fastmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <86b73242-94bb-4537-92ec-51da02127848@app.fastmail.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: On Mon, Jul 31, 2023 at 06:12:22PM +0200, Arnd Bergmann wrote: > Or let me know if you want a better fix. Since sharpsl_pm.c and > spitz.c are no longer loadable modules and just get linked together > these days, I think the variant below would be simpler (this could > be cleanup up further, endlessly, of course): That actually looks way nicer, thanks! If you give me a singoff I'll add it to the next version. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 36E47C001DC for ; Mon, 31 Jul 2023 16:27:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IOHWjEcqd+C3xg058K7mgK8ucMibEIMtK8eo0y2klhM=; b=q2WB8iPayLlvBf hTAEK/1c90ib3UR8+IsI4aMqCcgRQCPN2I2Iv+U+AGME/qtAO1txhEjTi27tmP6yz1YlpsDjWH6yn CQNztRxD3vHf8pyWp7aFiqFRxOgy97dDwnZcU9+kBVsSWqJs9yJpIVWRumFIPv9kJHoQ3FVQ7RPIR xsgW7Hl9kWHR+hmFt7jxfIJsXwIbHfb+CqRMNUkguqvJLKjxKu34a7xM34Q7QriAVkj1Kv4OHxrYm JBZ42BnREjlgc5O84CNEL9ibfBYYiDIgyBjP23EvQaeddRbZwhdONr/NrBTqhClVv9EChi1n+GMKr 1AVuIWr6j0hX5HKR61yQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qQVjM-00GZG2-0I; Mon, 31 Jul 2023 16:26:48 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qQVjI-00GZFK-2J for linux-arm-kernel@lists.infradead.org; Mon, 31 Jul 2023 16:26:45 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 90AF268AA6; Mon, 31 Jul 2023 18:26:39 +0200 (CEST) Date: Mon, 31 Jul 2023 18:26:39 +0200 From: Christoph Hellwig To: Arnd Bergmann Cc: Christoph Hellwig , Luis Chamberlain , Greg Kroah-Hartman , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Ulf Hansson , Yangbo Lu , Joshua Kinard , Daniel Vetter , linux-arm-kernel@lists.infradead.org, open list , "linux-mmc @ vger . kernel . org" , Netdev , linux-rtc@vger.kernel.org, linux-modules@vger.kernel.org Subject: Re: [PATCH 1/5] ARM/pxa: use EXPORT_SYMBOL_GPL for sharpsl_battery_kick Message-ID: <20230731162639.GA9441@lst.de> References: <20230731083806.453036-1-hch@lst.de> <20230731083806.453036-2-hch@lst.de> <86b73242-94bb-4537-92ec-51da02127848@app.fastmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <86b73242-94bb-4537-92ec-51da02127848@app.fastmail.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230731_092644_894732_51AC79F5 X-CRM114-Status: GOOD ( 14.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 31, 2023 at 06:12:22PM +0200, Arnd Bergmann wrote: > Or let me know if you want a better fix. Since sharpsl_pm.c and > spitz.c are no longer loadable modules and just get linked together > these days, I think the variant below would be simpler (this could > be cleanup up further, endlessly, of course): That actually looks way nicer, thanks! If you give me a singoff I'll add it to the next version. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel