From: "hch@lst.de" <hch@lst.de>
To: Varun Prakash <varun@chelsio.com>
Cc: Sagi Grimberg <sagi@grimberg.me>, "hch@lst.de" <hch@lst.de>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
Rakshana S <rakshanas@chelsio.com>
Subject: Re: [PATCH] nvmet-tcp: pass iov_len instead of sg->length to bvec_set_page()
Date: Mon, 31 Jul 2023 21:38:13 +0200 [thread overview]
Message-ID: <20230731193813.GA13587@lst.de> (raw)
In-Reply-To: <BN9PR12MB532469A81B5D3F6C297F91C9BC05A@BN9PR12MB5324.namprd12.prod.outlook.com>
On Mon, Jul 31, 2023 at 06:30:33PM +0000, Varun Prakash wrote:
> checkpatch.pl was reporting following CHECK warning so I fixed the alignment.
checkpatch.pl is unfortunately not much more useful than Markus Elfring
these days. Opening brace alignment is a common style and makes sense
in some places, but tab-based alignment often is much easier to maintain.
next prev parent reply other threads:[~2023-07-31 19:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 15:05 [PATCH] nvmet-tcp: pass iov_len instead of sg->length to bvec_set_page() Varun Prakash
2023-07-31 5:59 ` Christoph Hellwig
2023-07-31 9:13 ` Sagi Grimberg
2023-07-31 13:41 ` Sagi Grimberg
2023-07-31 18:30 ` Varun Prakash
2023-07-31 19:38 ` hch [this message]
2023-08-01 7:34 ` Sagi Grimberg
2023-08-01 8:19 ` Varun Prakash
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230731193813.GA13587@lst.de \
--to=hch@lst.de \
--cc=linux-nvme@lists.infradead.org \
--cc=rakshanas@chelsio.com \
--cc=sagi@grimberg.me \
--cc=varun@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.