Re: [Buildroot] [PATCH 1/2] package/xscreensaver: fix build

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Bernd,

Do you think you could follow-up on the below comments? It would help
getting the patch merged.

Thanks!

Thomas

On Tue, 18 Jul 2023 11:46:08 +0200
Thomas Petazzoni via buildroot <buildroot@buildroot.org> wrote:

> Hello Bernd,
> 
> On Sun, 16 Jul 2023 19:01:25 +0200
> Bernd Kuhls <bernd@kuhls.net> wrote:
> 
> > diff --git a/.checkpackageignore b/.checkpackageignore
> > index 504b96951b..fa557733e8 100644
> > --- a/.checkpackageignore
> > +++ b/.checkpackageignore
> > @@ -1638,6 +1638,8 @@ package/xinetd/0004-configure-rlim_t.patch Upstream
> >  package/xinetd/0005-CVE-2013-4342-xinetd-ignores-user-and-group-directiv.patch Upstream
> >  package/xl2tp/xl2tpd TrailingSpace
> >  package/xml-security-c/0001-fix-build-with-libressl-3.5.0.patch Upstream
> > +package/xscreensaver/0001-disable-check-for-pam.patch
> > +package/xscreensaver/0002-build-Do-not-build-po-files.patch  
> 
> Is this valid syntax? You're saying to ignore some warnings, but not
> which ones.
> 
> Also, for new patches, adding them in the checkpackageignore file is
> quite odd. We definitely want those new patches to have an "Upstream:"
> tag.
> 
> >  package/xxhash/0001-fix-man-page-installation.patch Upstream
> >  package/xxhash/0002-Makefile-add-dedicated-install-targets.patch Upstream
> >  package/xxhash/0003-do-no-longer-depend-on-assert-h-for-XXH_STATIC_ASSERT.patch Upstream
> > diff --git a/package/xscreensaver/0001-disable-check-for-pam.patch b/package/xscreensaver/0001-disable-check-for-pam.patch
> > new file mode 100644
> > index 0000000000..6d052a53e9
> > --- /dev/null
> > +++ b/package/xscreensaver/0001-disable-check-for-pam.patch
> > @@ -0,0 +1,16 @@
> > +Fix cross-build
> > +
> > +Detecting features of the host does not make sense when cross-compiling.
> > +
> > +Signed-off-by: Bernd Kuhls <bernd@kuhls.net>  
> 
> Meh, no Git repository of the project to have a nice Git formatted patch? :-/
> 
> > diff --git a/package/xscreensaver/0002-build-Do-not-build-po-files.patch b/package/xscreensaver/0002-build-Do-not-build-po-files.patch
> > new file mode 100644
> > index 0000000000..03674f5d50
> > --- /dev/null
> > +++ b/package/xscreensaver/0002-build-Do-not-build-po-files.patch
> > @@ -0,0 +1,58 @@
> > +From 6b5d022f6dd9848a2d5ca08a1968929b8c140981 Mon Sep 17 00:00:00 2001
> > +From: Khem Raj <raj.khem@gmail.com>
> > +Date: Sat, 16 Jul 2022 09:59:40 -0700
> > +Subject: [PATCH 2/2] build: Do not build po files  
> 
> No patch numbering, this raises a check-package warning.
> 
> I see Khem has been able to generate a git formatted patch, I wonder
> against which Git repository?
> 
> Thomas



-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot