From: Luca Ceresoli via buildroot <buildroot@buildroot.org>
To: Neal Frager <neal.frager@amd.com>
Cc: michal.simek@amd.com, thomas.petazzoni@bootlin.com,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v1 1/1] board/zynqmp: merge post scripts
Date: Tue, 1 Aug 2023 09:03:26 +0200 [thread overview]
Message-ID: <20230801090326.7f95eb85@booty> (raw)
In-Reply-To: <20230724103508.772579-1-neal.frager@amd.com>
Hi Neal,
On Mon, 24 Jul 2023 11:35:08 +0100
Neal Frager <neal.frager@amd.com> wrote:
> This patch merges the zynqmp post scripts as only one script is needed.
>
> Signed-off-by: Neal Frager <neal.frager@amd.com>
> ---
> board/zynqmp/post-build.sh | 15 ---------------
> board/zynqmp/post-image.sh | 13 +++++++++++++
> configs/zynqmp_kria_kv260_defconfig | 2 +-
> configs/zynqmp_zcu102_defconfig | 1 -
> configs/zynqmp_zcu106_defconfig | 1 -
> 5 files changed, 14 insertions(+), 18 deletions(-)
> delete mode 100755 board/zynqmp/post-build.sh
>
> diff --git a/board/zynqmp/post-build.sh b/board/zynqmp/post-build.sh
> deleted file mode 100755
> index 747991e3f1..0000000000
> --- a/board/zynqmp/post-build.sh
> +++ /dev/null
> @@ -1,15 +0,0 @@
> -#!/bin/sh
> -
> -# genimage will need to find the extlinux.conf
> -# in the binaries directory
> -
> -CONSOLE="$2"
> -ROOT="$3"
> -
> -mkdir -p "${BINARIES_DIR}"
> -cat <<-__HEADER_EOF > "${BINARIES_DIR}/extlinux.conf"
> - label linux
> - kernel /Image
> - devicetree /system.dtb
> - append console="${CONSOLE}" root="/dev/${ROOT}" rw rootwait
> - __HEADER_EOF
> diff --git a/board/zynqmp/post-image.sh b/board/zynqmp/post-image.sh
> index f44b66342d..4da8a64940 100755
> --- a/board/zynqmp/post-image.sh
> +++ b/board/zynqmp/post-image.sh
> @@ -12,4 +12,17 @@ FIRST_DT=$(sed -nr \
>
> BOARD_DIR="$(dirname "$0")"
>
> +# genimage will need to find the extlinux.conf in the binaries directory
> +
> +CONSOLE="$2"
> +ROOT="$3"
> +
> +mkdir -p "${BINARIES_DIR}"
> +cat <<-__HEADER_EOF > "${BINARIES_DIR}/extlinux.conf"
> + label linux
> + kernel /Image
> + devicetree /system.dtb
> + append console="${CONSOLE}" root="/dev/${ROOT}" rw rootwait
> + __HEADER_EOF
Why is this change needed?
The extlinux.conf file generation is in always in post-build in the
whole Buildroot tree, thus moving it to post-image only for some boards
seems confusing.
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-08-01 7:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 10:35 [Buildroot] [PATCH v1 1/1] board/zynqmp: merge post scripts Neal Frager via buildroot
2023-08-01 7:03 ` Luca Ceresoli via buildroot [this message]
2023-08-01 8:22 ` Frager, Neal via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230801090326.7f95eb85@booty \
--to=buildroot@buildroot.org \
--cc=luca.ceresoli@bootlin.com \
--cc=michal.simek@amd.com \
--cc=neal.frager@amd.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.