All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: x86@kernel.org, Andrew Cooper <andrew.cooper3@citrix.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Paolo Bonzini <pbonzini@redhat.com>, Wei Liu <wei.liu@kernel.org>,
	Arjan van de Ven <arjan@linux.intel.com>,
	Juergen Gross <jgross@suse.com>,
	Michael Kelley <mikelley@microsoft.com>,
	Peter Keresztes Schmidt <peter@keresztesschmidt.de>,
	"Peter Zijlstra (Intel)" <peterz@infradead.org>
Subject: [patch V3 05/60] x86/apic: Remove pointless x86_bios_cpu_apicid
Date: Tue,  1 Aug 2023 12:46:47 +0200 (CEST)	[thread overview]
Message-ID: <20230801103815.428310033@linutronix.de> (raw)
In-Reply-To: 20230801103042.936020332@linutronix.de

It's a useless copy of x86_cpu_to_apicid.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
---
 arch/x86/include/asm/apic.h        |    2 --
 arch/x86/include/asm/smp.h         |    1 -
 arch/x86/kernel/apic/apic.c        |    5 +----
 arch/x86/kernel/apic/apic_common.c |    2 +-
 arch/x86/kernel/apic/bigsmp_32.c   |    2 +-
 arch/x86/kernel/apic/probe_64.c    |    4 +---
 arch/x86/kernel/setup_percpu.c     |    3 ---
 7 files changed, 4 insertions(+), 15 deletions(-)

--- a/arch/x86/include/asm/apic.h
+++ b/arch/x86/include/asm/apic.h
@@ -477,8 +477,6 @@ extern void generic_bigsmp_probe(void);
 
 #define APIC_DFR_VALUE	(APIC_DFR_FLAT)
 
-DECLARE_EARLY_PER_CPU_READ_MOSTLY(u16, x86_bios_cpu_apicid);
-
 extern struct apic apic_noop;
 
 static inline unsigned int read_apic_id(void)
--- a/arch/x86/include/asm/smp.h
+++ b/arch/x86/include/asm/smp.h
@@ -22,7 +22,6 @@ DECLARE_PER_CPU_READ_MOSTLY(u16, cpu_l2c
 
 DECLARE_EARLY_PER_CPU_READ_MOSTLY(u16, x86_cpu_to_apicid);
 DECLARE_EARLY_PER_CPU_READ_MOSTLY(u32, x86_cpu_to_acpiid);
-DECLARE_EARLY_PER_CPU_READ_MOSTLY(u16, x86_bios_cpu_apicid);
 #if defined(CONFIG_X86_LOCAL_APIC) && defined(CONFIG_X86_32)
 DECLARE_EARLY_PER_CPU_READ_MOSTLY(int, x86_cpu_to_logical_apicid);
 #endif
--- a/arch/x86/kernel/apic/apic.c
+++ b/arch/x86/kernel/apic/apic.c
@@ -108,10 +108,8 @@ unsigned long apic_mmio_base __ro_after_
  * Map cpu index to physical APIC ID
  */
 DEFINE_EARLY_PER_CPU_READ_MOSTLY(u16, x86_cpu_to_apicid, BAD_APICID);
-DEFINE_EARLY_PER_CPU_READ_MOSTLY(u16, x86_bios_cpu_apicid, BAD_APICID);
 DEFINE_EARLY_PER_CPU_READ_MOSTLY(u32, x86_cpu_to_acpiid, U32_MAX);
 EXPORT_EARLY_PER_CPU_SYMBOL(x86_cpu_to_apicid);
-EXPORT_EARLY_PER_CPU_SYMBOL(x86_bios_cpu_apicid);
 EXPORT_EARLY_PER_CPU_SYMBOL(x86_cpu_to_acpiid);
 
 #ifdef CONFIG_X86_32
@@ -2511,7 +2509,7 @@ int generic_processor_info(int apicid, i
 
 	if (apicid == boot_cpu_physical_apicid) {
 		/*
-		 * x86_bios_cpu_apicid is required to have processors listed
+		 * x86_cpu_to_apicid is required to have processors listed
 		 * in same order as logical cpu numbers. Hence the first
 		 * entry is BSP, and so on.
 		 * boot_cpu_init() already hold bit 0 in cpu_present_mask
@@ -2548,7 +2546,6 @@ int generic_processor_info(int apicid, i
 
 #if defined(CONFIG_SMP) || defined(CONFIG_X86_64)
 	early_per_cpu(x86_cpu_to_apicid, cpu) = apicid;
-	early_per_cpu(x86_bios_cpu_apicid, cpu) = apicid;
 #endif
 #ifdef CONFIG_X86_32
 	early_per_cpu(x86_cpu_to_logical_apicid, cpu) =
--- a/arch/x86/kernel/apic/apic_common.c
+++ b/arch/x86/kernel/apic/apic_common.c
@@ -29,7 +29,7 @@ void default_ioapic_phys_id_map(physid_m
 int default_cpu_present_to_apicid(int mps_cpu)
 {
 	if (mps_cpu < nr_cpu_ids && cpu_present(mps_cpu))
-		return (int)per_cpu(x86_bios_cpu_apicid, mps_cpu);
+		return (int)per_cpu(x86_cpu_to_apicid, mps_cpu);
 	else
 		return BAD_APICID;
 }
--- a/arch/x86/kernel/apic/bigsmp_32.c
+++ b/arch/x86/kernel/apic/bigsmp_32.c
@@ -52,7 +52,7 @@ static void bigsmp_setup_apic_routing(vo
 static int bigsmp_cpu_present_to_apicid(int mps_cpu)
 {
 	if (mps_cpu < nr_cpu_ids)
-		return (int) per_cpu(x86_bios_cpu_apicid, mps_cpu);
+		return (int) per_cpu(x86_cpu_to_apicid, mps_cpu);
 
 	return BAD_APICID;
 }
--- a/arch/x86/kernel/apic/probe_64.c
+++ b/arch/x86/kernel/apic/probe_64.c
@@ -13,9 +13,7 @@
 
 #include "local.h"
 
-/*
- * Check the APIC IDs in bios_cpu_apicid and choose the APIC mode.
- */
+/* Select the appropriate APIC driver */
 void __init default_setup_apic_routing(void)
 {
 	struct apic **drv;
--- a/arch/x86/kernel/setup_percpu.c
+++ b/arch/x86/kernel/setup_percpu.c
@@ -181,8 +181,6 @@ void __init setup_per_cpu_areas(void)
 #ifdef CONFIG_X86_LOCAL_APIC
 		per_cpu(x86_cpu_to_apicid, cpu) =
 			early_per_cpu_map(x86_cpu_to_apicid, cpu);
-		per_cpu(x86_bios_cpu_apicid, cpu) =
-			early_per_cpu_map(x86_bios_cpu_apicid, cpu);
 		per_cpu(x86_cpu_to_acpiid, cpu) =
 			early_per_cpu_map(x86_cpu_to_acpiid, cpu);
 #endif
@@ -214,7 +212,6 @@ void __init setup_per_cpu_areas(void)
 	/* indicate the early static arrays will soon be gone */
 #ifdef CONFIG_X86_LOCAL_APIC
 	early_per_cpu_ptr(x86_cpu_to_apicid) = NULL;
-	early_per_cpu_ptr(x86_bios_cpu_apicid) = NULL;
 	early_per_cpu_ptr(x86_cpu_to_acpiid) = NULL;
 #endif
 #ifdef CONFIG_X86_32


  parent reply	other threads:[~2023-08-01 10:47 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-01 10:46 [patch V3 00/60] x86/apic: Decrapification and static calls Thomas Gleixner
2023-08-01 10:46 ` [patch V3 01/60] x86/cpu: Make identify_boot_cpu() static Thomas Gleixner
2023-08-01 10:46 ` [patch V3 02/60] x86/cpu: Remove unused physid_*() nonsense Thomas Gleixner
2023-08-01 10:46 ` [patch V3 03/60] x86/apic: Rename disable_apic Thomas Gleixner
2023-08-01 10:46 ` [patch V3 04/60] x86/apic/ioapic: Rename skip_ioapic_setup Thomas Gleixner
2023-08-01 10:46 ` Thomas Gleixner [this message]
2023-08-01 10:46 ` [patch V3 06/60] x86/apic: Get rid of hard_smp_processor_id() Thomas Gleixner
2023-08-01 10:46 ` [patch V3 07/60] x86/apic: Remove unused max_physical_apicid Thomas Gleixner
2023-08-01 10:46 ` [patch V3 08/60] x86/apic: Nuke unused apic::inquire_remote_apic() Thomas Gleixner
2023-08-01 10:46 ` [patch V3 09/60] x86/apic: Get rid of boot_cpu_physical_apicid madness Thomas Gleixner
2023-08-01 10:46 ` [patch V3 10/60] x86/apic: Register boot CPU APIC early Thomas Gleixner
2023-08-01 10:46 ` [patch V3 11/60] x86/apic: Remove the pointless APIC version check Thomas Gleixner
2023-08-01 10:46 ` [patch V3 12/60] x86/of: Fix the APIC address registration Thomas Gleixner
2023-08-03 22:42   ` Dave Hansen
2023-08-03 23:35     ` Thomas Gleixner
2023-08-01 10:46 ` [patch V3 13/60] x86/apic: Make some APIC init functions bool Thomas Gleixner
2023-08-01 10:46 ` [patch V3 14/60] x86/apic: Split register_apic_address() Thomas Gleixner
2023-08-01 10:46 ` [patch V3 15/60] x86/apic: Sanitize APIC address setup Thomas Gleixner
2023-08-01 10:47 ` [patch V3 16/60] x86/xen/pv: Pretend that it found SMP configuration Thomas Gleixner
2023-08-01 10:47 ` [patch V3 17/60] x86/apic: Sanitize num_processors handling Thomas Gleixner
2023-08-01 10:47 ` [patch V3 18/60] x86/apic: Nuke another processor check Thomas Gleixner
2023-08-01 10:47 ` [patch V3 19/60] x86/apic: Remove check_phys_apicid_present() Thomas Gleixner
2023-08-01 10:47 ` [patch V3 20/60] x86/apic: Get rid of apic_phys Thomas Gleixner
2023-08-01 10:47 ` [patch V3 21/60] x86/apic/32: Sanitize logical APIC ID handling Thomas Gleixner
2023-08-01 10:47 ` [patch V3 22/60] x86/apic/32: Remove x86_cpu_to_logical_apicid Thomas Gleixner
2023-08-01 10:47 ` [patch V3 23/60] x86/apic/ipi: Code cleanup Thomas Gleixner
2023-08-01 10:47 ` [patch V3 24/60] x86/apic: Mop up early_per_cpu() abuse Thomas Gleixner
2023-08-01 10:47 ` [patch V3 25/60] x86/apic/32: Remove pointless default_acpi_madt_oem_check() Thomas Gleixner
2023-08-01 10:47 ` [patch V3 26/60] x86/apic/32: Decrapify the def_bigsmp mechanism Thomas Gleixner
2023-08-07 20:11   ` Dave Hansen
2023-08-07 21:18     ` Thomas Gleixner
2023-08-01 10:47 ` [patch V3 27/60] x86/apic/32: Remove bigsmp_cpu_present_to_apicid() Thomas Gleixner
2023-08-01 10:47 ` [patch V3 28/60] x86/apic: Nuke empty init_apic_ldr() callbacks Thomas Gleixner
2023-08-01 10:47 ` [patch V3 29/60] x86/apic: Nuke apic::apicid_to_cpu_present() Thomas Gleixner
2023-08-01 10:47 ` [patch V3 30/60] x86/ioapic/32: Decrapify phys_id_present_map operation Thomas Gleixner
2023-08-01 10:47 ` [patch V3 31/60] x86/apic: Mop up *setup_apic_routing() Thomas Gleixner
2023-08-01 10:47 ` [patch V3 32/60] x86/apic: Mop up apic::apic_id_registered() Thomas Gleixner
2023-08-01 10:47 ` [patch V3 33/60] x86/apic/ipi: Tidy up the code and fixup comments Thomas Gleixner
2023-08-01 10:47 ` [patch V3 34/60] x86/apic: Consolidate wait_icr_idle() implementations Thomas Gleixner
2023-08-01 10:47 ` [patch V3 35/60] x86/apic: Allow apic::wait_icr_idle() to be NULL Thomas Gleixner
2023-08-01 10:47 ` [patch V3 36/60] x86/apic: Allow apic::safe_wait_icr_idle() " Thomas Gleixner
2023-08-01 10:47 ` [patch V3 37/60] x86/apic: Move safe wait_icr_idle() next to apic_mem_wait_icr_idle() Thomas Gleixner
2023-08-01 10:47 ` [patch V3 38/60] x86/apic/uv: Get rid of wrapper callbacks Thomas Gleixner
2023-08-01 10:47 ` [patch V3 39/60] x86/apic/x2apic: Share all common IPI functions Thomas Gleixner
2023-08-01 10:47 ` [patch V3 40/60] x86/apic/64: Uncopypaste probing Thomas Gleixner
2023-08-01 10:47 ` [patch V3 41/60] x86/apic: Wrap APIC ID validation into an inline Thomas Gleixner
2023-08-01 10:47 ` [patch V3 42/60] x86/apic: Add max_apic_id member Thomas Gleixner
2023-08-01 10:47 ` [patch V3 43/60] x86/apic: Simplify X2APIC ID validation Thomas Gleixner
2023-08-01 10:47 ` [patch V3 44/60] x86/apic: Prepare x2APIC for using apic::max_apic_id Thomas Gleixner
2023-08-01 10:47 ` [patch V3 45/60] x86/apic: Sanitize APID ID range validation Thomas Gleixner
2023-08-08 13:34   ` Qiuxu Zhuo
2023-08-08 18:55     ` Thomas Gleixner
2023-08-09 12:01   ` Zhang, Rui
2023-08-01 10:47 ` [patch V3 46/60] x86/apic: Remove pointless NULL initializations Thomas Gleixner
2023-08-01 10:47 ` [patch V3 47/60] x86/apic/noop: Tidy up the code Thomas Gleixner
2023-08-01 10:47 ` [patch V3 48/60] x86/apic: Remove pointless arguments from [native_]eoi_write() Thomas Gleixner
2023-08-01 10:47 ` [patch V3 49/60] x86/apic: Nuke ack_APIC_irq() Thomas Gleixner
2023-08-01 10:47 ` [patch V3 50/60] x86/apic: Wrap apic->native_eoi() into a helper Thomas Gleixner
2023-08-01 10:47 ` [patch V3 51/60] x86/apic: Provide common init infrastructure Thomas Gleixner
2023-08-09  1:41   ` Qiuxu Zhuo
2023-08-01 10:47 ` [patch V3 52/60] x86/xen/apic: Use standard apic driver mechanism for Xen PV Thomas Gleixner
2023-08-01 10:47 ` [patch V3 53/60] x86/apic: Provide apic_update_callback() Thomas Gleixner
2023-08-01 10:47 ` [patch V3 54/60] x86/apic: Replace acpi_wake_cpu_handler_update() and apic_set_eoi_cb() Thomas Gleixner
2023-08-01 10:47 ` [patch V3 55/60] x86/apic: Convert other overrides to apic_update_callback() Thomas Gleixner
2023-08-01 10:47 ` [patch V3 56/60] x86/xen/apic: Mark apic __ro_after_init Thomas Gleixner
2023-08-01 10:47 ` [patch V3 57/60] x86/apic: Mark all hotpath APIC callback wrappers __always_inline Thomas Gleixner
2023-08-01 10:47 ` [patch V3 58/60] x86/apic: Wrap IPI calls into helper functions Thomas Gleixner
2023-08-01 10:47 ` [patch V3 59/60] x86/apic: Provide static call infrastructure for APIC callbacks Thomas Gleixner
2023-08-01 10:47 ` [patch V3 60/60] x86/apic: Turn on static calls Thomas Gleixner
2023-08-02 11:55 ` [patch V3 00/60] x86/apic: Decrapification and " Juergen Gross
2023-08-03  0:05 ` Sohil Mehta
2023-08-03  3:50 ` Michael Kelley (LINUX)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230801103815.428310033@linutronix.de \
    --to=tglx@linutronix.de \
    --cc=andrew.cooper3@citrix.com \
    --cc=arjan@linux.intel.com \
    --cc=jgross@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikelley@microsoft.com \
    --cc=pbonzini@redhat.com \
    --cc=peter@keresztesschmidt.de \
    --cc=peterz@infradead.org \
    --cc=thomas.lendacky@amd.com \
    --cc=wei.liu@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.