From: Jakub Kicinski <kuba@kernel.org>
To: Leon Romanovsky <leon@kernel.org>
Cc: Lin Ma <linma@zju.edu.cn>,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
fw@strlen.de, yang.lee@linux.alibaba.com, jgg@ziepe.ca,
markzhang@nvidia.com, phaddad@nvidia.com, yuancan@huawei.com,
ohartoov@nvidia.com, chenzhongjin@huawei.com, aharonl@nvidia.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rdma@vger.kernel.org
Subject: Re: [PATCH net v1 1/2] netlink: let len field used to parse type-not-care nested attrs
Date: Tue, 1 Aug 2023 10:57:26 -0700 [thread overview]
Message-ID: <20230801105726.1af6a7e1@kernel.org> (raw)
In-Reply-To: <20230801081117.GA53714@unreal>
On Tue, 1 Aug 2023 11:11:17 +0300 Leon Romanovsky wrote:
> IMHO, you are lowering too much the separation line between simple vs.
> advanced use cases.
>
> I had no idea that my use-case of passing nested netlink array is counted
> as advanced usage.
Agreed, that's a fair point. I'm guessing it was inspired by the
ethtool stats? (Which in hindsight were a mistake on my part.)
For the longest time there was no docs or best practices for netlink.
We have the documentation and more infrastructure in place now.
I hope if you wrote the code today the distinction would have been
clearer.
If we start adding APIs for various one-(two?)-offs from the past
we'll never dig ourselves out of the "no idea what's the normal use
of these APIs" hole..
next prev parent reply other threads:[~2023-08-01 17:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 12:12 [PATCH net v1 1/2] netlink: let len field used to parse type-not-care nested attrs Lin Ma
2023-07-31 19:03 ` Jakub Kicinski
2023-08-01 2:00 ` Lin Ma
2023-08-01 2:31 ` Jakub Kicinski
2023-08-01 2:40 ` Lin Ma
2023-08-01 8:11 ` Leon Romanovsky
2023-08-01 17:57 ` Jakub Kicinski [this message]
2023-08-01 19:49 ` Leon Romanovsky
2023-08-02 0:26 ` Lin Ma
2023-08-02 0:53 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230801105726.1af6a7e1@kernel.org \
--to=kuba@kernel.org \
--cc=aharonl@nvidia.com \
--cc=chenzhongjin@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linma@zju.edu.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=markzhang@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=ohartoov@nvidia.com \
--cc=pabeni@redhat.com \
--cc=phaddad@nvidia.com \
--cc=yang.lee@linux.alibaba.com \
--cc=yuancan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.