From: Christoph Hellwig <hch@lst.de>
To: "Limonciello, Mario" <mario.limonciello@amd.com>
Cc: Christoph Hellwig <hch@lst.de>,
August Wikerfors <git@augustwikerfors.se>,
Keith Busch <kbusch@kernel.org>,
axboe@fb.com, sagi@grimberg.me, linux-nvme@lists.infradead.org,
linux-kernel@vger.kernel.org, nilskruse97@gmail.com,
David.Chang@amd.com
Subject: Re: [PATCH] nvme: Don't fail to resume if NSIDs change
Date: Tue, 1 Aug 2023 13:24:03 +0200 [thread overview]
Message-ID: <20230801112403.GA3972@lst.de> (raw)
In-Reply-To: <36319a0f-34a6-9353-bc52-4d4d0fac27a5@amd.com>
On Mon, Jul 31, 2023 at 03:14:54PM -0500, Limonciello, Mario wrote:
>> No. There are tons of NVMe devices that only support creating and
>> deleting namespace out of band, especially in virtualized and cloud
>> setups.
>
> Even if it's only the error handling path only that it's checked?
Do you mean nvme_validate_ns with the error code? I wouldn't really call
that an error case, that's the function called to check namespaces are
still the same after we did a rescan (either manually or triggered by the
AEN).
> If you don't want more changes or heuristics on the error handling path for
> this case, I think the best solution is probably to pick up
>
> https://lore.kernel.org/all/20221116171727.4083-1-git@augustwikerfors.se/t/
>
> instead then and hopefully we don't end up with more disks like this.
That's probably the better idea. I know at least one of the early
quirked devices also IDs that changed for subsequent identify calls.
next prev parent reply other threads:[~2023-08-01 11:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 18:51 [PATCH] nvme: Don't fail to resume if NSIDs change Mario Limonciello
2023-07-31 19:10 ` Keith Busch
2023-07-31 19:41 ` Christoph Hellwig
2023-07-31 19:54 ` August Wikerfors
2023-07-31 20:09 ` Limonciello, Mario
2023-07-31 20:10 ` Christoph Hellwig
2023-07-31 20:14 ` Limonciello, Mario
2023-08-01 11:24 ` Christoph Hellwig [this message]
2023-08-01 11:30 ` Mario Limonciello
2023-08-01 20:29 ` Keith Busch
2023-08-01 20:34 ` Mario Limonciello
2023-08-11 20:19 ` August Wikerfors
2023-08-11 20:59 ` Keith Busch
2023-08-12 5:57 ` Greg KH
2023-08-12 5:57 ` Greg KH
2023-07-31 19:11 ` August Wikerfors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230801112403.GA3972@lst.de \
--to=hch@lst.de \
--cc=David.Chang@amd.com \
--cc=axboe@fb.com \
--cc=git@augustwikerfors.se \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mario.limonciello@amd.com \
--cc=nilskruse97@gmail.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.