From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6BC08C0015E for ; Tue, 1 Aug 2023 10:45:33 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 57891820; Tue, 1 Aug 2023 12:44:41 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 57891820 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1690886731; bh=8X1IhBdHmOt2KLDApVFaghTRm8o0NX5o3XUVnKOkhmw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=r596TdxMIM7xClQXDrry9kX9rAVu7wBGh+xKyt0PZX84PrkbkrT2diXSTS8/kQccK AhcHjeDKItjH26M2UjrmybPU6ZPNWMfOW8y0UmFvtl8ahMB9Hy02QCrBroFXYrLKCn oZu5N2xOKZZBWKqYs4aeuRujlEZ3kzD8xJO9HTo0= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 0C23BF8025A; Tue, 1 Aug 2023 12:44:13 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 6FD9CF801D5; Tue, 1 Aug 2023 12:44:13 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 010D1F801D5; Tue, 1 Aug 2023 12:44:09 +0200 (CEST) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::226]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 8D0FEF8015B for ; Tue, 1 Aug 2023 12:44:05 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 8D0FEF8015B Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=ZDFUSJCb Received: by mail.gandi.net (Postfix) with ESMTPSA id EC711C000B; Tue, 1 Aug 2023 10:44:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1690886645; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oEKysH7Y2t6RfT3AfGBp54HWpVEF5LkKbUS/QMB1QqY=; b=ZDFUSJCbj6fA75RKgaU5KyPEubtFY3VzZOU8PdM1aCEbn6YSr+BqKTYpbhrc46wMcH0s0L xbOm3AV2jxN5pU9+f/y8A9D3ioPgJhEd+sVK5My40QUl79HhUIbpj8Z6FNyH6QoT4nLscV NdL3KC+I6mGLCCwmwgWymKieJnjUTwOHTLIXhRkwbL6P451XEVX4DF5rLwP5jH755aRr5A FyunbjnU1zJ4gkeAKrjHmbUWqnP/x6TUa+mZakYm+Nj1ODX7z5jLVFZXmNjXbfvfW8mk1Z CpC9vyGyEVAFqeoF0/BJLsYkRWxGBKUslX0/qHv6q48CI5T1qUFNPHFyVl0vlQ== Date: Tue, 1 Aug 2023 12:44:01 +0200 From: Herve Codina To: Andrew Lunn Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lee Jones , Linus Walleij , Qiang Zhao , Li Yang , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Christophe Leroy , Randy Dunlap , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, Thomas Petazzoni Subject: Re: [PATCH v2 23/28] net: wan: framer: Add support for the Lantiq PEF2256 framer Message-ID: <20230801124401.3883d16c@bootlin.com> In-Reply-To: <4adae593-c428-4910-882e-7247727cf501@lunn.ch> References: <20230726150225.483464-1-herve.codina@bootlin.com> <20230726150225.483464-24-herve.codina@bootlin.com> <4adae593-c428-4910-882e-7247727cf501@lunn.ch> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: herve.codina@bootlin.com Message-ID-Hash: LFRHVJESYX7VW6UEM54ISRUP3PILNYQ7 X-Message-ID-Hash: LFRHVJESYX7VW6UEM54ISRUP3PILNYQ7 X-MailFrom: herve.codina@bootlin.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 1 Aug 2023 12:22:39 +0200 Andrew Lunn wrote: > > +static inline u8 pef2256_read8(struct pef2256 *pef2256, int offset) > > +{ > > + int val; > > + > > + regmap_read(pef2256->regmap, offset, &val); > > + return val; > > +} > > + > > +static inline void pef2256_write8(struct pef2256 *pef2256, int offset, u8 val) > > +{ > > + regmap_write(pef2256->regmap, offset, val); > > +} > > More cases of inline functions in .C files. Please let the compiler > decide. Will be changed. > > > +static void pef2256_isr_default_handler(struct pef2256 *pef2256, u8 nbr, u8 isr) > > +{ > > + dev_warn(pef2256->dev, "ISR%u: 0x%02x not handled\n", nbr, isr); > > +} > > Should this be rate limited? It is going to be very noise if it gets > called once per frame time. This function should not be called. It is wired on some interrupts and these interrupts should not be triggered. It they fired, something was wrong. I would prefer to keep this dev_warn() to keep the user informed about the problem. Regards, Hervé -- Hervé Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B7844C0015E for ; Tue, 1 Aug 2023 10:45:05 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=ZDFUSJCb; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4RFWw0248kz30BZ for ; Tue, 1 Aug 2023 20:45:04 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=ZDFUSJCb; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=bootlin.com (client-ip=2001:4b98:dc4:8::226; helo=relay6-d.mail.gandi.net; envelope-from=herve.codina@bootlin.com; receiver=lists.ozlabs.org) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::226]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4RFWtz5Z2mz2yDH for ; Tue, 1 Aug 2023 20:44:10 +1000 (AEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id EC711C000B; Tue, 1 Aug 2023 10:44:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1690886645; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oEKysH7Y2t6RfT3AfGBp54HWpVEF5LkKbUS/QMB1QqY=; b=ZDFUSJCbj6fA75RKgaU5KyPEubtFY3VzZOU8PdM1aCEbn6YSr+BqKTYpbhrc46wMcH0s0L xbOm3AV2jxN5pU9+f/y8A9D3ioPgJhEd+sVK5My40QUl79HhUIbpj8Z6FNyH6QoT4nLscV NdL3KC+I6mGLCCwmwgWymKieJnjUTwOHTLIXhRkwbL6P451XEVX4DF5rLwP5jH755aRr5A FyunbjnU1zJ4gkeAKrjHmbUWqnP/x6TUa+mZakYm+Nj1ODX7z5jLVFZXmNjXbfvfW8mk1Z CpC9vyGyEVAFqeoF0/BJLsYkRWxGBKUslX0/qHv6q48CI5T1qUFNPHFyVl0vlQ== Date: Tue, 1 Aug 2023 12:44:01 +0200 From: Herve Codina To: Andrew Lunn Subject: Re: [PATCH v2 23/28] net: wan: framer: Add support for the Lantiq PEF2256 framer Message-ID: <20230801124401.3883d16c@bootlin.com> In-Reply-To: <4adae593-c428-4910-882e-7247727cf501@lunn.ch> References: <20230726150225.483464-1-herve.codina@bootlin.com> <20230726150225.483464-24-herve.codina@bootlin.com> <4adae593-c428-4910-882e-7247727cf501@lunn.ch> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: herve.codina@bootlin.com X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, Thomas Petazzoni , Xiubo Li , Linus Walleij , Jaroslav Kysela , Eric Dumazet , Krzysztof Kozlowski , Fabio Estevam , Qiang Zhao , Shengjiu Wang , Lee Jones , Jakub Kicinski , Paolo Abeni , devicetree@vger.kernel.org, Conor Dooley , linux-kernel@vger.kernel.org, Nicolin Chen , linux-gpio@vger.kernel.org, Rob Herring , Takashi Iwai , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, Randy Dunlap , Liam Girdwood , Li Yang , Mark Brown , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, 1 Aug 2023 12:22:39 +0200 Andrew Lunn wrote: > > +static inline u8 pef2256_read8(struct pef2256 *pef2256, int offset) > > +{ > > + int val; > > + > > + regmap_read(pef2256->regmap, offset, &val); > > + return val; > > +} > > + > > +static inline void pef2256_write8(struct pef2256 *pef2256, int offset, u8 val) > > +{ > > + regmap_write(pef2256->regmap, offset, val); > > +} > > More cases of inline functions in .C files. Please let the compiler > decide. Will be changed. > > > +static void pef2256_isr_default_handler(struct pef2256 *pef2256, u8 nbr, u8 isr) > > +{ > > + dev_warn(pef2256->dev, "ISR%u: 0x%02x not handled\n", nbr, isr); > > +} > > Should this be rate limited? It is going to be very noise if it gets > called once per frame time. This function should not be called. It is wired on some interrupts and these interrupts should not be triggered. It they fired, something was wrong. I would prefer to keep this dev_warn() to keep the user informed about the problem. Regards, Hervé -- Hervé Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B18F3C0015E for ; Tue, 1 Aug 2023 10:44:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fj7vJ49NNwMl7GrpT809dyCPkYLABc3A9tsNjXgLOfU=; b=l608xZUQahwihI FfQboOQeZIgO6UAGzsfvaUjs5DT0KGiYIjdEhe58pzMnCbLsCkfcrWje38rXzjpIMTUf8g1swxCrV CRP9OAX5HgTKDfVtEGYbFWR5VMomh7R/6Nf2D5SgnBrjOQQU1OsuhA0HUMqwDJfefsE3ElmZTp8z2 lGyRKRXysf01/O0gxDPmlrG+mowI+ClsENAqPcmwm/kiYBqr31rf3nwF8bHXuDvJeyv0y5VQ/z3sg 8erjQovXgaJUuLY+fmncJB3zkyNcbEE95I2fBFjyzAklTPDNQ0w2kFuSxoruyjUU1qvEL0CKZAo5z HtoWenKd+zxfFl//D31Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qQmrK-001ypD-0u; Tue, 01 Aug 2023 10:44:10 +0000 Received: from relay6-d.mail.gandi.net ([217.70.183.198]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qQmrH-001yoF-2r for linux-arm-kernel@lists.infradead.org; Tue, 01 Aug 2023 10:44:09 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id EC711C000B; Tue, 1 Aug 2023 10:44:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1690886645; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oEKysH7Y2t6RfT3AfGBp54HWpVEF5LkKbUS/QMB1QqY=; b=ZDFUSJCbj6fA75RKgaU5KyPEubtFY3VzZOU8PdM1aCEbn6YSr+BqKTYpbhrc46wMcH0s0L xbOm3AV2jxN5pU9+f/y8A9D3ioPgJhEd+sVK5My40QUl79HhUIbpj8Z6FNyH6QoT4nLscV NdL3KC+I6mGLCCwmwgWymKieJnjUTwOHTLIXhRkwbL6P451XEVX4DF5rLwP5jH755aRr5A FyunbjnU1zJ4gkeAKrjHmbUWqnP/x6TUa+mZakYm+Nj1ODX7z5jLVFZXmNjXbfvfW8mk1Z CpC9vyGyEVAFqeoF0/BJLsYkRWxGBKUslX0/qHv6q48CI5T1qUFNPHFyVl0vlQ== Date: Tue, 1 Aug 2023 12:44:01 +0200 From: Herve Codina To: Andrew Lunn Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lee Jones , Linus Walleij , Qiang Zhao , Li Yang , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Christophe Leroy , Randy Dunlap , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, Thomas Petazzoni Subject: Re: [PATCH v2 23/28] net: wan: framer: Add support for the Lantiq PEF2256 framer Message-ID: <20230801124401.3883d16c@bootlin.com> In-Reply-To: <4adae593-c428-4910-882e-7247727cf501@lunn.ch> References: <20230726150225.483464-1-herve.codina@bootlin.com> <20230726150225.483464-24-herve.codina@bootlin.com> <4adae593-c428-4910-882e-7247727cf501@lunn.ch> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: herve.codina@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230801_034408_054772_827E55A4 X-CRM114-Status: GOOD ( 13.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCAxIEF1ZyAyMDIzIDEyOjIyOjM5ICswMjAwCkFuZHJldyBMdW5uIDxhbmRyZXdAbHVu bi5jaD4gd3JvdGU6Cgo+ID4gK3N0YXRpYyBpbmxpbmUgdTggcGVmMjI1Nl9yZWFkOChzdHJ1Y3Qg cGVmMjI1NiAqcGVmMjI1NiwgaW50IG9mZnNldCkKPiA+ICt7Cj4gPiArCWludCB2YWw7Cj4gPiAr Cj4gPiArCXJlZ21hcF9yZWFkKHBlZjIyNTYtPnJlZ21hcCwgb2Zmc2V0LCAmdmFsKTsKPiA+ICsJ cmV0dXJuIHZhbDsKPiA+ICt9Cj4gPiArCj4gPiArc3RhdGljIGlubGluZSB2b2lkIHBlZjIyNTZf d3JpdGU4KHN0cnVjdCBwZWYyMjU2ICpwZWYyMjU2LCBpbnQgb2Zmc2V0LCB1OCB2YWwpCj4gPiAr ewo+ID4gKwlyZWdtYXBfd3JpdGUocGVmMjI1Ni0+cmVnbWFwLCBvZmZzZXQsIHZhbCk7Cj4gPiAr fSAgCj4gCj4gTW9yZSBjYXNlcyBvZiBpbmxpbmUgZnVuY3Rpb25zIGluIC5DIGZpbGVzLiBQbGVh c2UgbGV0IHRoZSBjb21waWxlcgo+IGRlY2lkZS4KCldpbGwgYmUgY2hhbmdlZC4KCj4gCj4gPiAr c3RhdGljIHZvaWQgcGVmMjI1Nl9pc3JfZGVmYXVsdF9oYW5kbGVyKHN0cnVjdCBwZWYyMjU2ICpw ZWYyMjU2LCB1OCBuYnIsIHU4IGlzcikKPiA+ICt7Cj4gPiArCWRldl93YXJuKHBlZjIyNTYtPmRl diwgIklTUiV1OiAweCUwMnggbm90IGhhbmRsZWRcbiIsIG5iciwgaXNyKTsKPiA+ICt9ICAKPiAK PiBTaG91bGQgdGhpcyBiZSByYXRlIGxpbWl0ZWQ/IEl0IGlzIGdvaW5nIHRvIGJlIHZlcnkgbm9p c2UgaWYgaXQgZ2V0cwo+IGNhbGxlZCBvbmNlIHBlciBmcmFtZSB0aW1lLgoKVGhpcyBmdW5jdGlv biBzaG91bGQgbm90IGJlIGNhbGxlZC4KSXQgaXMgd2lyZWQgb24gc29tZSBpbnRlcnJ1cHRzIGFu ZCB0aGVzZSBpbnRlcnJ1cHRzIHNob3VsZCBub3QgYmUgdHJpZ2dlcmVkLgpJdCB0aGV5IGZpcmVk LCBzb21ldGhpbmcgd2FzIHdyb25nLgoKSSB3b3VsZCBwcmVmZXIgdG8ga2VlcCB0aGlzIGRldl93 YXJuKCkgdG8ga2VlcCB0aGUgdXNlciBpbmZvcm1lZCBhYm91dCB0aGUKcHJvYmxlbS4KClJlZ2Fy ZHMsCkhlcnbDqQoKCi0tIApIZXJ2w6kgQ29kaW5hLCBCb290bGluCkVtYmVkZGVkIExpbnV4IGFu ZCBLZXJuZWwgZW5naW5lZXJpbmcKaHR0cHM6Ly9ib290bGluLmNvbQoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5n IGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=