From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: Yue Haibing <yuehaibing@huawei.com>,
davem@davemloft.net, dsahern@kernel.org, pabeni@redhat.com,
yoshfuji@linux-ipv6.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, simon.horman@corigine.com
Subject: Re: [PATCH v3] ip6mr: Fix skb_under_panic in ip6mr_cache_report()
Date: Tue, 1 Aug 2023 13:11:46 -0700 [thread overview]
Message-ID: <20230801131146.51a9aaf3@kernel.org> (raw)
In-Reply-To: <CANn89iJO44CiUjftDZHEjOCy5Q3-PDB12uWTkrbA5JJNXMoeDA@mail.gmail.com>
On Tue, 1 Aug 2023 09:51:29 +0200 Eric Dumazet wrote:
> > - skb_push(skb, -skb_network_offset(pkt));
> > + __skb_pull(skb, skb_network_offset(pkt));
> >
> > skb_push(skb, sizeof(*msg));
> > skb_reset_transport_header(skb);
>
> Presumably this code has never been tested :/
Could have been tested on 32bit, I wonder if there is more such bugs :S
next prev parent reply other threads:[~2023-08-01 20:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 6:43 [PATCH v3] ip6mr: Fix skb_under_panic in ip6mr_cache_report() Yue Haibing
2023-08-01 7:51 ` Eric Dumazet
2023-08-01 20:11 ` Jakub Kicinski [this message]
2023-08-02 0:52 ` David Ahern
2023-08-02 1:28 ` YueHaibing
2023-08-02 2:10 ` Jakub Kicinski
2023-08-02 3:18 ` David Ahern
2023-08-02 9:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230801131146.51a9aaf3@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=simon.horman@corigine.com \
--cc=yoshfuji@linux-ipv6.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.