From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A6178C001E0 for ; Tue, 1 Aug 2023 11:14:15 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C4F0F82B; Tue, 1 Aug 2023 13:13:23 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C4F0F82B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1690888453; bh=QXkC/QZ+MsDhBnKnOgcZ25fX4ivId3Q3mXG4q9a8T7A=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=izcL73vw87MgSyK3nZEyLQ9kheO+KiHb7eoBqfMleKmXLDGtVCMiwWMGmQtHVcVur bH/AlCRHHaQjJnplgCDlSXXWXyhp5plNvFMjqjz3YXjZqApqF0UGBRytbyLO/GPrKQ Td3lbhTSW7QpDKOou6sRGw1kus2o6RD0lbOaZH9I= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 9934EF80558; Tue, 1 Aug 2023 13:12:52 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 53459F80558; Tue, 1 Aug 2023 13:12:52 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id D6E2AF80558; Tue, 1 Aug 2023 13:12:48 +0200 (CEST) Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 9E881F80548 for ; Tue, 1 Aug 2023 13:12:45 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 9E881F80548 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=YeU1uU9D Received: by mail.gandi.net (Postfix) with ESMTPSA id DB788FF802; Tue, 1 Aug 2023 11:12:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1690888365; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U9XcoEVaGb/SzYJ6mJdNzeh0I7lywmTLcinYtPtZJ0c=; b=YeU1uU9DZXfTdXg8TFeI2o8Vqm7D8c1Fnm2DfojyufbZMvZGwcPjdBxRDg8U36hs3GEZNV RfioyzIjkZexR02ZLxdAkOfjwbF1bhjx0ieuUzu/mAHaPNwJQsd0PS6Wnw6126hLkLetZ5 Jje7zJ+VKap558GZ+oGgWv5oJscKoNwWOHSOTKJU+P4lyu+Gu5z5Nt6HjN3O7V25JsDewD ggblvVDvfqULX9YEURYbqlRVqkpWoTW7Z8jtWNqqW9U1XTZzNG+09ROmeraVwAd5Qf+Hqg +i4317dj/J6MOo8/Sais9wdrdmM/YCAHzsMdFKTCOSORGRoquZoMA+03nt5CQQ== Date: Tue, 1 Aug 2023 13:12:35 +0200 From: Herve Codina To: Andrew Lunn Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lee Jones , Linus Walleij , Qiang Zhao , Li Yang , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Christophe Leroy , Randy Dunlap , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, Thomas Petazzoni Subject: Re: [PATCH v2 23/28] net: wan: framer: Add support for the Lantiq PEF2256 framer Message-ID: <20230801131235.10ad334a@bootlin.com> In-Reply-To: References: <20230726150225.483464-1-herve.codina@bootlin.com> <20230726150225.483464-24-herve.codina@bootlin.com> <4adae593-c428-4910-882e-7247727cf501@lunn.ch> <20230801124401.3883d16c@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: herve.codina@bootlin.com Message-ID-Hash: JLG5TLIZPPM4M4FEBMNGPEMVG4ERHPLC X-Message-ID-Hash: JLG5TLIZPPM4M4FEBMNGPEMVG4ERHPLC X-MailFrom: herve.codina@bootlin.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 1 Aug 2023 12:52:29 +0200 Andrew Lunn wrote: > > > > +static void pef2256_isr_default_handler(struct pef2256 *pef2256, u8 nbr, u8 isr) > > > > +{ > > > > + dev_warn(pef2256->dev, "ISR%u: 0x%02x not handled\n", nbr, isr); > > > > +} > > > > > > Should this be rate limited? It is going to be very noise if it gets > > > called once per frame time. > > > > This function should not be called. > > It is wired on some interrupts and these interrupts should not be triggered. > > It they fired, something was wrong. > > > > I would prefer to keep this dev_warn() to keep the user informed about the > > problem. > > I would definitely keep it, but rate limit it. dev_warn_ratelimited(). > > Andrew Ok, will be changed to dev_warn_ratelimited(). Hervé From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5BC0FC001DF for ; Tue, 1 Aug 2023 11:13:47 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=YeU1uU9D; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4RFXY54wwcz3bsP for ; Tue, 1 Aug 2023 21:13:45 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=YeU1uU9D; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=bootlin.com (client-ip=217.70.183.199; helo=relay9-d.mail.gandi.net; envelope-from=herve.codina@bootlin.com; receiver=lists.ozlabs.org) Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4RFXX44R6Pz2xqp for ; Tue, 1 Aug 2023 21:12:50 +1000 (AEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id DB788FF802; Tue, 1 Aug 2023 11:12:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1690888365; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U9XcoEVaGb/SzYJ6mJdNzeh0I7lywmTLcinYtPtZJ0c=; b=YeU1uU9DZXfTdXg8TFeI2o8Vqm7D8c1Fnm2DfojyufbZMvZGwcPjdBxRDg8U36hs3GEZNV RfioyzIjkZexR02ZLxdAkOfjwbF1bhjx0ieuUzu/mAHaPNwJQsd0PS6Wnw6126hLkLetZ5 Jje7zJ+VKap558GZ+oGgWv5oJscKoNwWOHSOTKJU+P4lyu+Gu5z5Nt6HjN3O7V25JsDewD ggblvVDvfqULX9YEURYbqlRVqkpWoTW7Z8jtWNqqW9U1XTZzNG+09ROmeraVwAd5Qf+Hqg +i4317dj/J6MOo8/Sais9wdrdmM/YCAHzsMdFKTCOSORGRoquZoMA+03nt5CQQ== Date: Tue, 1 Aug 2023 13:12:35 +0200 From: Herve Codina To: Andrew Lunn Subject: Re: [PATCH v2 23/28] net: wan: framer: Add support for the Lantiq PEF2256 framer Message-ID: <20230801131235.10ad334a@bootlin.com> In-Reply-To: References: <20230726150225.483464-1-herve.codina@bootlin.com> <20230726150225.483464-24-herve.codina@bootlin.com> <4adae593-c428-4910-882e-7247727cf501@lunn.ch> <20230801124401.3883d16c@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: herve.codina@bootlin.com X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, Thomas Petazzoni , Xiubo Li , Linus Walleij , Jaroslav Kysela , Eric Dumazet , Krzysztof Kozlowski , Fabio Estevam , Qiang Zhao , Shengjiu Wang , Lee Jones , Jakub Kicinski , Paolo Abeni , devicetree@vger.kernel.org, Conor Dooley , linux-kernel@vger.kernel.org, Nicolin Chen , linux-gpio@vger.kernel.org, Rob Herring , Takashi Iwai , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, Randy Dunlap , Liam Girdwood , Li Yang , Mark Brown , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, 1 Aug 2023 12:52:29 +0200 Andrew Lunn wrote: > > > > +static void pef2256_isr_default_handler(struct pef2256 *pef2256, u8 nbr, u8 isr) > > > > +{ > > > > + dev_warn(pef2256->dev, "ISR%u: 0x%02x not handled\n", nbr, isr); > > > > +} > > > > > > Should this be rate limited? It is going to be very noise if it gets > > > called once per frame time. > > > > This function should not be called. > > It is wired on some interrupts and these interrupts should not be triggered. > > It they fired, something was wrong. > > > > I would prefer to keep this dev_warn() to keep the user informed about the > > problem. > > I would definitely keep it, but rate limit it. dev_warn_ratelimited(). > > Andrew Ok, will be changed to dev_warn_ratelimited(). Hervé From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 423D7C001E0 for ; Tue, 1 Aug 2023 11:13:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CoHA5umtNJCoc351j+fTDjW7LRELR7Q1RjfdZ2AQYrQ=; b=XsRQmQLnJlyWAS FtjUok8O2OQPM5O8Rp44Y7CgbxMnL3GFGZeC5m9QrWeWlhOuy2DpcePvOQLahxkKwISNU6+ZFB1CK 5DBQO2gERtMe4QYiHp2kNdwua6d+CAodNBOL7EH0phZRytO4XbjRtPDu6U7+T/WmASNV8H+sXSo1s XI7SfINg1vnQ7a6D7tSedS9f1a+p3TCj6KVhwVjyP+sB6yGuYDodfk73NwwQGfCObdVwYHGxvhiQu j+kVILEutNuOjF7UXrYWOhYgM1JRVZjM4ObdpLGFH0DMkhG2P1a9esuLKKh9xpFZDKhJQV2KtJRr/ bp+m/MpY193B3PB99C3w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qQnJ3-002448-3C; Tue, 01 Aug 2023 11:12:50 +0000 Received: from relay9-d.mail.gandi.net ([2001:4b98:dc4:8::229]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qQnJ1-00242m-2c for linux-arm-kernel@lists.infradead.org; Tue, 01 Aug 2023 11:12:49 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id DB788FF802; Tue, 1 Aug 2023 11:12:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1690888365; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U9XcoEVaGb/SzYJ6mJdNzeh0I7lywmTLcinYtPtZJ0c=; b=YeU1uU9DZXfTdXg8TFeI2o8Vqm7D8c1Fnm2DfojyufbZMvZGwcPjdBxRDg8U36hs3GEZNV RfioyzIjkZexR02ZLxdAkOfjwbF1bhjx0ieuUzu/mAHaPNwJQsd0PS6Wnw6126hLkLetZ5 Jje7zJ+VKap558GZ+oGgWv5oJscKoNwWOHSOTKJU+P4lyu+Gu5z5Nt6HjN3O7V25JsDewD ggblvVDvfqULX9YEURYbqlRVqkpWoTW7Z8jtWNqqW9U1XTZzNG+09ROmeraVwAd5Qf+Hqg +i4317dj/J6MOo8/Sais9wdrdmM/YCAHzsMdFKTCOSORGRoquZoMA+03nt5CQQ== Date: Tue, 1 Aug 2023 13:12:35 +0200 From: Herve Codina To: Andrew Lunn Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lee Jones , Linus Walleij , Qiang Zhao , Li Yang , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Christophe Leroy , Randy Dunlap , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, Thomas Petazzoni Subject: Re: [PATCH v2 23/28] net: wan: framer: Add support for the Lantiq PEF2256 framer Message-ID: <20230801131235.10ad334a@bootlin.com> In-Reply-To: References: <20230726150225.483464-1-herve.codina@bootlin.com> <20230726150225.483464-24-herve.codina@bootlin.com> <4adae593-c428-4910-882e-7247727cf501@lunn.ch> <20230801124401.3883d16c@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: herve.codina@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230801_041247_996133_1B30F84D X-CRM114-Status: GOOD ( 15.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCAxIEF1ZyAyMDIzIDEyOjUyOjI5ICswMjAwCkFuZHJldyBMdW5uIDxhbmRyZXdAbHVu bi5jaD4gd3JvdGU6Cgo+ID4gPiA+ICtzdGF0aWMgdm9pZCBwZWYyMjU2X2lzcl9kZWZhdWx0X2hh bmRsZXIoc3RydWN0IHBlZjIyNTYgKnBlZjIyNTYsIHU4IG5iciwgdTggaXNyKQo+ID4gPiA+ICt7 Cj4gPiA+ID4gKwlkZXZfd2FybihwZWYyMjU2LT5kZXYsICJJU1IldTogMHglMDJ4IG5vdCBoYW5k bGVkXG4iLCBuYnIsIGlzcik7Cj4gPiA+ID4gK30gICAgCj4gPiA+IAo+ID4gPiBTaG91bGQgdGhp cyBiZSByYXRlIGxpbWl0ZWQ/IEl0IGlzIGdvaW5nIHRvIGJlIHZlcnkgbm9pc2UgaWYgaXQgZ2V0 cwo+ID4gPiBjYWxsZWQgb25jZSBwZXIgZnJhbWUgdGltZS4gIAo+ID4gCj4gPiBUaGlzIGZ1bmN0 aW9uIHNob3VsZCBub3QgYmUgY2FsbGVkLgo+ID4gSXQgaXMgd2lyZWQgb24gc29tZSBpbnRlcnJ1 cHRzIGFuZCB0aGVzZSBpbnRlcnJ1cHRzIHNob3VsZCBub3QgYmUgdHJpZ2dlcmVkLgo+ID4gSXQg dGhleSBmaXJlZCwgc29tZXRoaW5nIHdhcyB3cm9uZy4KPiA+IAo+ID4gSSB3b3VsZCBwcmVmZXIg dG8ga2VlcCB0aGlzIGRldl93YXJuKCkgdG8ga2VlcCB0aGUgdXNlciBpbmZvcm1lZCBhYm91dCB0 aGUKPiA+IHByb2JsZW0uICAKPiAKPiBJIHdvdWxkIGRlZmluaXRlbHkga2VlcCBpdCwgYnV0IHJh dGUgbGltaXQgaXQuIGRldl93YXJuX3JhdGVsaW1pdGVkKCkuCj4gCj4gCUFuZHJldwoKT2ssIHdp bGwgYmUgY2hhbmdlZCB0byBkZXZfd2Fybl9yYXRlbGltaXRlZCgpLgoKSGVydsOpCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVs IG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDov L2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==