From: Andi Shyti <andi.shyti@kernel.org>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Arnd Bergmann <arnd@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
Stefano Garzarella <sgarzare@redhat.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Feng Liu <feliu@nvidia.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, Wolfram Sang <wsa@kernel.org>
Subject: Re: [PATCH] virtio: Remove PM #ifdef guards to fix i2c driver
Date: Wed, 2 Aug 2023 01:42:24 +0200 [thread overview]
Message-ID: <20230801234224.e33sikkjug276ktt@intel.intel> (raw)
In-Reply-To: <c809220b8f10c6c9a3d05bbbd416fbb27d654d2d.camel@crapouillou.net>
Hi,
On Wed, Aug 02, 2023 at 01:06:47AM +0200, Paul Cercueil wrote:
> Hi,
>
> Le mardi 01 août 2023 à 12:58 +0200, Arnd Bergmann a écrit :
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > A cleanup in the virtio i2c caused a build failure:
> >
> > drivers/i2c/busses/i2c-virtio.c:270:10: error: 'struct virtio_driver'
> > has no member named 'freeze'
> > drivers/i2c/busses/i2c-virtio.c:271:10: error: 'struct virtio_driver'
> > has no member named 'restore'
> >
> > Change the structure definition to allow this cleanup to
> > be applied everywhere.
> >
> > Fixes: 73d546c76235b ("i2c: virtio: Remove #ifdef guards for PM
> > related functions")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Thanks, I didn't realize it was merged already.
>
> Reviewed-by: Paul Cercueil <paul@crapouillou.net>
Actually this fix is taken from linux-next, it's not in
Wolfram's branch, it's in mine. I can still force-push a fixed
version in Paul's original patch in order to avoid breaking the
bisectability.
Andi
next prev parent reply other threads:[~2023-08-01 23:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 10:58 [PATCH] virtio: Remove PM #ifdef guards to fix i2c driver Arnd Bergmann
2023-08-01 22:20 ` Andi Shyti
2023-08-01 23:06 ` Paul Cercueil
2023-08-01 23:42 ` Andi Shyti [this message]
2023-08-02 20:10 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230801234224.e33sikkjug276ktt@intel.intel \
--to=andi.shyti@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=feliu@nvidia.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=paul@crapouillou.net \
--cc=sgarzare@redhat.com \
--cc=viresh.kumar@linaro.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=wsa@kernel.org \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.