From: Greg KH <gregkh@linuxfoundation.org>
To: SeongJae Park <sj@kernel.org>
Cc: stable@vger.kernel.org, M A Ramdhan <ramdhan@starlabs.sg>,
sashal@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, hailmo@amazon.com,
Jamal Hadi Salim <jhs@mojatatu.com>,
Pedro Tammela <pctammela@mojatatu.com>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH 4.19] net/sched: cls_fw: Fix improper refcount update leads to use-after-free
Date: Tue, 1 Aug 2023 10:21:13 +0200 [thread overview]
Message-ID: <2023080159-status-barracuda-99dd@gregkh> (raw)
In-Reply-To: <20230727174629.55740-1-sj@kernel.org>
On Thu, Jul 27, 2023 at 05:46:28PM +0000, SeongJae Park wrote:
> From: M A Ramdhan <ramdhan@starlabs.sg>
>
> [ Upstream commit 0323bce598eea038714f941ce2b22541c46d488f ]
>
> In the event of a failure in tcf_change_indev(), fw_set_parms() will
> immediately return an error after incrementing or decrementing
> reference counter in tcf_bind_filter(). If attacker can control
> reference counter to zero and make reference freed, leading to
> use after free.
>
> In order to prevent this, move the point of possible failure above the
> point where the TC_FW_CLASSID is handled.
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Reported-by: M A Ramdhan <ramdhan@starlabs.sg>
> Signed-off-by: M A Ramdhan <ramdhan@starlabs.sg>
> Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
> Reviewed-by: Pedro Tammela <pctammela@mojatatu.com>
> Message-ID: <20230705161530.52003-1-ramdhan@starlabs.sg>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: SeongJae Park <sj@kernel.org>
> ---
> net/sched/cls_fw.c | 10 +++++-----
Both now queued up, thanks.
greg k-h
prev parent reply other threads:[~2023-08-01 8:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 17:46 [PATCH 4.19] net/sched: cls_fw: Fix improper refcount update leads to use-after-free SeongJae Park
2023-08-01 8:21 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023080159-status-barracuda-99dd@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=hailmo@amazon.com \
--cc=jhs@mojatatu.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pctammela@mojatatu.com \
--cc=ramdhan@starlabs.sg \
--cc=sashal@kernel.org \
--cc=sj@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.