From: Conor Dooley <conor@kernel.org>
To: Andrea Collamati <andrea.collamati@gmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/2] dt-bindings: iio: dac: add mcp4728.yaml
Date: Thu, 3 Aug 2023 19:46:51 +0100 [thread overview]
Message-ID: <20230803-muzzle-shorten-5e59c2985a3c@spud> (raw)
In-Reply-To: <8077daef-bbcc-4162-a9c8-18bae3372878@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 743 bytes --]
On Thu, Aug 03, 2023 at 08:39:30PM +0200, Andrea Collamati wrote:
> On 8/3/23 17:21, Conor Dooley wrote:
> > On Thu, Aug 03, 2023 at 02:56:34PM +0200, Andrea Collamati wrote:
> >> Add documentation for MCP4728
> >>
> >> Signed-off-by: Andrea Collamati <andrea.collamati@gmail.com>
> > I gave you a reviewed-by on v3, is there a reason that you dropped it?
> Sorry it's the first time I try to submit a driver.
No worries. It's just hard to know if people do things intentionally or
not!
> So after your positive review I should add...
>
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
>
> I will do in v5.
But don't post a v5 for that alone, if this version is fine then it can
be picked up on application.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-08-03 18:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 12:56 [PATCH v4 0/2] add MCP4728 I2C DAC driver Andrea Collamati
2023-08-03 12:56 ` [PATCH v4 1/2] dt-bindings: iio: dac: add mcp4728.yaml Andrea Collamati
2023-08-03 15:21 ` Conor Dooley
2023-08-03 18:39 ` Andrea Collamati
2023-08-03 18:46 ` Conor Dooley [this message]
2023-08-03 12:56 ` [PATCH v4 2/2] iio: add MCP4728 I2C DAC driver Andrea Collamati
2023-08-05 18:28 ` Jonathan Cameron
2023-08-06 13:40 ` Andrea Collamati
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230803-muzzle-shorten-5e59c2985a3c@spud \
--to=conor@kernel.org \
--cc=andrea.collamati@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.