From: "Michael S. Tsirkin" <mst@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Stefano Garzarella <sgarzare@redhat.com>,
qemu-devel@nongnu.org, Fam Zheng <fam@euphon.net>,
Thomas Huth <thuth@redhat.com>,
qemu-stable@nongnu.org, Mark Kanda <mark.kanda@oracle.com>
Subject: Re: [PATCH] Revert "virtio-scsi: Send "REPORTED LUNS CHANGED" sense data upon disk hotplug events"
Date: Thu, 3 Aug 2023 16:03:04 -0400 [thread overview]
Message-ID: <20230803160255-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <2ec62ac2-763b-1211-7c25-f0513f99dd2c@redhat.com>
On Wed, Jul 12, 2023 at 10:12:13AM +0200, Paolo Bonzini wrote:
> On 7/10/23 21:40, Michael S. Tsirkin wrote:
> >
> > Acked-by: Michael S. Tsirkin<mst@redhat.com>
> >
> > Seems safest to revert, but I'll let storage guys decide whether to
> > queue this.
>
> There are multiple possibilities:
>
> 1) it's a QEMU bug that can be fixed, so no need to revert.
>
> 2) there's both a QEMU and a Linux bug, but fixing the QEMU side is enough
> to hide the Linux bug. The Linux bug can be fixed leisurely.
>
> 3) it's a Linux bug that is hard to fix, so we need to revert
>
> 4) it's a Linux bug that is worth fixing, but depending on how easy it is to
> trigger the issue we may or may not need to revert
>
> But yeah, reverting is on the table.
>
> Thanks,
>
> Paolo
time to decide?
--
MST
next prev parent reply other threads:[~2023-08-03 20:03 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 7:15 [PATCH] Revert "virtio-scsi: Send "REPORTED LUNS CHANGED" sense data upon disk hotplug events" Stefano Garzarella
2023-07-05 7:51 ` Thomas Huth
2023-07-05 12:28 ` Mark Kanda
2023-07-05 12:36 ` Stefano Garzarella
2023-07-07 15:57 ` Mark Kanda
2023-07-11 8:12 ` Stefano Garzarella
2023-07-10 19:40 ` Michael S. Tsirkin
2023-07-12 8:12 ` Paolo Bonzini
2023-08-03 20:03 ` Michael S. Tsirkin [this message]
2023-07-11 17:06 ` Stefano Garzarella
2023-07-11 17:06 ` Stefano Garzarella
2023-07-11 17:41 ` Stefan Hajnoczi
2023-07-11 17:41 ` Stefan Hajnoczi
2023-07-12 8:28 ` Stefano Garzarella
2023-07-12 8:28 ` Stefano Garzarella
2023-07-12 13:40 ` Christoph Hellwig
2023-07-12 13:40 ` Christoph Hellwig
2023-07-12 14:26 ` Paolo Bonzini
2023-07-12 14:26 ` Paolo Bonzini
2023-07-11 20:21 ` Mike Christie
2023-07-11 20:21 ` Mike Christie
2023-07-12 8:06 ` Paolo Bonzini
2023-07-12 8:06 ` Paolo Bonzini
2023-07-12 10:14 ` Stefano Garzarella
2023-07-12 10:14 ` Stefano Garzarella
2023-07-12 14:20 ` Stefano Garzarella
2023-07-12 14:20 ` Stefano Garzarella
2023-07-12 8:35 ` Paolo Bonzini
2023-07-12 8:35 ` Paolo Bonzini
2023-07-12 10:24 ` Stefano Garzarella
2023-07-12 10:24 ` Stefano Garzarella
2023-08-03 19:36 ` Michael S. Tsirkin
2023-08-03 19:56 ` Michael S. Tsirkin
2023-08-03 20:02 ` Michael S. Tsirkin
2023-08-03 21:26 ` Stefano Garzarella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230803160255-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=fam@euphon.net \
--cc=mark.kanda@oracle.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=sgarzare@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.