From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FC37C00528 for ; Fri, 4 Aug 2023 13:49:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231402AbjHDNtX (ORCPT ); Fri, 4 Aug 2023 09:49:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231387AbjHDNtW (ORCPT ); Fri, 4 Aug 2023 09:49:22 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D486D1; Fri, 4 Aug 2023 06:49:21 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B017962034; Fri, 4 Aug 2023 13:49:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 95A26C433C8; Fri, 4 Aug 2023 13:49:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1691156960; bh=c7G+cSSmTcUDFu9aTC30DcjnKRIDYVyLQN36jS76iIQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tkt7iJqPdKyEzqngJKRHev6ZDoYgz/9J6ssnKz+lwdIdSHxZaym6ppX+bdKqy4eJ2 yjOULsdE5OZKmZ9GEfegz2S4NjuVFqa2YCaW4l0MWEfcjGy3/dt/LO/ZoIbf5qmWZw SiUi3jOf5PZlN+vYqhcar9gtRAGOGBwyGlwS26cQ= Date: Fri, 4 Aug 2023 15:49:17 +0200 From: Greg Kroah-Hartman To: Trilok Soni Cc: Souradeep Chowdhury , Andy Gross , Konrad Dybcio , Krzysztof Kozlowski , Bjorn Andersson , Rob Herring , Alex Elder , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Sibi Sankar , Rajendra Nayak Subject: Re: [PATCH V25 0/3] misc: Add driver support for Data Capture and Compare unit(DCC) Message-ID: <2023080408-zoom-defraud-1ae8@gregkh> References: <774b688f-0324-9097-6504-58d15a3e6afb@quicinc.com> <2023080438-reacquire-obsessed-3e81@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2023080438-reacquire-obsessed-3e81@gregkh> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, Aug 04, 2023 at 03:47:26PM +0200, Greg Kroah-Hartman wrote: > On Thu, Aug 03, 2023 at 07:35:18AM -0700, Trilok Soni wrote: > > On 8/3/2023 12:06 AM, Souradeep Chowdhury wrote: > > > > > > > > > On 6/28/2023 3:53 PM, Souradeep Chowdhury wrote: > > > > ... > > > > > > > > > > https://git.codelinaro.org/clo/le/platform/vendor/qcom-opensource/tools/-/tree/opensource-tools.lnx.1.0.r176-rel/dcc_parser > > > > > > > > Changes in v25 > > > > > > > > * Updated the documentation of the structure dcc_config_entry as per > > > > the comments in V23 > > > > * Updated the documentation of the dcc Kconfig definition as per > > > > comment in V24 > > > > * Used u64 where applicable > > > > * Removed the mutex locks where it is not needed > > > > * Removed the use of unlikely keyword > > > > * Renamed "nr_link_list" to "max_link_list" > > > > > > > > Souradeep Chowdhury (3): > > > >    dt-bindings: misc: qcom,dcc: Add the dtschema > > > >    misc: dcc: Add driver support for Data Capture and Compare unit(DCC) > > > >    MAINTAINERS: Add the entry for DCC(Data Capture and Compare) driver > > > >      support > > > > > > > >   Documentation/ABI/testing/debugfs-driver-dcc  |   10 +- > > > >   .../devicetree/bindings/misc/qcom,dcc.yaml    |   44 + > > > >   MAINTAINERS                                   |    8 + > > > >   drivers/misc/Kconfig                          |    8 + > > > >   drivers/misc/Makefile                         |    1 + > > > >   drivers/misc/qcom-dcc.c                       | 1312 +++++++++++++++++ > > > >   6 files changed, 1378 insertions(+), 5 deletions(-) > > > >   create mode 100644 Documentation/devicetree/bindings/misc/qcom,dcc.yaml > > > >   create mode 100644 drivers/misc/qcom-dcc.c > > > > > > Gentle Ping > > > > Thank you for the reminder Souradeep. Greg and others, please see if we need > > any changes here or it can be picked up? > > It would help if the code would actually build: > > drivers/misc/qcom-dcc.c: In function ‘ready_read’: > drivers/misc/qcom-dcc.c:853:13: error: unused variable ‘ret’ [-Werror=unused-variable] > 853 | int ret = 0; > | ^~~ > > {sigh} > > How in the world was this ever tested? Ok, next time I want to see some QCOM engineers to sign off on this that it was actually tested and they can back it up that this is ready to be merged. When the code doesn't even build, that is a huge red flag that this whole thing is being rushed as it obviously was never tested in the form that was submitted for inclusion. You all know better than this. greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B76B7C001DF for ; Fri, 4 Aug 2023 13:49:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hCtMTfpa1F2QUoclX6LT69hMN6HOnfQ5DUQPyKJtxUc=; b=vRuTF10Qjmg5qS kudC05k90v0pdFcQC5Wvfouext/GcdbAxTNb2PbcdQdkuKdzG+50sFO+Idqzvb+7LEJUPLQIgFCQe Kk5MJ+8fYlqqpNHe2WnrucTmq5b9nUdp/X0c+/jYsuLlo4lcklE/NNuQvjoMQiNV9i38A0c+vQkbX y17KxnafpCkMU48kjI483iFr+hx8t6YygVxJANQIVwT560AvRUhyi6ZxriIeOyg0JciI9GMnJ5Rz2 Z9NB+/33Nq5w+BE/wmRL7+7OYx3F3iIgSG6xxyfU7eXHVrtIxc1DELXT87QigjDz7WX51jEggbaok F5xichV+aJyBpv3rIyzg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qRvBF-00CXYQ-0R; Fri, 04 Aug 2023 13:49:25 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qRvBB-00CXXv-0r for linux-arm-kernel@lists.infradead.org; Fri, 04 Aug 2023 13:49:23 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B3CB262035; Fri, 4 Aug 2023 13:49:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 95A26C433C8; Fri, 4 Aug 2023 13:49:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1691156960; bh=c7G+cSSmTcUDFu9aTC30DcjnKRIDYVyLQN36jS76iIQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tkt7iJqPdKyEzqngJKRHev6ZDoYgz/9J6ssnKz+lwdIdSHxZaym6ppX+bdKqy4eJ2 yjOULsdE5OZKmZ9GEfegz2S4NjuVFqa2YCaW4l0MWEfcjGy3/dt/LO/ZoIbf5qmWZw SiUi3jOf5PZlN+vYqhcar9gtRAGOGBwyGlwS26cQ= Date: Fri, 4 Aug 2023 15:49:17 +0200 From: Greg Kroah-Hartman To: Trilok Soni Cc: Souradeep Chowdhury , Andy Gross , Konrad Dybcio , Krzysztof Kozlowski , Bjorn Andersson , Rob Herring , Alex Elder , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Sibi Sankar , Rajendra Nayak Subject: Re: [PATCH V25 0/3] misc: Add driver support for Data Capture and Compare unit(DCC) Message-ID: <2023080408-zoom-defraud-1ae8@gregkh> References: <774b688f-0324-9097-6504-58d15a3e6afb@quicinc.com> <2023080438-reacquire-obsessed-3e81@gregkh> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2023080438-reacquire-obsessed-3e81@gregkh> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230804_064922_263377_81A8D3A3 X-CRM114-Status: GOOD ( 26.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBBdWcgMDQsIDIwMjMgYXQgMDM6NDc6MjZQTSArMDIwMCwgR3JlZyBLcm9haC1IYXJ0 bWFuIHdyb3RlOgo+IE9uIFRodSwgQXVnIDAzLCAyMDIzIGF0IDA3OjM1OjE4QU0gLTA3MDAsIFRy aWxvayBTb25pIHdyb3RlOgo+ID4gT24gOC8zLzIwMjMgMTI6MDYgQU0sIFNvdXJhZGVlcCBDaG93 ZGh1cnkgd3JvdGU6Cj4gPiA+IAo+ID4gPiAKPiA+ID4gT24gNi8yOC8yMDIzIDM6NTMgUE0sIFNv dXJhZGVlcCBDaG93ZGh1cnkgd3JvdGU6Cj4gPiAKPiA+IC4uLgo+ID4gCj4gPiA+ID4gCj4gPiA+ ID4gaHR0cHM6Ly9naXQuY29kZWxpbmFyby5vcmcvY2xvL2xlL3BsYXRmb3JtL3ZlbmRvci9xY29t LW9wZW5zb3VyY2UvdG9vbHMvLS90cmVlL29wZW5zb3VyY2UtdG9vbHMubG54LjEuMC5yMTc2LXJl bC9kY2NfcGFyc2VyCj4gPiA+ID4gCj4gPiA+ID4gQ2hhbmdlcyBpbiB2MjUKPiA+ID4gPiAKPiA+ ID4gPiAqIFVwZGF0ZWQgdGhlIGRvY3VtZW50YXRpb24gb2YgdGhlIHN0cnVjdHVyZSBkY2NfY29u ZmlnX2VudHJ5IGFzIHBlcgo+ID4gPiA+IHRoZSBjb21tZW50cyBpbiBWMjMKPiA+ID4gPiAqIFVw ZGF0ZWQgdGhlIGRvY3VtZW50YXRpb24gb2YgdGhlIGRjYyBLY29uZmlnIGRlZmluaXRpb24gYXMg cGVyCj4gPiA+ID4gY29tbWVudCBpbiBWMjQKPiA+ID4gPiAqIFVzZWQgdTY0IHdoZXJlIGFwcGxp Y2FibGUKPiA+ID4gPiAqIFJlbW92ZWQgdGhlIG11dGV4IGxvY2tzIHdoZXJlIGl0IGlzIG5vdCBu ZWVkZWQKPiA+ID4gPiAqIFJlbW92ZWQgdGhlIHVzZSBvZiB1bmxpa2VseSBrZXl3b3JkCj4gPiA+ ID4gKiBSZW5hbWVkICJucl9saW5rX2xpc3QiIHRvICJtYXhfbGlua19saXN0Igo+ID4gPiA+IAo+ ID4gPiA+IFNvdXJhZGVlcCBDaG93ZGh1cnkgKDMpOgo+ID4gPiA+IMKgwqAgZHQtYmluZGluZ3M6 IG1pc2M6IHFjb20sZGNjOiBBZGQgdGhlIGR0c2NoZW1hCj4gPiA+ID4gwqDCoCBtaXNjOiBkY2M6 IEFkZCBkcml2ZXIgc3VwcG9ydCBmb3IgRGF0YSBDYXB0dXJlIGFuZCBDb21wYXJlIHVuaXQoREND KQo+ID4gPiA+IMKgwqAgTUFJTlRBSU5FUlM6IEFkZCB0aGUgZW50cnkgZm9yIERDQyhEYXRhIENh cHR1cmUgYW5kIENvbXBhcmUpIGRyaXZlcgo+ID4gPiA+IMKgwqDCoMKgIHN1cHBvcnQKPiA+ID4g PiAKPiA+ID4gPiDCoCBEb2N1bWVudGF0aW9uL0FCSS90ZXN0aW5nL2RlYnVnZnMtZHJpdmVyLWRj Y8KgIHzCoMKgIDEwICstCj4gPiA+ID4gwqAgLi4uL2RldmljZXRyZWUvYmluZGluZ3MvbWlzYy9x Y29tLGRjYy55YW1swqDCoMKgIHzCoMKgIDQ0ICsKPiA+ID4gPiDCoCBNQUlOVEFJTkVSU8KgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgIHzCoMKgwqAgOCArCj4gPiA+ID4gwqAgZHJpdmVycy9taXNjL0tjb25maWfCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB8wqDCoMKgIDggKwo+ ID4gPiA+IMKgIGRyaXZlcnMvbWlzYy9NYWtlZmlsZcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB8wqDCoMKgIDEgKwo+ID4gPiA+IMKgIGRyaXZlcnMvbWlz Yy9xY29tLWRjYy5jwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg fCAxMzEyICsrKysrKysrKysrKysrKysrCj4gPiA+ID4gwqAgNiBmaWxlcyBjaGFuZ2VkLCAxMzc4 IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCj4gPiA+ID4gwqAgY3JlYXRlIG1vZGUgMTAw NjQ0IERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9taXNjL3Fjb20sZGNjLnlhbWwK PiA+ID4gPiDCoCBjcmVhdGUgbW9kZSAxMDA2NDQgZHJpdmVycy9taXNjL3Fjb20tZGNjLmMKPiA+ ID4gCj4gPiA+IEdlbnRsZSBQaW5nCj4gPiAKPiA+IFRoYW5rIHlvdSBmb3IgdGhlIHJlbWluZGVy IFNvdXJhZGVlcC4gR3JlZyBhbmQgb3RoZXJzLCBwbGVhc2Ugc2VlIGlmIHdlIG5lZWQKPiA+IGFu eSBjaGFuZ2VzIGhlcmUgb3IgaXQgY2FuIGJlIHBpY2tlZCB1cD8KPiAKPiBJdCB3b3VsZCBoZWxw IGlmIHRoZSBjb2RlIHdvdWxkIGFjdHVhbGx5IGJ1aWxkOgo+IAo+IGRyaXZlcnMvbWlzYy9xY29t LWRjYy5jOiBJbiBmdW5jdGlvbiDigJhyZWFkeV9yZWFk4oCZOgo+IGRyaXZlcnMvbWlzYy9xY29t LWRjYy5jOjg1MzoxMzogZXJyb3I6IHVudXNlZCB2YXJpYWJsZSDigJhyZXTigJkgWy1XZXJyb3I9 dW51c2VkLXZhcmlhYmxlXQo+ICAgODUzIHwgICAgICAgICBpbnQgcmV0ID0gMDsKPiAgICAgICB8 ICAgICAgICAgICAgIF5+fgo+IAo+IHtzaWdofQo+IAo+IEhvdyBpbiB0aGUgd29ybGQgd2FzIHRo aXMgZXZlciB0ZXN0ZWQ/CgpPaywgbmV4dCB0aW1lIEkgd2FudCB0byBzZWUgc29tZSBRQ09NIGVu Z2luZWVycyB0byBzaWduIG9mZiBvbiB0aGlzIHRoYXQKaXQgd2FzIGFjdHVhbGx5IHRlc3RlZCBh bmQgdGhleSBjYW4gYmFjayBpdCB1cCB0aGF0IHRoaXMgaXMgcmVhZHkgdG8gYmUKbWVyZ2VkLiAg V2hlbiB0aGUgY29kZSBkb2Vzbid0IGV2ZW4gYnVpbGQsIHRoYXQgaXMgYSBodWdlIHJlZCBmbGFn IHRoYXQKdGhpcyB3aG9sZSB0aGluZyBpcyBiZWluZyBydXNoZWQgYXMgaXQgb2J2aW91c2x5IHdh cyBuZXZlciB0ZXN0ZWQgaW4gdGhlCmZvcm0gdGhhdCB3YXMgc3VibWl0dGVkIGZvciBpbmNsdXNp b24uCgpZb3UgYWxsIGtub3cgYmV0dGVyIHRoYW4gdGhpcy4KCmdyZWcgay1oCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1h aWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xp c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==