Re: [PATCH] usb: typec: ucsi: Add debugfs for ucsi commands

[Greg KH <gregkh@linuxfoundation.org>]

On Fri, Aug 04, 2023 at 05:23:36PM +0530, Saranya Gopal wrote:
> --- /dev/null
> +++ b/drivers/usb/typec/ucsi/debugfs.h

No need for a full .h file for this, why not put the 2 function
prototypes in the normal uscsi file?

> @@ -0,0 +1,47 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * UCSI debugfs interface
> + *
> + * Copyright (C) 2023 Intel Corporation
> + *
> + * Authors: Rajaram Regupathy <rajaram.regupathy@intel.com>
> + *	    Gopal Saranya <saranya.gopal@intel.com>
> + */
> +
> +#ifndef __LINUX_UCSI_DEBUGFS_H
> +#define __LINUX_UCSI_DEBUGFS_H
> +
> +#include <linux/types.h>
> +
> +struct ucsi;
> +struct dentry;
> +
> +struct ucsi_debugfs_entry {
> +	u64 command;
> +	struct ucsi_data {
> +		u64 low;
> +		u64 high;
> +	} response;
> +	u32 status;
> +	struct dentry *dentry;
> +};

This can go into the .c file, right?

thanks,

greg k-h