All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Henrique Barboza <danielhb413@gmail.com>
To: qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, danielhb413@gmail.com,
	peter.maydell@linaro.org, richard.henderson@linaro.org,
	BALATON Zoltan <balaton@eik.bme.hu>
Subject: [PULL 4/7] ppc/pegasos2: Fix reg property of 64 bit BARs in device tree
Date: Fri,  4 Aug 2023 12:29:52 -0300	[thread overview]
Message-ID: <20230804152955.22316-5-danielhb413@gmail.com> (raw)
In-Reply-To: <20230804152955.22316-1-danielhb413@gmail.com>

From: BALATON Zoltan <balaton@eik.bme.hu>

The board firmware handles this correctly following the Open Firmware
standard which we missed. This fixes 64 bit BARs when using VOF.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Message-ID: <20230721221320.1311E7456AB@zero.eik.bme.hu>
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
---
 hw/ppc/pegasos2.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/hw/ppc/pegasos2.c b/hw/ppc/pegasos2.c
index 6475acfbed..075367d94d 100644
--- a/hw/ppc/pegasos2.c
+++ b/hw/ppc/pegasos2.c
@@ -781,7 +781,11 @@ static void add_pci_device(PCIBus *bus, PCIDevice *d, void *opaque)
         if (d->io_regions[i].type & PCI_BASE_ADDRESS_SPACE_IO) {
             cells[j] |= cpu_to_be32(1 << 24);
         } else {
-            cells[j] |= cpu_to_be32(2 << 24);
+            if (d->io_regions[i].type & PCI_BASE_ADDRESS_MEM_TYPE_64) {
+                cells[j] |= cpu_to_be32(3 << 24);
+            } else {
+                cells[j] |= cpu_to_be32(2 << 24);
+            }
             if (d->io_regions[i].type & PCI_BASE_ADDRESS_MEM_PREFETCH) {
                 cells[j] |= cpu_to_be32(4 << 28);
             }
-- 
2.41.0



  parent reply	other threads:[~2023-08-04 15:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-04 15:29 [PULL 0/7] ppc queue Daniel Henrique Barboza
2023-08-04 15:29 ` [PULL 1/7] ppc/pegasos2: Fix reset state of USB functions Daniel Henrique Barboza
2023-08-04 15:29 ` [PULL 2/7] ppc/pegasos2: Fix reg property of ROM BARs Daniel Henrique Barboza
2023-08-04 15:29 ` [PULL 3/7] ppc/pegasos2: Fix naming of device tree nodes Daniel Henrique Barboza
2023-08-04 15:29 ` Daniel Henrique Barboza [this message]
2023-08-04 15:29 ` [PULL 5/7] target/ppc: Implement ASDR register for ISA v3.0 for HPT Daniel Henrique Barboza
2023-08-04 15:29 ` [PULL 6/7] target/ppc: Fix pending HDEC when entering PM state Daniel Henrique Barboza
2023-08-04 15:29 ` [PULL 7/7] target/ppc: Fix VRMA page size for ISA v3.0 Daniel Henrique Barboza
2023-08-04 19:37 ` [PULL 0/7] ppc queue Richard Henderson
2023-08-05  6:56 ` Michael Tokarev
2023-08-06 20:09   ` Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230804152955.22316-5-danielhb413@gmail.com \
    --to=danielhb413@gmail.com \
    --cc=balaton@eik.bme.hu \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.