From: Jakub Kicinski <kuba@kernel.org>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: s.shtylyov@omp.ru, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] net: renesas: rswitch: Add runtime speed change support
Date: Fri, 4 Aug 2023 18:02:32 -0700 [thread overview]
Message-ID: <20230804180232.68813359@kernel.org> (raw)
In-Reply-To: <20230803120621.1471440-2-yoshihiro.shimoda.uh@renesas.com>
On Thu, 3 Aug 2023 21:06:20 +0900 Yoshihiro Shimoda wrote:
> +static const struct soc_device_attribute rswitch_soc_match[] = {
nit: maybe a better than for this table would be good?
To indicate what IDs it holds. E.g. rswitch_soc_no_speed_change[] ?
> + { .soc_id = "r8a779f0", .revision = "ES1.0" },
> + { /* Sentinel */ }
> +};
--
pw-bot: cr
next prev parent reply other threads:[~2023-08-05 1:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 12:06 [PATCH net-next 0/2] net: renesas: rswitch: Add speed change support Yoshihiro Shimoda
2023-08-03 12:06 ` [PATCH net-next 1/2] net: renesas: rswitch: Add runtime " Yoshihiro Shimoda
2023-08-05 1:02 ` Jakub Kicinski [this message]
2023-08-06 23:58 ` Yoshihiro Shimoda
2023-08-03 12:06 ` [PATCH net-next 2/2] net: renesas: rswitch: Add .[gs]et_link_ksettings support Yoshihiro Shimoda
2023-08-04 13:47 ` [PATCH net-next 0/2] net: renesas: rswitch: Add speed change support Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230804180232.68813359@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=s.shtylyov@omp.ru \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.