From: Andi Shyti <andi.shyti@kernel.org>
To: Parker Newman <pnewman@connecttech.com>
Cc: Laxman Dewangan <ldewangan@nvidia.com>,
Dmitry Osipenko <digetx@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Akhil R <akhilrajeev@nvidia.com>
Subject: Re: [PATCH] i2c: tegra: Fix i2c-tegra DMA config option processing
Date: Fri, 4 Aug 2023 23:56:31 +0200 [thread overview]
Message-ID: <20230804215631.wc22pkyetsyyt5ye@intel.intel> (raw)
In-Reply-To: <fcfcf9b3-c8c4-9b34-2ff8-cd60a3d490bd@connecttech.com>
BTW...
On Thu, Aug 03, 2023 at 05:10:02PM +0000, Parker Newman wrote:
>
you have a blank line here.
> This patch fixes the Tegra DMA config option processing in the
> i2c-tegra driver.
>
> Tegra processors prior to Tegra186 used APB DMA for I2C requiring
> CONFIG_TEGRA20_APB_DMA=y while Tegra186 and later use GPC DMA requiring
> CONFIG_TEGRA186_GPC_DMA=y.
>
> The check for if the processor uses APB DMA is inverted and so the wrong
> DMA config options are checked.
>
> This means if CONFIG_TEGRA20_APB_DMA=y but CONFIG_TEGRA186_GPC_DMA=n
> with a Tegra186 or later processor the driver will incorrectly think DMA is
> enabled and attempt to request DMA channels that will never be availible,
> leaving the driver in a perpetual EPROBE_DEFER state.
>
> Signed-off-by: Parker Newman <pnewman@connecttech.com>
As this is a fix you also need to add
Fixes: 48cb6356fae1 ("i2c: tegra: Add GPCDMA support")
Cc: Akhil R <akhilrajeev@nvidia.com>
Cc: <stable@vger.kernel.org> # v6.1+
Cc'eing Akhil as well for his opinion on this.
Andi
next prev parent reply other threads:[~2023-08-04 21:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 17:10 [PATCH] i2c: tegra: Fix i2c-tegra DMA config option processing Parker Newman
2023-08-04 21:49 ` Andi Shyti
2023-08-14 15:25 ` Dmitry Osipenko
2023-08-14 15:54 ` Parker Newman
2023-08-04 21:56 ` Andi Shyti [this message]
2023-08-06 14:21 ` Akhil R
2023-08-08 12:42 ` Parker Newman
2023-08-08 13:23 ` Andi Shyti
2023-08-14 13:37 ` Wolfram Sang
2023-08-14 14:26 ` Akhil R
2023-08-08 14:05 ` Andi Shyti
2023-08-14 13:38 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230804215631.wc22pkyetsyyt5ye@intel.intel \
--to=andi.shyti@kernel.org \
--cc=akhilrajeev@nvidia.com \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=pnewman@connecttech.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.