From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2553FA947 for ; Sat, 5 Aug 2023 14:20:55 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1C4471FB; Sat, 5 Aug 2023 07:21:38 -0700 (PDT) Received: from slackpad.lan (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D196F3F59C; Sat, 5 Aug 2023 07:20:51 -0700 (PDT) Date: Sat, 5 Aug 2023 15:19:50 +0100 From: Andre Przywara To: Martin Botka Cc: martin.botka1@gmail.com, Konrad Dybcio , AngeloGioacchino Del Regno , Marijn Suijten , Jami Kettunen , Paul Bouchara , Martin Botka , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Ludwig Kormann , Icenowy Zheng , Andrew Lunn , Heiko Stuebner , Shawn Guo , Bjorn Andersson , Chris Morgan , Jagan Teki , Maxime Ripard , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 4/4] arm64: dts: allwinner: h616: Add BigTreeTech Pi support Message-ID: <20230805151950.13680fb9@slackpad.lan> In-Reply-To: <8022803C8A2B3898+20230805083636.788048-5-martin@biqu3d.com> References: <20230805083636.788048-1-martin@biqu3d.com> <8022803C8A2B3898+20230805083636.788048-5-martin@biqu3d.com> Organization: Arm Ltd. X-Mailer: Claws Mail 4.1.1 (GTK 3.24.31; x86_64-slackware-linux-gnu) Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sat, 5 Aug 2023 10:36:07 +0200 Martin Botka wrote: Hi, > The BigTreeTech Pi is an H616 based board based on CB1. > Just in Rpi format board. > > It features the same internals as BTT CB1 but adds: > - Fan port > - IR receiver > - ADXL345 Accelerometer connector via SPI > - 24V DC power supply via terminal plugs > - USB to CAN module connector (The actual USB to CAN happens on the external module) > > List of currently working things is same as BTT CB1 but also: > - IR receiver > - ADXL345 connector > > Signed-off-by: Martin Botka Thanks, looks good now, all tests pass: Reviewed-by: Andre Przywara Cheers, Andre > --- > Changes in V2: > - Add UART alongside aliases and chosen for it > - Add model string > - Enable IR receiver > - Enable SPI0 for ADXL345 connector > Changes in V3: > - Add missing semicolons > - Add pinctrl for SPI0 > > arch/arm64/boot/dts/allwinner/Makefile | 1 + > .../allwinner/sun50i-h616-bigtreetech-pi.dts | 70 +++++++++++++++++++ > 2 files changed, 71 insertions(+) > create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts > > diff --git a/arch/arm64/boot/dts/allwinner/Makefile b/arch/arm64/boot/dts/allwinner/Makefile > index 7b386428510b..0b6232a7f328 100644 > --- a/arch/arm64/boot/dts/allwinner/Makefile > +++ b/arch/arm64/boot/dts/allwinner/Makefile > @@ -39,5 +39,6 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-pine-h64-model-b.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-tanix-tx6.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-tanix-tx6-mini.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-bigtreetech-cb1-manta.dtb > +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-bigtreetech-pi.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-orangepi-zero2.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-x96-mate.dtb > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts > new file mode 100644 > index 000000000000..b0d0386e8f13 > --- /dev/null > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts > @@ -0,0 +1,70 @@ > +// SPDX-License-Identifier: (GPL-2.0+ or MIT) > +/* > + * Copyright (C) 2023 Martin Botka . > + */ > + > +/dts-v1/; > + > +#include "sun50i-h616-bigtreetech-cb1.dtsi" > + > +/ { > + model = "BigTreeTech Pi"; > + compatible = "bigtreetech,pi", "allwinner,sun50i-h616"; > + > + aliases { > + serial0 = &uart0; > + }; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > +}; > + > +&ehci0 { > + status = "okay"; > +}; > + > +&ehci1 { > + status = "okay"; > +}; > + > +&ehci2 { > + status = "okay"; > +}; > + > +&ehci3 { > + status = "okay"; > +}; > + > +&ir { > + status = "okay"; > +}; > + > +&ohci0 { > + status = "okay"; > +}; > + > +&ohci1 { > + status = "okay"; > +}; > + > +&ohci2 { > + status = "okay"; > +}; > + > +&ohci3 { > + status = "okay"; > +}; > + > +&spi0 { > + /* SPI connection for onboard connector for ADXL345 accelerometer */ > + status = "okay"; > + pinctrl-names = "default"; > + pinctrl-0 = <&spi0_pins>, <&spi0_cs0_pin>; > +}; > + > +&uart0 { > + pinctrl-names = "default"; > + pinctrl-0 = <&uart0_ph_pins>; > + status = "okay"; > +}; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6DC67C001DB for ; Sat, 5 Aug 2023 14:21:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uuWVLsq4z63g4aWKr3gOrFJeQcnctj7MppLHY414GZ8=; b=S6StssBUt7jOGM IGlQzvzcGJ2sar3zE/Gywzj90dzCLQZSTnOKxoLKYZb7IIG8pz3cswHiDG3iTach6CMBmuGdf0TUm 04SbHRrA/ZWVo68mXgv2mKiScBHu52VpSgSRwBIyokfdnQerwTPHbbkqTwowgxwgkfb7ndVDUTuHj H7saf4jEYyLSuUcbrY9x+BsKqLGnVwvdEBBwIHVib3jiCWpQnaFZ5ggIEm96MBLFFG3SqEizKs2j4 W9GwIBykqJAnJoJoEIpYsCUe5KBVHonFoH4esoiOJxooKmCf90mges1K+9PrXmQ+7VhAP8/mdoyZw FqKc9e8bFFGPLR34EHRg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qSI9N-00EE5W-13; Sat, 05 Aug 2023 14:21:01 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qSI9J-00EE4o-3D for linux-arm-kernel@lists.infradead.org; Sat, 05 Aug 2023 14:20:59 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1C4471FB; Sat, 5 Aug 2023 07:21:38 -0700 (PDT) Received: from slackpad.lan (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D196F3F59C; Sat, 5 Aug 2023 07:20:51 -0700 (PDT) Date: Sat, 5 Aug 2023 15:19:50 +0100 From: Andre Przywara To: Martin Botka Cc: martin.botka1@gmail.com, Konrad Dybcio , AngeloGioacchino Del Regno , Marijn Suijten , Jami Kettunen , Paul Bouchara , Martin Botka , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Ludwig Kormann , Icenowy Zheng , Andrew Lunn , Heiko Stuebner , Shawn Guo , Bjorn Andersson , Chris Morgan , Jagan Teki , Maxime Ripard , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 4/4] arm64: dts: allwinner: h616: Add BigTreeTech Pi support Message-ID: <20230805151950.13680fb9@slackpad.lan> In-Reply-To: <8022803C8A2B3898+20230805083636.788048-5-martin@biqu3d.com> References: <20230805083636.788048-1-martin@biqu3d.com> <8022803C8A2B3898+20230805083636.788048-5-martin@biqu3d.com> Organization: Arm Ltd. X-Mailer: Claws Mail 4.1.1 (GTK 3.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230805_072058_132239_158B5F6D X-CRM114-Status: GOOD ( 21.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 5 Aug 2023 10:36:07 +0200 Martin Botka wrote: Hi, > The BigTreeTech Pi is an H616 based board based on CB1. > Just in Rpi format board. > > It features the same internals as BTT CB1 but adds: > - Fan port > - IR receiver > - ADXL345 Accelerometer connector via SPI > - 24V DC power supply via terminal plugs > - USB to CAN module connector (The actual USB to CAN happens on the external module) > > List of currently working things is same as BTT CB1 but also: > - IR receiver > - ADXL345 connector > > Signed-off-by: Martin Botka Thanks, looks good now, all tests pass: Reviewed-by: Andre Przywara Cheers, Andre > --- > Changes in V2: > - Add UART alongside aliases and chosen for it > - Add model string > - Enable IR receiver > - Enable SPI0 for ADXL345 connector > Changes in V3: > - Add missing semicolons > - Add pinctrl for SPI0 > > arch/arm64/boot/dts/allwinner/Makefile | 1 + > .../allwinner/sun50i-h616-bigtreetech-pi.dts | 70 +++++++++++++++++++ > 2 files changed, 71 insertions(+) > create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts > > diff --git a/arch/arm64/boot/dts/allwinner/Makefile b/arch/arm64/boot/dts/allwinner/Makefile > index 7b386428510b..0b6232a7f328 100644 > --- a/arch/arm64/boot/dts/allwinner/Makefile > +++ b/arch/arm64/boot/dts/allwinner/Makefile > @@ -39,5 +39,6 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-pine-h64-model-b.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-tanix-tx6.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-tanix-tx6-mini.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-bigtreetech-cb1-manta.dtb > +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-bigtreetech-pi.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-orangepi-zero2.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-x96-mate.dtb > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts > new file mode 100644 > index 000000000000..b0d0386e8f13 > --- /dev/null > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts > @@ -0,0 +1,70 @@ > +// SPDX-License-Identifier: (GPL-2.0+ or MIT) > +/* > + * Copyright (C) 2023 Martin Botka . > + */ > + > +/dts-v1/; > + > +#include "sun50i-h616-bigtreetech-cb1.dtsi" > + > +/ { > + model = "BigTreeTech Pi"; > + compatible = "bigtreetech,pi", "allwinner,sun50i-h616"; > + > + aliases { > + serial0 = &uart0; > + }; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > +}; > + > +&ehci0 { > + status = "okay"; > +}; > + > +&ehci1 { > + status = "okay"; > +}; > + > +&ehci2 { > + status = "okay"; > +}; > + > +&ehci3 { > + status = "okay"; > +}; > + > +&ir { > + status = "okay"; > +}; > + > +&ohci0 { > + status = "okay"; > +}; > + > +&ohci1 { > + status = "okay"; > +}; > + > +&ohci2 { > + status = "okay"; > +}; > + > +&ohci3 { > + status = "okay"; > +}; > + > +&spi0 { > + /* SPI connection for onboard connector for ADXL345 accelerometer */ > + status = "okay"; > + pinctrl-names = "default"; > + pinctrl-0 = <&spi0_pins>, <&spi0_cs0_pin>; > +}; > + > +&uart0 { > + pinctrl-names = "default"; > + pinctrl-0 = <&uart0_ph_pins>; > + status = "okay"; > +}; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel