From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Thomas Devoogdt <thomas@devoogdt.com>
Cc: Adrian Perez de Castro <aperez@igalia.com>,
Eric Le Bihan <eric.le.bihan.dev@free.fr>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 1/3] package/libsoup3: new package
Date: Sun, 6 Aug 2023 16:26:16 +0200 [thread overview]
Message-ID: <20230806162616.5e7a6131@windsurf> (raw)
In-Reply-To: <20230802120150.564860-1-thomas@devoogdt.com>
Hello Thomas,
On Wed, 2 Aug 2023 14:01:48 +0200
Thomas Devoogdt <thomas@devoogdt.com> wrote:
> Libsoup3 has a new API [1], packages using libsoup may not
> compile with libsoup3 or may crash at runtime in unexpected
> ways. So add a new package.
>
> This replaces my original commit that was sent to the buildroot
> mailing list a long time ago: [2]
This paragraph is a changelog, it should not be part of the commit log,
but be mentioned below the --- sign that follows your Signed-off-by.
> diff --git a/package/libsoup3/Config.in b/package/libsoup3/Config.in
> new file mode 100644
> index 0000000000..8a6cbc1e67
> --- /dev/null
> +++ b/package/libsoup3/Config.in
> @@ -0,0 +1,40 @@
> +config BR2_PACKAGE_LIBSOUP3
> + bool "libsoup3"
> + depends on BR2_USE_WCHAR # glib2, gnutls and libpsl
> + depends on BR2_TOOLCHAIN_HAS_THREADS # glib2
> + depends on BR2_USE_MMU # glib2
> + select BR2_PACKAGE_NGHTTP2
> + select BR2_PACKAGE_LIBXML2
Actually libxml2 isn't needed. Also I have fixed alphabetic ordering,
as NGHTTP2 goes after LIBGLIB2/LIBSPL.
> +config BR2_PACKAGE_LIBSOUP3_GNOME
> + bool "libsoup3-gnome"
> + help
> + Build libsoup3-gnome library.
This option was not used anywhere, so I dropped it.
> +LIBSOUP3_DEPENDENCIES = \
> + host-intltool \
> + host-libglib2 \
> + host-pkgconf \
> + libglib2 \
> + libpsl \
> + libxml2 \
Dropped this line, of course.
Applied with those changes. Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-08-06 14:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 12:01 [Buildroot] [PATCH v2 1/3] package/libsoup3: new package Thomas Devoogdt
2023-08-02 12:01 ` [Buildroot] [PATCH v2 2/3] package/webkitgtk: add http/2 support by using libsoup3 Thomas Devoogdt
2023-08-06 14:26 ` Thomas Petazzoni via buildroot
2023-08-02 12:01 ` [Buildroot] [PATCH v2 3/3] package/wpewebkit: " Thomas Devoogdt
2023-08-06 14:26 ` Thomas Petazzoni via buildroot
2023-08-06 14:26 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230806162616.5e7a6131@windsurf \
--to=buildroot@buildroot.org \
--cc=aperez@igalia.com \
--cc=eric.le.bihan.dev@free.fr \
--cc=thomas.petazzoni@bootlin.com \
--cc=thomas@devoogdt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.