From: Arnd Bergmann <arnd@kernel.org>
To: Douglas Anderson <dianders@chromium.org>,
Michal Hocko <mhocko@suse.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Arnd Bergmann <arnd@arndb.de>, Petr Mladek <pmladek@suse.com>,
Tom Rix <trix@redhat.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH] nmi_backtrace: fix trigger_allbutcpu_cpu_backtrace() stub definition
Date: Mon, 7 Aug 2023 09:10:51 +0200 [thread overview]
Message-ID: <20230807071109.3386799-1-arnd@kernel.org> (raw)
From: Arnd Bergmann <arnd@arndb.de>
The prototype for the extern declaration was changed, but the one for
the empty stub is now missing an unused argument:
kernel/watchdog.c: In function 'watchdog_timer_fn':
kernel/watchdog.c:521:4: error: too many arguments to function 'trigger_allbutcpu_cpu_backtrace'
521 | trigger_allbutcpu_cpu_backtrace(smp_processor_id());
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from kernel/watchdog.c:17:
include/linux/nmi.h:193:20: note: declared here
193 | static inline bool trigger_allbutcpu_cpu_backtrace(void)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Fixes: 0ca1d340a231e ("nmi_backtrace: allow excluding an arbitrary CPU")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
include/linux/nmi.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/nmi.h b/include/linux/nmi.h
index 7cf7801856a1b..e92e378df000f 100644
--- a/include/linux/nmi.h
+++ b/include/linux/nmi.h
@@ -190,7 +190,7 @@ static inline bool trigger_all_cpu_backtrace(void)
{
return false;
}
-static inline bool trigger_allbutcpu_cpu_backtrace(void)
+static inline bool trigger_allbutcpu_cpu_backtrace(int exclude_cpu)
{
return false;
}
--
2.39.2
next reply other threads:[~2023-08-07 7:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-07 7:10 Arnd Bergmann [this message]
2023-08-07 7:22 ` [PATCH] nmi_backtrace: fix trigger_allbutcpu_cpu_backtrace() stub definition Thorsten Leemhuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230807071109.3386799-1-arnd@kernel.org \
--to=arnd@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=dianders@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.com \
--cc=pmladek@suse.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.