From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F9B6138E for ; Mon, 7 Aug 2023 09:00:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8B249C433C7; Mon, 7 Aug 2023 08:59:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691398801; bh=QmVrBhaaZIGexEIxrVr5yQzXkZccvr/H7z/1U9RDwug=; h=From:To:Cc:Subject:Date:From; b=bRO1ebLfkc1dNdvFh5CwMNoOpEGe9B+mKKDvrvdWqQv7nlcL8gyjI4T5jgi9ffG6W 20z2vvLVKq6OwyADPiQXG+4lRNXyuBlh0n3cWqTLf+3rI8XmqHLCULMUtf+IdCy6G8 XInMJYvYKuZVdLrrxBsCQQMeueEXsYmcN3tqYFO0UO8dteS4VAY/J6pG06pKyRMWmU hXesDDdRXCUXEelWcW59s3WaAgTjiz+6C1NRjjYWUzuyp1BptsVCWTQ+JcpaNVy1xn rhODj9cOmysmEs8f+/QWD3UzmGudDHDEMplaoBp1ks9ylGJEkGQszSEeiV+cP6FiNn q43szgTeETKEg== From: Jiri Olsa To: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko Cc: bpf@vger.kernel.org, Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , "Masami Hiramatsu (Google)" , Steven Rostedt , Alan Maguire Subject: [PATCHv3 bpf-next 0/3] bpf: Support bpf_get_func_ip helper in uprobes Date: Mon, 7 Aug 2023 10:59:53 +0200 Message-ID: <20230807085956.2344866-1-jolsa@kernel.org> X-Mailer: git-send-email 2.41.0 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit hi, adding support for bpf_get_func_ip helper for uprobe program to return probed address for both uprobe and return uprobe as suggested by Andrii in [1]. We agreed that uprobe can have special use of bpf_get_func_ip helper that differs from kprobe. The kprobe bpf_get_func_ip returns: - address of the function if probe is attach on function entry for both kprobe and return kprobe - 0 if the probe is not attach on function entry The uprobe bpf_get_func_ip returns: - address of the probe for both uprobe and return uprobe The reason for this semantic change is that kernel can't really tell if the probe user space address is function entry. v3 changes: - removed bpf_get_func_ip_uprobe helper function [Yonghong] Also available at: https://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git uprobe_get_func_ip thanks, jirka [1] https://lore.kernel.org/bpf/CAEf4BzZ=xLVkG5eurEuvLU79wAMtwho7ReR+XJAgwhFF4M-7Cg@mail.gmail.com/ --- Jiri Olsa (3): bpf: Add support for bpf_get_func_ip helper for uprobe program selftests/bpf: Add bpf_get_func_ip tests for uprobe on function entry selftests/bpf: Add bpf_get_func_ip test for uprobe inside function include/linux/bpf.h | 9 +++++++-- include/uapi/linux/bpf.h | 7 ++++++- kernel/trace/bpf_trace.c | 11 ++++++++++- kernel/trace/trace_probe.h | 5 +++++ kernel/trace/trace_uprobe.c | 7 +------ tools/include/uapi/linux/bpf.h | 7 ++++++- tools/testing/selftests/bpf/prog_tests/get_func_ip_test.c | 57 +++++++++++++++++++++++++++++++++++++++++++++++++++++---- tools/testing/selftests/bpf/progs/get_func_ip_test.c | 25 +++++++++++++++++++++++-- tools/testing/selftests/bpf/progs/get_func_ip_uprobe_test.c | 18 ++++++++++++++++++ 9 files changed, 129 insertions(+), 17 deletions(-) create mode 100644 tools/testing/selftests/bpf/progs/get_func_ip_uprobe_test.c