From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70046C001DF for ; Mon, 7 Aug 2023 12:48:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230489AbjHGMs1 (ORCPT ); Mon, 7 Aug 2023 08:48:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231193AbjHGMs0 (ORCPT ); Mon, 7 Aug 2023 08:48:26 -0400 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4271010F7; Mon, 7 Aug 2023 05:48:25 -0700 (PDT) Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-3178fa77b27so3781803f8f.2; Mon, 07 Aug 2023 05:48:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691412503; x=1692017303; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=QSsFFMDnhnoYvwOucI8nbfeRsF7SqpPW/TzWXV6mxlQ=; b=aJPpVhiiR1nJfa6ZRRn5GMPVVmiGydg5TEOZ5UY/1PgNgUfO3qqPYTmd36jFI73mB4 nVvtw86p4Mot8yid7Rp8jTM12fSpXPuFIzdo3ZnQCELDzno16dN7+4c6bfQZoBofQ1WP Z1hf29r9udmDAh35ja6M5qo/yeEXV0bhkmLQnhXaHQUM02/CB6YX3G7PJ1v+kA1pR4fZ K2yCod3dFght/Gr8hCA0AbvNRX350FAEvU7jCvKsdBEFQ7NQOGLqd+KSdrvwMSwwd6+W iEAYqHM5ryuGzZLGO5PA7cytrpUc72NfH5I2Rv1t0eS/EastVyZ1pH/zaTYtJXMVL+zi Do7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691412503; x=1692017303; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QSsFFMDnhnoYvwOucI8nbfeRsF7SqpPW/TzWXV6mxlQ=; b=TsgG+SWyuavf47H31UkFRHzylfsToz6x0FgBJd3lkqU3ryTuxOLuVUpa213hy37AUD bAqpZW9UAvCqFPBHWrYVKH6Qs5GzHOPxzllyfoBPPuQb+gY2azh3syQtkXftTLYMI49I 7J8o5yPrmNj1ArLooGrijjgkvOeG2euh5MBKDgDKiKnNm+ncXvMYRCJYDoYV4A2sZLU3 T0EBTotEyGUbivD+OS7AfVoiBrQaFSMADjcquTptU0mnRr6uV+BZUCbrKb0c5AdnQ9Wl +rxtaq5dVwc6YjeQHrjOazC3vPfJT8FZBrv9IDnAjKU4c9tVJs7PoXwZJCqOZHa49/ck x1Fg== X-Gm-Message-State: AOJu0YwXb2vRq2SNYWzBGndE1kZu1pu5HDXwlMdjFghnyb+k9fuHfSX4 FryVrLawNeMxMwthmXrWC3CCmENtz8SfxQ== X-Google-Smtp-Source: AGHT+IFx4cs/LGcPF2+8WR9/qMwP2ZFppQ/3rUwyT0TckgNaJC/wrxFbf8HK/vf79wWlN9j1cJoxag== X-Received: by 2002:a5d:65cc:0:b0:313:e8bf:a6e with SMTP id e12-20020a5d65cc000000b00313e8bf0a6emr6500008wrw.21.1691412503376; Mon, 07 Aug 2023 05:48:23 -0700 (PDT) Received: from localhost.localdomain ([92.85.190.61]) by smtp.gmail.com with ESMTPSA id k18-20020a5d66d2000000b0031417fd473csm10534017wrw.78.2023.08.07.05.48.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 05:48:22 -0700 (PDT) From: Andrei Coardos To: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: alexandre.belloni@bootlin.com, a.zummo@towertech.it, sebastian.hesselbarth@gmail.com, gregory.clement@bootlin.com, andrew@lunn.ch, alex@shruggie.ro, Andrei Coardos Subject: [PATCH] rtc: armada38x: remove unneeded call to platform_set_drvdata() Date: Mon, 7 Aug 2023 15:48:11 +0300 Message-Id: <20230807124811.16763-1-aboutphysycs@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file. Signed-off-by: Andrei Coardos --- drivers/rtc/rtc-armada38x.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/rtc/rtc-armada38x.c b/drivers/rtc/rtc-armada38x.c index b4139c200676..5ed028429565 100644 --- a/drivers/rtc/rtc-armada38x.c +++ b/drivers/rtc/rtc-armada38x.c @@ -527,7 +527,6 @@ static __init int armada38x_rtc_probe(struct platform_device *pdev) dev_warn(&pdev->dev, "Interrupt not available.\n"); rtc->irq = -1; } - platform_set_drvdata(pdev, rtc); if (rtc->irq != -1) device_init_wakeup(&pdev->dev, 1); -- 2.34.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CBC91C001B0 for ; Mon, 7 Aug 2023 12:48:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=ivHq8K7tasoDdei2wBihhThHOGSkF1i0Phz/KrlgHhY=; b=yoioIMNbrrsStE +rXicGtrKCGwImtKOEj7xeiLZMpzKqnl3W4yMesEUY/Gg4KKfGScIwYY/YhqXicDuQN7Y6pYfL2aG FsrQOOlsuinNSsDh9ipFa4vxLqNWh9y6LrphhBPCLrZI6OpsPO7dt+Pr9OunJ8tJ6kHwQG5zmhrH2 cfIqCH4qAROERoIoo8G7LyNmbbWILp5C/40zX4/BaIq1qV5w03fD5Gg4agbolN0hibo1GsJwo7RFS QQINK2iI3pBdIO9R3+bfo3nwJ6qkDVup4AS1O+8iHt0X1kAgo9jvqIUPMG9GZT1IgDBfOr/KiCBsU omcim3yK5R54ygooOaPA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qSzet-00HGko-1E; Mon, 07 Aug 2023 12:48:27 +0000 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qSzer-00HGji-0u for linux-arm-kernel@lists.infradead.org; Mon, 07 Aug 2023 12:48:26 +0000 Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-317dcdae365so1569729f8f.1 for ; Mon, 07 Aug 2023 05:48:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691412503; x=1692017303; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=QSsFFMDnhnoYvwOucI8nbfeRsF7SqpPW/TzWXV6mxlQ=; b=aJPpVhiiR1nJfa6ZRRn5GMPVVmiGydg5TEOZ5UY/1PgNgUfO3qqPYTmd36jFI73mB4 nVvtw86p4Mot8yid7Rp8jTM12fSpXPuFIzdo3ZnQCELDzno16dN7+4c6bfQZoBofQ1WP Z1hf29r9udmDAh35ja6M5qo/yeEXV0bhkmLQnhXaHQUM02/CB6YX3G7PJ1v+kA1pR4fZ K2yCod3dFght/Gr8hCA0AbvNRX350FAEvU7jCvKsdBEFQ7NQOGLqd+KSdrvwMSwwd6+W iEAYqHM5ryuGzZLGO5PA7cytrpUc72NfH5I2Rv1t0eS/EastVyZ1pH/zaTYtJXMVL+zi Do7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691412503; x=1692017303; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QSsFFMDnhnoYvwOucI8nbfeRsF7SqpPW/TzWXV6mxlQ=; b=gngonAZPQEjIvEwG3VZFFCCb3FaforgLn0cn4TSYfRNLGAZCWD4EaDaGM/vD9587hw nAN99doJMmQ+SIKkdnHmK8EA7GLGvBrmGMU2m1mJ/HDqlr76OYKfbVPq1s21MUrgMhhF 8ZezzzBHQTJGnn6Dx//FONC+axKLd3/J02X7U5ukBrB+P7qcNpgVjlLnR607O2WNJAi/ K3JpmPOiVOQp9J/s16rO07kpogs/3zb+95DHuCU29TJRTLQ+m0ZhlFQCXSKXWDma35U4 YbB3W9q4N2KQWF1ILpDWUhANH+8EU3+vCEuvxm14zQXtaSczJQYdmRfFZrvpdRqGR2iD 0dtw== X-Gm-Message-State: AOJu0Yz/21nC4kNtcuHkhnsMncP00HAipsOM9+yN5dPUBzxROak+m9KT Mw3SsPoMTvj9mWl96u5FTK8fRezDJNdt5g== X-Google-Smtp-Source: AGHT+IFx4cs/LGcPF2+8WR9/qMwP2ZFppQ/3rUwyT0TckgNaJC/wrxFbf8HK/vf79wWlN9j1cJoxag== X-Received: by 2002:a5d:65cc:0:b0:313:e8bf:a6e with SMTP id e12-20020a5d65cc000000b00313e8bf0a6emr6500008wrw.21.1691412503376; Mon, 07 Aug 2023 05:48:23 -0700 (PDT) Received: from localhost.localdomain ([92.85.190.61]) by smtp.gmail.com with ESMTPSA id k18-20020a5d66d2000000b0031417fd473csm10534017wrw.78.2023.08.07.05.48.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 05:48:22 -0700 (PDT) From: Andrei Coardos To: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: alexandre.belloni@bootlin.com, a.zummo@towertech.it, sebastian.hesselbarth@gmail.com, gregory.clement@bootlin.com, andrew@lunn.ch, alex@shruggie.ro, Andrei Coardos Subject: [PATCH] rtc: armada38x: remove unneeded call to platform_set_drvdata() Date: Mon, 7 Aug 2023 15:48:11 +0300 Message-Id: <20230807124811.16763-1-aboutphysycs@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230807_054825_316174_06734EF9 X-CRM114-Status: GOOD ( 12.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file. Signed-off-by: Andrei Coardos --- drivers/rtc/rtc-armada38x.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/rtc/rtc-armada38x.c b/drivers/rtc/rtc-armada38x.c index b4139c200676..5ed028429565 100644 --- a/drivers/rtc/rtc-armada38x.c +++ b/drivers/rtc/rtc-armada38x.c @@ -527,7 +527,6 @@ static __init int armada38x_rtc_probe(struct platform_device *pdev) dev_warn(&pdev->dev, "Interrupt not available.\n"); rtc->irq = -1; } - platform_set_drvdata(pdev, rtc); if (rtc->irq != -1) device_init_wakeup(&pdev->dev, 1); -- 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel