From: Thomas Devoogdt <thomas@devoogdt.com>
To: buildroot@buildroot.org
Cc: Samuel Martin <s.martin49@gmail.com>,
"Yann E . MORIN" <yann.morin.1998@free.fr>,
Thomas Devoogdt <thomas.devoogdt@barco.com>
Subject: [Buildroot] [PATCH v1, next] pkg-cmake: fix typo for the make backend
Date: Mon, 7 Aug 2023 15:42:19 +0200 [thread overview]
Message-ID: <20230807134219.1598626-1-thomas.devoogdt@barco.com> (raw)
A small typo in commit 4cf79d9b71ff5cf2aede3f21e09ade7c7ac59606
causes the wrong path to be selected.
Cmake breaks on the first compiler check because it isn't
able to call the make program with the -jxx added.
$(firstword $$(MAKE)) --> -DCMAKE_MAKE_PROGRAM="/usr/bin/make -j13"
$(firstword $(MAKE)) --> -DCMAKE_MAKE_PROGRAM="/usr/bin/make"
Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>
---
package/pkg-cmake.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/pkg-cmake.mk b/package/pkg-cmake.mk
index e085fb2b5d..3483b50d46 100644
--- a/package/pkg-cmake.mk
+++ b/package/pkg-cmake.mk
@@ -65,7 +65,7 @@ endif
ifeq ($$($(3)_CMAKE_BACKEND),make)
$(2)_GENERATOR = "Unix Makefiles"
# $$(MAKE) can be 'make -jN', we just want 'make' (possibly with a full path)
-$(2)_GENERATOR_PROGRAM = $(firstword $$(MAKE))
+$(2)_GENERATOR_PROGRAM = $(firstword $(MAKE))
# Generator specific code (make) should be avoided,
# but for now, copy them to the new variables.
$(2)_BUILD_ENV ?= $$($(2)_MAKE_ENV)
--
2.41.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next reply other threads:[~2023-08-07 13:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-07 13:42 Thomas Devoogdt [this message]
2023-08-07 17:37 ` [Buildroot] [PATCH v1, next] pkg-cmake: fix typo for the make backend Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230807134219.1598626-1-thomas.devoogdt@barco.com \
--to=thomas@devoogdt.com \
--cc=buildroot@buildroot.org \
--cc=s.martin49@gmail.com \
--cc=thomas.devoogdt@barco.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.