From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83737C001B0 for ; Mon, 7 Aug 2023 13:02:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233738AbjHGNCM (ORCPT ); Mon, 7 Aug 2023 09:02:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230449AbjHGNCL (ORCPT ); Mon, 7 Aug 2023 09:02:11 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E42F410FD for ; Mon, 7 Aug 2023 06:02:09 -0700 (PDT) Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.200]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4RKGYg3hbGz6HJf4; Mon, 7 Aug 2023 20:57:11 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 7 Aug 2023 14:02:07 +0100 Date: Mon, 7 Aug 2023 14:02:06 +0100 From: Jonathan Cameron To: Jehoon Park CC: , , Alison Schofield , Vishal Verma , "Ira Weiny" , Dan Williams , "Dave Jiang" , Davidlohr Bueso , "Kyungsan Kim" , Junhyeok Im Subject: Re: [ndctl PATCH v2 1/3] libcxl: Update a revision by CXL 3.0 specification Message-ID: <20230807140206.00006232@Huawei.com> In-Reply-To: <20230807063549.5942-2-jehoon.park@samsung.com> References: <20230807063549.5942-1-jehoon.park@samsung.com> <20230807063549.5942-2-jehoon.park@samsung.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml100004.china.huawei.com (7.191.162.219) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-cxl@vger.kernel.org On Mon, 7 Aug 2023 15:35:47 +0900 Jehoon Park wrote: > Update the predefined value for device temperature field when it is not > implemented. (CXL 3.0.8.2.9.8.3.1) > > Signed-off-by: Jehoon Park Hi Jehoon, Key here is not that it was in 3.0, but that it was changed in 2.0 Errata F38 and as such software doesn't need to cope with the old (wrong) value. Good to state that clearly in the patch description. If it had been merely a change for 3.0 there would have needed to be an enable bit to change the default behavior (or something like that). Otherwise LGTM Reviewed-by: Jonathan Cameron > --- > cxl/lib/private.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/cxl/lib/private.h b/cxl/lib/private.h > index a641727..a692fd5 100644 > --- a/cxl/lib/private.h > +++ b/cxl/lib/private.h > @@ -360,7 +360,7 @@ struct cxl_cmd_set_partition { > #define CXL_CMD_HEALTH_INFO_EXT_CORRECTED_PERSISTENT_WARNING (1) > > #define CXL_CMD_HEALTH_INFO_LIFE_USED_NOT_IMPL 0xff > -#define CXL_CMD_HEALTH_INFO_TEMPERATURE_NOT_IMPL 0xffff > +#define CXL_CMD_HEALTH_INFO_TEMPERATURE_NOT_IMPL 0x7fff > > static inline int check_kmod(struct kmod_ctx *kmod_ctx) > {