From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Thomas Devoogdt <thomas@devoogdt.com>
Cc: Jesse Van Gavere <jesseevg@gmail.com>,
Thomas Devoogdt <thomas.devoogdt@barco.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v1 1/3 next] package/qt6/qt6serialport: use the CMAKE_NINJA flag
Date: Mon, 7 Aug 2023 23:31:31 +0200 [thread overview]
Message-ID: <20230807213131.GA421096@scaer> (raw)
In-Reply-To: <20230807145839.2375839-1-thomas.devoogdt@barco.com>
Thomas, All,
Thanks for this series. Thomas P. applied it before I had a chance to
reply, so:
Is there an issue with qt6svg, or did you just miss it?
Regards,
Yann E. MORIN.
On 2023-08-07 16:58 +0200, Thomas Devoogdt spake thusly:
> Use the newly introduce backend option (4cf79d9b71ff5cf2aede3f21e09ade7c7ac59606)
> to specify what cmake backend to use, instead of special-coding it's use.
>
> Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>
> ---
> package/qt6/qt6serialport/qt6serialport.mk | 16 ++--------------
> 1 file changed, 2 insertions(+), 14 deletions(-)
>
> diff --git a/package/qt6/qt6serialport/qt6serialport.mk b/package/qt6/qt6serialport/qt6serialport.mk
> index 497719d4ec..bdb16dd892 100644
> --- a/package/qt6/qt6serialport/qt6serialport.mk
> +++ b/package/qt6/qt6serialport/qt6serialport.mk
> @@ -10,6 +10,8 @@ QT6SERIALPORT_SOURCE = qtserialport-$(QT6_SOURCE_TARBALL_PREFIX)-$(QT6SERIALPORT
> QT6SERIALPORT_INSTALL_STAGING = YES
> QT6SERIALPORT_SUPPORTS_IN_SOURCE_BUILD = NO
>
> +QT6SERIALPORT_CMAKE_BACKEND = ninja
> +
> QT6SERIALPORT_LICENSE = \
> GPL-2.0+ or LGPL-3.0, \
> GPL-3.0 with exception (tools), \
> @@ -25,7 +27,6 @@ QT6SERIALPORT_LICENSE_FILES = \
> LICENSES/Qt-GPL-exception-1.0.txt
>
> QT6SERIALPORT_CONF_OPTS = \
> - -GNinja \
> -DQT_HOST_PATH=$(HOST_DIR) \
> -DBUILD_WITH_PCH=OFF \
> -DQT_BUILD_EXAMPLES=OFF \
> @@ -33,19 +34,6 @@ QT6SERIALPORT_CONF_OPTS = \
>
> QT6SERIALPORT_DEPENDENCIES = \
> host-pkgconf \
> - host-ninja \
> qt6base
>
> -define QT6SERIALPORT_BUILD_CMDS
> - $(TARGET_MAKE_ENV) $(BR2_CMAKE) --build $(QT6SERIALPORT_BUILDDIR)
> -endef
> -
> -define QT6SERIALPORT_INSTALL_STAGING_CMDS
> - $(TARGET_MAKE_ENV) DESTDIR=$(STAGING_DIR) $(BR2_CMAKE) --install $(QT6SERIALPORT_BUILDDIR)
> -endef
> -
> -define QT6SERIALPORT_INSTALL_TARGET_CMDS
> - $(TARGET_MAKE_ENV) DESTDIR=$(TARGET_DIR) $(BR2_CMAKE) --install $(QT6SERIALPORT_BUILDDIR)
> -endef
> -
> $(eval $(cmake-package))
> --
> 2.41.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-08-07 21:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-07 14:58 [Buildroot] [PATCH v1 1/3 next] package/qt6/qt6serialport: use the CMAKE_NINJA flag Thomas Devoogdt
2023-08-07 14:58 ` [Buildroot] [PATCH v1 2/3 next] package/qt6/qt6serialbus: " Thomas Devoogdt
2023-08-07 14:58 ` [Buildroot] [PATCH v1 3/3 next] package/qt6/qt6base: " Thomas Devoogdt
2023-08-07 21:26 ` [Buildroot] [PATCH v1 1/3 next] package/qt6/qt6serialport: " Thomas Petazzoni via buildroot
2023-08-07 21:31 ` Yann E. MORIN [this message]
2023-08-08 5:24 ` Thomas Devoogdt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230807213131.GA421096@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=jesseevg@gmail.com \
--cc=thomas.devoogdt@barco.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=thomas@devoogdt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.