From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4F86C001B0 for ; Mon, 7 Aug 2023 23:14:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230379AbjHGXOC (ORCPT ); Mon, 7 Aug 2023 19:14:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50822 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230505AbjHGXNv (ORCPT ); Mon, 7 Aug 2023 19:13:51 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7186170B; Mon, 7 Aug 2023 16:13:24 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1DA316228D; Mon, 7 Aug 2023 23:13:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2455BC433C7; Mon, 7 Aug 2023 23:13:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691450003; bh=sHveayqydBN1Brz7x3ocQnkmPo6C+nsWsslvZeviEAg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Dw8ZMhze5ZrZj4Y38Di76h0nFqQq9f/KZmJz8ZU6TRJI07ichbVJrR/9BhYKB51Qg gjXSt0lyKeiO6o83RXaT2I0n6tJUpcMz5Xyxg/jEmQlnsxAleX10iRMExcOriD7lq0 KWxatIsERKx0v0E0tNDUFP/OILIFkFNwrJWrXrC8QYg7bLNJwaSso2tsyYG9hLk5y4 FMmUqsBhMdfo0QgcIUGMWroDdy3aXmuhs8fY7yr4uhlI+qE8xSJS5o6a/UEY6UZJEt KtSpARB4M8n7IHv6f6ZOWuBRW+OH23uDa25RiQN/25mrx+tkvKjBKwgAF4cn4jpCjZ bE0yzkNAz4D2Q== Date: Tue, 8 Aug 2023 01:13:20 +0200 From: Andi Shyti To: Krzysztof Kozlowski Cc: Sylwester Nawrocki , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/3] media: exynos4-is: fimc-is: replace duplicate pmu node with phandle Message-ID: <20230807231320.svssge6uymw3jiho@intel.intel> References: <20230807131256.254243-1-krzysztof.kozlowski@linaro.org> <20230807131256.254243-3-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230807131256.254243-3-krzysztof.kozlowski@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org Hi Krzysztof, [...] > +static void __iomem *fimc_is_get_pmu_regs(struct device *dev) > +{ > + struct device_node *node; > + void __iomem *regs; > + > + node = of_parse_phandle(dev->of_node, "samsung,pmu-syscon", 0); > + if (!node) { > + dev_warn(dev, "Finding PMU node via deprecated method, update your DTB\n"); > + node = of_get_child_by_name(dev->of_node, "pmu"); > + if (!node) > + return IOMEM_ERR_PTR(-ENODEV); in my opinion this should be: ... if (!node) return IOMEM_ERR_PTR(-ENODEV); dev_warn(dev, "Finding PMU node via deprecated method, update your DTB\n"); Because if you don't have both "samsung,pmu-syscon and "pmu" then the warning should not be printed and you need to return -ENODEV. ... and... "*please* update your DTB", the user might get upset and out of sheer spite, decides not to do it – just because! :) Andi > + } From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DF5DDC001DF for ; Mon, 7 Aug 2023 23:13:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8s7dXxIUP+HbF34x4kzwrZJ93QB4knBHb4XIr76PwCQ=; b=l20tsWpVvxLsfq aAle5Zh9GKSupDJUmKp6aOQv00mCNdHo1FFEwMimgtPXIA9OseEjcQ7Nfy93EIVyoObqh3tqioYc6 qgxi/weGp3hs9i0K1BnB6UidOGxSyD/7OcTyiHvfucNhJHvaWDfG+0hlwy/AOlLqtfQnd//gYtq5P 0r97VMWD7UI0ENjCgfruqXFK6fZ9XzFHVPWZwmRoKkYBg7wZbbbGMZx7IUDhhXLXqwV46vU0SZ3FS bUONw+7piJbd+Y+JeRyNGGe5HgSibGSeJv9GPtRHGrusY29Zucp9PHASsgBlEP58Ov3t+kh/9qckr Evz0O4hUY6TDrRzlHp9A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qT9Pi-001AXf-1z; Mon, 07 Aug 2023 23:13:26 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qT9Pg-001AWR-2B for linux-arm-kernel@lists.infradead.org; Mon, 07 Aug 2023 23:13:25 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 12A6762129; Mon, 7 Aug 2023 23:13:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2455BC433C7; Mon, 7 Aug 2023 23:13:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691450003; bh=sHveayqydBN1Brz7x3ocQnkmPo6C+nsWsslvZeviEAg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Dw8ZMhze5ZrZj4Y38Di76h0nFqQq9f/KZmJz8ZU6TRJI07ichbVJrR/9BhYKB51Qg gjXSt0lyKeiO6o83RXaT2I0n6tJUpcMz5Xyxg/jEmQlnsxAleX10iRMExcOriD7lq0 KWxatIsERKx0v0E0tNDUFP/OILIFkFNwrJWrXrC8QYg7bLNJwaSso2tsyYG9hLk5y4 FMmUqsBhMdfo0QgcIUGMWroDdy3aXmuhs8fY7yr4uhlI+qE8xSJS5o6a/UEY6UZJEt KtSpARB4M8n7IHv6f6ZOWuBRW+OH23uDa25RiQN/25mrx+tkvKjBKwgAF4cn4jpCjZ bE0yzkNAz4D2Q== Date: Tue, 8 Aug 2023 01:13:20 +0200 From: Andi Shyti To: Krzysztof Kozlowski Cc: Sylwester Nawrocki , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/3] media: exynos4-is: fimc-is: replace duplicate pmu node with phandle Message-ID: <20230807231320.svssge6uymw3jiho@intel.intel> References: <20230807131256.254243-1-krzysztof.kozlowski@linaro.org> <20230807131256.254243-3-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230807131256.254243-3-krzysztof.kozlowski@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230807_161324_782648_4489CE23 X-CRM114-Status: GOOD ( 12.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgS3J6eXN6dG9mLAoKWy4uLl0KCj4gK3N0YXRpYyB2b2lkIF9faW9tZW0gKmZpbWNfaXNfZ2V0 X3BtdV9yZWdzKHN0cnVjdCBkZXZpY2UgKmRldikKPiArewo+ICsJc3RydWN0IGRldmljZV9ub2Rl ICpub2RlOwo+ICsJdm9pZCBfX2lvbWVtICpyZWdzOwo+ICsKPiArCW5vZGUgPSBvZl9wYXJzZV9w aGFuZGxlKGRldi0+b2Zfbm9kZSwgInNhbXN1bmcscG11LXN5c2NvbiIsIDApOwo+ICsJaWYgKCFu b2RlKSB7Cj4gKwkJZGV2X3dhcm4oZGV2LCAiRmluZGluZyBQTVUgbm9kZSB2aWEgZGVwcmVjYXRl ZCBtZXRob2QsIHVwZGF0ZSB5b3VyIERUQlxuIik7Cj4gKwkJbm9kZSA9IG9mX2dldF9jaGlsZF9i eV9uYW1lKGRldi0+b2Zfbm9kZSwgInBtdSIpOwo+ICsJCWlmICghbm9kZSkKPiArCQkJcmV0dXJu IElPTUVNX0VSUl9QVFIoLUVOT0RFVik7CgppbiBteSBvcGluaW9uIHRoaXMgc2hvdWxkIGJlOgoK CQkuLi4KCQlpZiAoIW5vZGUpCgkJCXJldHVybiBJT01FTV9FUlJfUFRSKC1FTk9ERVYpOwoKCQlk ZXZfd2FybihkZXYsICJGaW5kaW5nIFBNVSBub2RlIHZpYSBkZXByZWNhdGVkIG1ldGhvZCwgdXBk YXRlIHlvdXIgRFRCXG4iKTsKCkJlY2F1c2UgaWYgeW91IGRvbid0IGhhdmUgYm90aCAic2Ftc3Vu ZyxwbXUtc3lzY29uIGFuZCAicG11IiB0aGVuCnRoZSB3YXJuaW5nIHNob3VsZCBub3QgYmUgcHJp bnRlZCBhbmQgeW91IG5lZWQgdG8gcmV0dXJuIC1FTk9ERVYuCgouLi4gYW5kLi4uICIqcGxlYXNl KiB1cGRhdGUgeW91ciBEVEIiLCB0aGUgdXNlciBtaWdodCBnZXQgdXBzZXQKYW5kIG91dCBvZiBz aGVlciBzcGl0ZSwgZGVjaWRlcyBub3QgdG8gZG8gaXQg4oCTIGp1c3QgYmVjYXVzZSEgOikKCkFu ZGkKCj4gKwl9CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmlu ZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9s aW51eC1hcm0ta2VybmVsCg==