From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Huang Rui <ray.huang@amd.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Jannik Glueckert <jannik.glueckert@gmail.com>,
Bagas Sanjaya <bagasdotme@gmail.com>,
Linux LLVM Build Support <llvm@lists.linux.dev>,
Nick Desaulniers <ndesaulniers@google.com>,
Nathan Chancellor <nathan@kernel.org>,
stable@vger.kernel.org
Subject: Re: [PATCH] cpufreq: amd-pstate: fix global sysfs attribute type
Date: Mon, 7 Aug 2023 08:47:05 +0200 [thread overview]
Message-ID: <2023080748-apprehend-carnation-e71c@gregkh> (raw)
In-Reply-To: <20230807-amd-pstate-cfi-v1-1-0263daa13bc3@weissschuh.net>
On Mon, Aug 07, 2023 at 08:37:45AM +0200, Thomas Weißschuh wrote:
> In commit 3666062b87ec ("cpufreq: amd-pstate: move to use bus_get_dev_root()")
> the "amd_pstate" attributes where moved from a dedicated kobject to the
> cpu root kobject.
> While the dedicated kobject expects to contain kobj_attributes the root
> kobject needs device_attributes.
>
> As the changed arguments are not used by the callbacks it works most of
> the time.
> However CFI will detect this issue:
>
> [ 4947.849350] CFI failure at dev_attr_show+0x24/0x60 (target: show_status+0x0/0x70; expected type: 0x8651b1de)
> ...
> [ 4947.849409] Call Trace:
> [ 4947.849410] <TASK>
> [ 4947.849411] ? __warn+0xcf/0x1c0
> [ 4947.849414] ? dev_attr_show+0x24/0x60
> [ 4947.849415] ? report_cfi_failure+0x4e/0x60
> [ 4947.849417] ? handle_cfi_failure+0x14c/0x1d0
> [ 4947.849419] ? __cfi_show_status+0x10/0x10
> [ 4947.849420] ? handle_bug+0x4f/0x90
> [ 4947.849421] ? exc_invalid_op+0x1a/0x60
> [ 4947.849422] ? asm_exc_invalid_op+0x1a/0x20
> [ 4947.849424] ? __cfi_show_status+0x10/0x10
> [ 4947.849425] ? dev_attr_show+0x24/0x60
> [ 4947.849426] sysfs_kf_seq_show+0xa6/0x110
> [ 4947.849433] seq_read_iter+0x16c/0x4b0
> [ 4947.849436] vfs_read+0x272/0x2d0
> [ 4947.849438] ksys_read+0x72/0xe0
> [ 4947.849439] do_syscall_64+0x76/0xb0
> [ 4947.849440] ? do_user_addr_fault+0x252/0x650
> [ 4947.849442] ? exc_page_fault+0x7a/0x1b0
> [ 4947.849443] entry_SYSCALL_64_after_hwframe+0x72/0xdc
>
> Reported-by: Jannik Glückert <jannik.glueckert@gmail.com>
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217765
> Link: https://lore.kernel.org/lkml/c7f1bf9b-b183-bf6e-1cbb-d43f72494083@gmail.com/
> Fixes: 3666062b87ec ("cpufreq: amd-pstate: move to use bus_get_dev_root()")
> Cc: stable@vger.kernel.org
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
> Note:
>
> This was not tested with CFI as I don't have the toolchain available.
> Jannik, could you give it a spin?
Ah, that was fast, nice!
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2023-08-07 6:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-07 6:37 [PATCH] cpufreq: amd-pstate: fix global sysfs attribute type Thomas Weißschuh
2023-08-07 6:47 ` Greg Kroah-Hartman [this message]
2023-08-07 16:06 ` Nathan Chancellor
2023-08-07 17:44 ` Rafael J. Wysocki
2023-08-07 17:19 ` Jannik Glückert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023080748-apprehend-carnation-e71c@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=bagasdotme@gmail.com \
--cc=jannik.glueckert@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=rafael@kernel.org \
--cc=ray.huang@amd.com \
--cc=stable@vger.kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.