From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12566C04A94 for ; Tue, 8 Aug 2023 19:08:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234597AbjHHTIq (ORCPT ); Tue, 8 Aug 2023 15:08:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232367AbjHHTIV (ORCPT ); Tue, 8 Aug 2023 15:08:21 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B0A8D4BEB; Tue, 8 Aug 2023 09:30:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6AAF9624E6; Tue, 8 Aug 2023 11:42:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F8AFC433C7; Tue, 8 Aug 2023 11:42:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691494924; bh=7W8arS9xc1VsyrYsfgzjRG4MftCWFePfOyZF4K36c+Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pW9seNGRY4R+UZe/yEDFe+2l2D1h1LIQb9LdZocYP0kb717N0yTUxlV35S6OgUjHp 8SUo26EeRVvTqvoWI2SBfckr2Ri0EcA+xycqL98KEk5aZCvtbFOXfqGxl6jvccniFN 8qrLIix/ofVBDvPuL+f190jlLZUUKOKPxLBUvcILbzx5+Zz3/ExRT8gsdLrhGf4ODQ 6LQF/BA7Re9Q8+v5jY9mpo1TNNaTTFND+P67bfIO4j/glifactZTPFQmNIEOBEBbe4 KfErmMg2IMP7OvtR8dSeL6QmNa5L9bhcn2r+//aC1njNAPMNeb2/8xOpE1+Vqox/En wlPM9oyA/t/eQ== Date: Tue, 8 Aug 2023 13:42:01 +0200 From: Andi Shyti To: Krzysztof Kozlowski Cc: Sylwester Nawrocki , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/3] media: exynos4-is: fimc-is: replace duplicate pmu node with phandle Message-ID: <20230808114201.ztr22migzzyfsfwq@intel.intel> References: <20230807131256.254243-1-krzysztof.kozlowski@linaro.org> <20230807131256.254243-3-krzysztof.kozlowski@linaro.org> <20230807231320.svssge6uymw3jiho@intel.intel> <84fbcc37-d226-b637-caa1-b24ebaf03d58@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <84fbcc37-d226-b637-caa1-b24ebaf03d58@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org > >> +static void __iomem *fimc_is_get_pmu_regs(struct device *dev) > >> +{ > >> + struct device_node *node; > >> + void __iomem *regs; > >> + > >> + node = of_parse_phandle(dev->of_node, "samsung,pmu-syscon", 0); > >> + if (!node) { > >> + dev_warn(dev, "Finding PMU node via deprecated method, update your DTB\n"); > >> + node = of_get_child_by_name(dev->of_node, "pmu"); > >> + if (!node) > >> + return IOMEM_ERR_PTR(-ENODEV); > > > > in my opinion this should be: > > > > ... > > if (!node) > > return IOMEM_ERR_PTR(-ENODEV); > > > > dev_warn(dev, "Finding PMU node via deprecated method, update your DTB\n"); > > > > Because if you don't have both "samsung,pmu-syscon and "pmu" then > > the warning should not be printed and you need to return -ENODEV. > > Why not? Warning is correct - the driver is trying to find, thus > continuous tense "Finding", PMU node via old method. Alright, I'll go along with what you're suggesting, but I have to say, I find it misleading. >From what I understand, you're requesting an update to the dtb because it's using deprecated methods. However, the reality might be that the node is not present in any method at all. Your statement would be accurate if you failed to find the previous method but then did end up finding it. Relying on the present continuous tense for clarity is a bold move, don't you think? :) Andi > > ... and... "*please* update your DTB", the user might get upset > > and out of sheer spite, decides not to do it – just because! :) > > The message is already long enough, why making it longer? Anyone who > ships DTS outside of Linux kernel is doomed anyway... > > Best regards, > Krzysztof > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BDDD6C001B0 for ; Tue, 8 Aug 2023 11:42:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=O5skY/9Y6kcf3AsqFCnb2/ctmDCpYN4HGm5e9gX8Yog=; b=15CIwfLJj7G5OJ wf3Sx0Hmsp3H8rOztvHsYoET6DVk3ftiqJTUM8YXuqejA9QIpv5OeUfwJiAn7juNLrbZ4rpw3uWDi TAhKWofoDD8iVXVrcuY1NZGseb6TZHUeaVoYajKIfLCHriaYGXOlgccydYtRKFZKKhec5EkeTDTrk LHhgTVQdoslXH5sRUhmrFqwGH6I8OyMZgaaP6iIsF7mHAV+r4hIBkbQJA7sR0bkmYXOx+XThyX9CL mX9mQ4xvPQZUr0roMvIitKAPzSv3pHFnd37NYBtv5nAe+MQox5eoMxA3RjFFYEFbG7R/Z6j0HJjbd nUn8kJhh5mnGCEJ4L59g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qTL6J-002TtR-1F; Tue, 08 Aug 2023 11:42:11 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qTL6E-002Tsh-1J for linux-arm-kernel@lists.infradead.org; Tue, 08 Aug 2023 11:42:10 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6AAC3624E5; Tue, 8 Aug 2023 11:42:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F8AFC433C7; Tue, 8 Aug 2023 11:42:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691494924; bh=7W8arS9xc1VsyrYsfgzjRG4MftCWFePfOyZF4K36c+Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pW9seNGRY4R+UZe/yEDFe+2l2D1h1LIQb9LdZocYP0kb717N0yTUxlV35S6OgUjHp 8SUo26EeRVvTqvoWI2SBfckr2Ri0EcA+xycqL98KEk5aZCvtbFOXfqGxl6jvccniFN 8qrLIix/ofVBDvPuL+f190jlLZUUKOKPxLBUvcILbzx5+Zz3/ExRT8gsdLrhGf4ODQ 6LQF/BA7Re9Q8+v5jY9mpo1TNNaTTFND+P67bfIO4j/glifactZTPFQmNIEOBEBbe4 KfErmMg2IMP7OvtR8dSeL6QmNa5L9bhcn2r+//aC1njNAPMNeb2/8xOpE1+Vqox/En wlPM9oyA/t/eQ== Date: Tue, 8 Aug 2023 13:42:01 +0200 From: Andi Shyti To: Krzysztof Kozlowski Cc: Sylwester Nawrocki , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/3] media: exynos4-is: fimc-is: replace duplicate pmu node with phandle Message-ID: <20230808114201.ztr22migzzyfsfwq@intel.intel> References: <20230807131256.254243-1-krzysztof.kozlowski@linaro.org> <20230807131256.254243-3-krzysztof.kozlowski@linaro.org> <20230807231320.svssge6uymw3jiho@intel.intel> <84fbcc37-d226-b637-caa1-b24ebaf03d58@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <84fbcc37-d226-b637-caa1-b24ebaf03d58@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230808_044206_491699_BB830F1A X-CRM114-Status: GOOD ( 23.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org PiA+PiArc3RhdGljIHZvaWQgX19pb21lbSAqZmltY19pc19nZXRfcG11X3JlZ3Moc3RydWN0IGRl dmljZSAqZGV2KQo+ID4+ICt7Cj4gPj4gKwlzdHJ1Y3QgZGV2aWNlX25vZGUgKm5vZGU7Cj4gPj4g Kwl2b2lkIF9faW9tZW0gKnJlZ3M7Cj4gPj4gKwo+ID4+ICsJbm9kZSA9IG9mX3BhcnNlX3BoYW5k bGUoZGV2LT5vZl9ub2RlLCAic2Ftc3VuZyxwbXUtc3lzY29uIiwgMCk7Cj4gPj4gKwlpZiAoIW5v ZGUpIHsKPiA+PiArCQlkZXZfd2FybihkZXYsICJGaW5kaW5nIFBNVSBub2RlIHZpYSBkZXByZWNh dGVkIG1ldGhvZCwgdXBkYXRlIHlvdXIgRFRCXG4iKTsKPiA+PiArCQlub2RlID0gb2ZfZ2V0X2No aWxkX2J5X25hbWUoZGV2LT5vZl9ub2RlLCAicG11Iik7Cj4gPj4gKwkJaWYgKCFub2RlKQo+ID4+ ICsJCQlyZXR1cm4gSU9NRU1fRVJSX1BUUigtRU5PREVWKTsKPiA+IAo+ID4gaW4gbXkgb3Bpbmlv biB0aGlzIHNob3VsZCBiZToKPiA+IAo+ID4gCQkuLi4KPiA+IAkJaWYgKCFub2RlKQo+ID4gCQkJ cmV0dXJuIElPTUVNX0VSUl9QVFIoLUVOT0RFVik7Cj4gPiAKPiA+IAkJZGV2X3dhcm4oZGV2LCAi RmluZGluZyBQTVUgbm9kZSB2aWEgZGVwcmVjYXRlZCBtZXRob2QsIHVwZGF0ZSB5b3VyIERUQlxu Iik7Cj4gPiAKPiA+IEJlY2F1c2UgaWYgeW91IGRvbid0IGhhdmUgYm90aCAic2Ftc3VuZyxwbXUt c3lzY29uIGFuZCAicG11IiB0aGVuCj4gPiB0aGUgd2FybmluZyBzaG91bGQgbm90IGJlIHByaW50 ZWQgYW5kIHlvdSBuZWVkIHRvIHJldHVybiAtRU5PREVWLgo+IAo+IFdoeSBub3Q/IFdhcm5pbmcg aXMgY29ycmVjdCAtIHRoZSBkcml2ZXIgaXMgdHJ5aW5nIHRvIGZpbmQsIHRodXMKPiBjb250aW51 b3VzIHRlbnNlICJGaW5kaW5nIiwgUE1VIG5vZGUgdmlhIG9sZCBtZXRob2QuCgpBbHJpZ2h0LCBJ J2xsIGdvIGFsb25nIHdpdGggd2hhdCB5b3UncmUgc3VnZ2VzdGluZywgYnV0IEkgaGF2ZSB0bwpz YXksIEkgZmluZCBpdCBtaXNsZWFkaW5nLgoKRnJvbSB3aGF0IEkgdW5kZXJzdGFuZCwgeW91J3Jl IHJlcXVlc3RpbmcgYW4gdXBkYXRlIHRvIHRoZSBkdGIKYmVjYXVzZSBpdCdzIHVzaW5nIGRlcHJl Y2F0ZWQgbWV0aG9kcy4gSG93ZXZlciwgdGhlIHJlYWxpdHkgbWlnaHQgCmJlIHRoYXQgdGhlIG5v ZGUgaXMgbm90IHByZXNlbnQgaW4gYW55IG1ldGhvZCBhdCBhbGwuCgpZb3VyIHN0YXRlbWVudCB3 b3VsZCBiZSBhY2N1cmF0ZSBpZiB5b3UgZmFpbGVkIHRvIGZpbmQgdGhlCnByZXZpb3VzIG1ldGhv ZCBidXQgdGhlbiBkaWQgZW5kIHVwIGZpbmRpbmcgaXQuCgpSZWx5aW5nIG9uIHRoZSBwcmVzZW50 IGNvbnRpbnVvdXMgdGVuc2UgZm9yIGNsYXJpdHkgaXMgYSBib2xkCm1vdmUsIGRvbid0IHlvdSB0 aGluaz8gOikKCkFuZGkKCj4gPiAuLi4gYW5kLi4uICIqcGxlYXNlKiB1cGRhdGUgeW91ciBEVEIi LCB0aGUgdXNlciBtaWdodCBnZXQgdXBzZXQKPiA+IGFuZCBvdXQgb2Ygc2hlZXIgc3BpdGUsIGRl Y2lkZXMgbm90IHRvIGRvIGl0IOKAkyBqdXN0IGJlY2F1c2UhIDopCj4gCj4gVGhlIG1lc3NhZ2Ug aXMgYWxyZWFkeSBsb25nIGVub3VnaCwgd2h5IG1ha2luZyBpdCBsb25nZXI/IEFueW9uZSB3aG8K PiBzaGlwcyBEVFMgb3V0c2lkZSBvZiBMaW51eCBrZXJuZWwgaXMgZG9vbWVkIGFueXdheS4uLgo+ IAo+IEJlc3QgcmVnYXJkcywKPiBLcnp5c3p0b2YKPiAKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0Cmxp bnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFk Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK