From: Jakub Kicinski <kuba@kernel.org>
To: Shay Drory <shayd@nvidia.com>
Cc: <netdev@vger.kernel.org>, <pabeni@redhat.com>,
<davem@davemloft.net>, <edumazet@google.com>,
Jiri Pirko <jiri@nvidia.com>
Subject: Re: [PATCH net] devlink: Delay health recover notification until devlink registered
Date: Tue, 8 Aug 2023 16:18:34 -0700 [thread overview]
Message-ID: <20230808161834.71d5391d@kernel.org> (raw)
In-Reply-To: <20230808133720.1402826-1-shayd@nvidia.com>
On Tue, 8 Aug 2023 16:37:20 +0300 Shay Drory wrote:
> Currently, invoking health recover before devlink_register() triggers
> a WARN_ON. However, it is possible for a device to have health errors
> during its probing flow, before the device driver will call to
> devlink_register(). e.g.: it is valid to invoke health recover before
> devlink_register().
>
> Hence, apply delay notification mechanism to health reporters.
devlink_register() is dead, long live devl_register().
At the very least the commit message should enlighten us as to why
the devlink instance can't be registered first, before the health
reporter.
prev parent reply other threads:[~2023-08-08 23:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 13:37 [PATCH net] devlink: Delay health recover notification until devlink registered Shay Drory
2023-08-08 23:18 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230808161834.71d5391d@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiri@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shayd@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.