All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux@treblig.org, davem@davemloft.net, benh@kernel.crashing.org,
	akpm@linux-foundation.org, sparclinux@vger.kernel.org,
	linux-kernel@vger.kernel.org, mpe@ellerman.id.au,
	glaubitz@physik.fu-berlin.de
Subject: Re: [PATCH v3] sparc: Use shared font data
Date: Tue, 8 Aug 2023 18:36:08 +0200	[thread overview]
Message-ID: <20230808163608.GA358064@ravnborg.org> (raw)
In-Reply-To: <90be12db-6aa5-cb8d-df98-fca3c994e4e8@infradead.org>

On Tue, Aug 08, 2023 at 08:51:16AM -0700, Randy Dunlap wrote:
> 
> 
> On 8/6/23 18:09, linux@treblig.org wrote:
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > 
> > sparc has a 'btext' font used for the console which is almost identical
> > to the shared font_sun8x16, so use it rather than duplicating the data.
> > 
> > They were actually identical until about a decade ago when
> >    commit bcfbeecea11c ("drivers: console: font_: Change a glyph from
> >                         "broken bar" to "vertical line"")
> > 
> > which changed the | in the shared font to be a solid
> > bar rather than a broken bar.  That's the only difference.
> > 
> > This was originally spotted by PMD which noticed that PPC does
> > the same thing with the same data, and they also share a bunch
> > of functions to manipulate the data.
> > 
> > Tested very lightly with a boot without FS in qemu.
> > 
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> 
> This survives lots of build testing with no problems, so
> 
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
In that case:
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>

  reply	other threads:[~2023-08-08 19:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-07  1:09 [PATCH v3] sparc: Use shared font data linux
2023-08-07 17:12 ` Sam Ravnborg
2023-08-08 15:51 ` Randy Dunlap
2023-08-08 16:36   ` Sam Ravnborg [this message]
     [not found] ` <8c0ea24d-9993-492c-a7bd-fbdac7800479@web.de>
2023-08-12  1:06   ` Dr. David Alan Gilbert
2023-11-04  1:21 ` Dr. David Alan Gilbert
2023-11-04  8:53   ` John Paul Adrian Glaubitz
2023-11-04 16:16     ` Randy Dunlap
2024-02-16 16:16 ` Andreas Larsson
2024-02-17 15:43   ` Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230808163608.GA358064@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=akpm@linux-foundation.org \
    --cc=benh@kernel.crashing.org \
    --cc=davem@davemloft.net \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@treblig.org \
    --cc=mpe@ellerman.id.au \
    --cc=rdunlap@infradead.org \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.