From: Leon Romanovsky <leon@kernel.org>
To: Jijie Shao <shaojijie@huawei.com>
Cc: yisen.zhuang@huawei.com, salil.mehta@huawei.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, shenjian15@huawei.com, wangjie125@huawei.com,
liuyonglong@huawei.com, wangpeiyang1@huawei.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 net 3/4] net: hns3: add wait until mac link down
Date: Tue, 8 Aug 2023 21:41:05 +0300 [thread overview]
Message-ID: <20230808184105.GE94631@unreal> (raw)
In-Reply-To: <20230807113452.474224-4-shaojijie@huawei.com>
On Mon, Aug 07, 2023 at 07:34:51PM +0800, Jijie Shao wrote:
> From: Jie Wang <wangjie125@huawei.com>
>
> In some configure flow of hns3 driver, for example, change mtu, it will
> disable MAC through firmware before configuration. But firmware disables
> MAC asynchronously. The rx traffic may be not stopped in this case.
>
> So fixes it by waiting until mac link is down.
>
> Fixes: a9775bb64aa7 ("net: hns3: fix set and get link ksettings issue")
> Signed-off-by: Jie Wang <wangjie125@huawei.com>
> Signed-off-by: Jijie Shao <shaojijie@huawei.com>
> ---
> .../net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
next prev parent reply other threads:[~2023-08-08 20:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-07 11:34 [PATCH V2 net 0/4] There are some bugfix for the HNS3 ethernet driver Jijie Shao
2023-08-07 11:34 ` [PATCH V2 net 1/4] net: hns3: restore user pause configure when disable autoneg Jijie Shao
2023-08-08 18:40 ` Leon Romanovsky
2023-08-07 11:34 ` [PATCH V2 net 2/4] net: hns3: refactor hclge_mac_link_status_wait for interface reuse Jijie Shao
2023-08-08 18:40 ` Leon Romanovsky
2023-08-07 11:34 ` [PATCH V2 net 3/4] net: hns3: add wait until mac link down Jijie Shao
2023-08-08 18:41 ` Leon Romanovsky [this message]
2023-08-07 11:34 ` [PATCH V2 net 4/4] net: hns3: fix deadlock issue when externel_lb and reset are executed together Jijie Shao
2023-08-08 18:41 ` Leon Romanovsky
2023-08-08 23:40 ` [PATCH V2 net 0/4] There are some bugfix for the HNS3 ethernet driver patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230808184105.GE94631@unreal \
--to=leon@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyonglong@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=salil.mehta@huawei.com \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
--cc=wangjie125@huawei.com \
--cc=wangpeiyang1@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.