From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 000FEC04A6A for ; Tue, 8 Aug 2023 19:24:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234360AbjHHTY0 (ORCPT ); Tue, 8 Aug 2023 15:24:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236241AbjHHTYK (ORCPT ); Tue, 8 Aug 2023 15:24:10 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A46AD92C1 for ; Tue, 8 Aug 2023 12:20:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 689BE62B1C for ; Tue, 8 Aug 2023 19:20:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A1392C433C7; Tue, 8 Aug 2023 19:20:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691522429; bh=6e39yrlLiKSrgUoZ2M444RyiaqrYu/3GKu7yzntRXUI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=knblRZFv4xYk3/h5YWLYc8x4JJSh6TrKafTMWGlNegq8YrscP7JgxPAYaCweHUb9c up+IHej4UtJ0ugwfumzqV117J24Uv/9gCDAPUCDrpd6oBmAsnUZD4Mdj5OWrO31trC WlGHJzzMgIex59by5WFzDreSe5PNILNBk5Bgl3D4H3nqTAeqRc2Pddcoewn2NRlx8G OJLhVrLU3pr/3MsTR05y0I6ou0LnaizgEFDgsNKbeT2FwMiac4YPOuuNi8qP4OrIHo uLBn6p2MJ3KDdeSV6NOb4YsWsqiiVyw6nBN7EDT+wQcZrTMnBKcLU2jozjd5vLL1uO SVNH6il+YDgXw== Received: by pali.im (Postfix) id DC11A687; Tue, 8 Aug 2023 21:20:26 +0200 (CEST) Date: Tue, 8 Aug 2023 21:20:26 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Bjorn Helgaas Cc: "Russell King (Oracle)" , Lorenzo Pieralisi , Bjorn Helgaas , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kwilczynski@kernel.org Subject: Re: [PATCH] PCI: mvebu: Mark driver as BROKEN Message-ID: <20230808192026.t65ebdii5bv2xx5b@pali> References: <20230808072605.n3rjfsxuogza7qth@pali> <20230808162627.GA314706@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230808162627.GA314706@bhelgaas> User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Tuesday 08 August 2023 11:26:27 Bjorn Helgaas wrote: > [+cc linux-arm-kernel, beginning of thread: > https://lore.kernel.org/r/20230114164125.1298-1-pali@kernel.org] > > On Tue, Aug 08, 2023 at 09:26:05AM +0200, Pali Rohár wrote: > > On Friday 04 August 2023 12:35:13 Russell King (Oracle) wrote: > > ... > > > > For example, I have an Atheros PCIe WiFi card in an Armada 388 Clearfog > > > platform, and this works fine. > > > > > > Uwe has a SATA controller for a bunch of disks in an Armada 370 based > > > NAS platform that is connected to PCIe, and removing PCIe support > > > effectively makes his platform utterly useless. > > > > > > Please revert this patch. > > > > Please do not revert it, instead start fixing problems. > > We know that like all the other drivers, the mvebu driver isn't > perfect. But I don't think effectively removing the driver completely > helps anybody. If people try to use it and notice problems, we have a > chance to try to fix them. I do not want to remove it. I was trying to find somebody who can start caring about issues. In last year I was resending patches, some smaller which could improve situation, but most of them were ignored or rejected. So I'm here and waiting for alternatives, and I'm prepared to review changes and patches for mvebu, which can improve driver support. But I do not see anything. The only one who wrote something useful was Uwe as he wanted to do some git bisect (which normally indicates issues or also fixup/patch). Also some times ago Greg wrote something like that (mainline) kernel is place for unsupported and broken drivers. But mvebu is going in this direction. How can I otherwise point out to start doing something in this area? Or are you unhappy with the fact that there is at least somebody (me) who is willing to do patch review for this marvell stuff? You should have said it to me earlier. But as I'm reading now, that I should go away, maybe you should have to find also new reviewer for driver. Good luck here as there was nobody who even wanted to do anything in this area. > Or maybe I'm missing your point. I think you're suggesting that we > keep pci-mvebu in the tree but unselectable because it depends on > CONFIG_BROKEN. What would be the advantage of doing that? > > Bjorn Well, all knows here that driver is in bad state. In past there were regressions and no accepted fixes for it. (At that time I prepared fix, but you did not like it and nobody else comes with other alternative patch). There area other options which can be done now, if there are only people like Russel who are complaining but refusing to do absolutely nothing. For example mark driver as experimental (there is some Kconfig symbol for it). Or add a new menuconfig selectable symbol which appropriately warn all distributions about problems and would be dependency for mvebu. (if you do not like broken symbol). From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6DAE9C04A94 for ; Tue, 8 Aug 2023 19:20:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hR4oUnPx63k9qJbe9HFYLtQibv7nvg2Bsz6S14K21Ow=; b=K4TbO5MDx3jSb9 NTKWlngYcDbdJcg2EubqGM0bN/i13OcqzG9s9uNMnpYMklHQLBFoh2Ws0EMPZjAqFvYIXvaiSMaF3 0Ek5VK0ZRbel+EmXE9meZ4ioyMqFpc4VxmMlgJiNmdMGjpLZSpBNCxAySBZvMVD4r7QpUp1Afgtfp c860nfa0GvIM4bgn9sVfwPC0zXg2PeAe4+YjeLoQLrLhGKruvMvPshZhh0ZObp+AE9XMFkhpw7OnG caDaeDUOEpCR2/gJiPBkvp1RPQ0IAWFkJPqWaKZ07On1FL7+G+DFoUxqvjk5RHyobkHuFjK/QvtoI aNpCaLuN4WKVpdB2Hwkw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qTSFt-003JSP-2m; Tue, 08 Aug 2023 19:20:33 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qTSFq-003JRf-2x for linux-arm-kernel@lists.infradead.org; Tue, 08 Aug 2023 19:20:32 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5E85A6214F; Tue, 8 Aug 2023 19:20:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A1392C433C7; Tue, 8 Aug 2023 19:20:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691522429; bh=6e39yrlLiKSrgUoZ2M444RyiaqrYu/3GKu7yzntRXUI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=knblRZFv4xYk3/h5YWLYc8x4JJSh6TrKafTMWGlNegq8YrscP7JgxPAYaCweHUb9c up+IHej4UtJ0ugwfumzqV117J24Uv/9gCDAPUCDrpd6oBmAsnUZD4Mdj5OWrO31trC WlGHJzzMgIex59by5WFzDreSe5PNILNBk5Bgl3D4H3nqTAeqRc2Pddcoewn2NRlx8G OJLhVrLU3pr/3MsTR05y0I6ou0LnaizgEFDgsNKbeT2FwMiac4YPOuuNi8qP4OrIHo uLBn6p2MJ3KDdeSV6NOb4YsWsqiiVyw6nBN7EDT+wQcZrTMnBKcLU2jozjd5vLL1uO SVNH6il+YDgXw== Received: by pali.im (Postfix) id DC11A687; Tue, 8 Aug 2023 21:20:26 +0200 (CEST) Date: Tue, 8 Aug 2023 21:20:26 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Bjorn Helgaas Cc: "Russell King (Oracle)" , Lorenzo Pieralisi , Bjorn Helgaas , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kwilczynski@kernel.org Subject: Re: [PATCH] PCI: mvebu: Mark driver as BROKEN Message-ID: <20230808192026.t65ebdii5bv2xx5b@pali> References: <20230808072605.n3rjfsxuogza7qth@pali> <20230808162627.GA314706@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230808162627.GA314706@bhelgaas> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230808_122031_040108_508B9EB2 X-CRM114-Status: GOOD ( 29.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlc2RheSAwOCBBdWd1c3QgMjAyMyAxMToyNjoyNyBCam9ybiBIZWxnYWFzIHdyb3RlOgo+ IFsrY2MgbGludXgtYXJtLWtlcm5lbCwgYmVnaW5uaW5nIG9mIHRocmVhZDoKPiBodHRwczovL2xv cmUua2VybmVsLm9yZy9yLzIwMjMwMTE0MTY0MTI1LjEyOTgtMS1wYWxpQGtlcm5lbC5vcmddCj4g Cj4gT24gVHVlLCBBdWcgMDgsIDIwMjMgYXQgMDk6MjY6MDVBTSArMDIwMCwgUGFsaSBSb2jDoXIg d3JvdGU6Cj4gPiBPbiBGcmlkYXkgMDQgQXVndXN0IDIwMjMgMTI6MzU6MTMgUnVzc2VsbCBLaW5n IChPcmFjbGUpIHdyb3RlOgo+ID4gLi4uCj4gCj4gPiA+IEZvciBleGFtcGxlLCBJIGhhdmUgYW4g QXRoZXJvcyBQQ0llIFdpRmkgY2FyZCBpbiBhbiBBcm1hZGEgMzg4IENsZWFyZm9nCj4gPiA+IHBs YXRmb3JtLCBhbmQgdGhpcyB3b3JrcyBmaW5lLgo+ID4gPiAKPiA+ID4gVXdlIGhhcyBhIFNBVEEg Y29udHJvbGxlciBmb3IgYSBidW5jaCBvZiBkaXNrcyBpbiBhbiBBcm1hZGEgMzcwIGJhc2VkCj4g PiA+IE5BUyBwbGF0Zm9ybSB0aGF0IGlzIGNvbm5lY3RlZCB0byBQQ0llLCBhbmQgcmVtb3Zpbmcg UENJZSBzdXBwb3J0Cj4gPiA+IGVmZmVjdGl2ZWx5IG1ha2VzIGhpcyBwbGF0Zm9ybSB1dHRlcmx5 IHVzZWxlc3MuCj4gPiA+IAo+ID4gPiBQbGVhc2UgcmV2ZXJ0IHRoaXMgcGF0Y2guCj4gPiAKPiA+ IFBsZWFzZSBkbyBub3QgcmV2ZXJ0IGl0LCBpbnN0ZWFkIHN0YXJ0IGZpeGluZyBwcm9ibGVtcy4K PiAKPiBXZSBrbm93IHRoYXQgbGlrZSBhbGwgdGhlIG90aGVyIGRyaXZlcnMsIHRoZSBtdmVidSBk cml2ZXIgaXNuJ3QKPiBwZXJmZWN0LiAgQnV0IEkgZG9uJ3QgdGhpbmsgZWZmZWN0aXZlbHkgcmVt b3ZpbmcgdGhlIGRyaXZlciBjb21wbGV0ZWx5Cj4gaGVscHMgYW55Ym9keS4gIElmIHBlb3BsZSB0 cnkgdG8gdXNlIGl0IGFuZCBub3RpY2UgcHJvYmxlbXMsIHdlIGhhdmUgYQo+IGNoYW5jZSB0byB0 cnkgdG8gZml4IHRoZW0uCgpJIGRvIG5vdCB3YW50IHRvIHJlbW92ZSBpdC4gSSB3YXMgdHJ5aW5n IHRvIGZpbmQgc29tZWJvZHkgd2hvIGNhbiBzdGFydApjYXJpbmcgYWJvdXQgaXNzdWVzLiBJbiBs YXN0IHllYXIgSSB3YXMgcmVzZW5kaW5nIHBhdGNoZXMsIHNvbWUgc21hbGxlcgp3aGljaCBjb3Vs ZCBpbXByb3ZlIHNpdHVhdGlvbiwgYnV0IG1vc3Qgb2YgdGhlbSB3ZXJlIGlnbm9yZWQgb3IgcmVq ZWN0ZWQuCgpTbyBJJ20gaGVyZSBhbmQgd2FpdGluZyBmb3IgYWx0ZXJuYXRpdmVzLCBhbmQgSSdt IHByZXBhcmVkIHRvIHJldmlldwpjaGFuZ2VzIGFuZCBwYXRjaGVzIGZvciBtdmVidSwgd2hpY2gg Y2FuIGltcHJvdmUgZHJpdmVyIHN1cHBvcnQuCgpCdXQgSSBkbyBub3Qgc2VlIGFueXRoaW5nLiBU aGUgb25seSBvbmUgd2hvIHdyb3RlIHNvbWV0aGluZyB1c2VmdWwgd2FzClV3ZSBhcyBoZSB3YW50 ZWQgdG8gZG8gc29tZSBnaXQgYmlzZWN0ICh3aGljaCBub3JtYWxseSBpbmRpY2F0ZXMgaXNzdWVz Cm9yIGFsc28gZml4dXAvcGF0Y2gpLgoKQWxzbyBzb21lIHRpbWVzIGFnbyBHcmVnIHdyb3RlIHNv bWV0aGluZyBsaWtlIHRoYXQgKG1haW5saW5lKSBrZXJuZWwgaXMKcGxhY2UgZm9yIHVuc3VwcG9y dGVkIGFuZCBicm9rZW4gZHJpdmVycy4gQnV0IG12ZWJ1IGlzIGdvaW5nIGluIHRoaXMKZGlyZWN0 aW9uLgoKSG93IGNhbiBJIG90aGVyd2lzZSBwb2ludCBvdXQgdG8gc3RhcnQgZG9pbmcgc29tZXRo aW5nIGluIHRoaXMgYXJlYT8KCk9yIGFyZSB5b3UgdW5oYXBweSB3aXRoIHRoZSBmYWN0IHRoYXQg dGhlcmUgaXMgYXQgbGVhc3Qgc29tZWJvZHkgKG1lKQp3aG8gaXMgd2lsbGluZyB0byBkbyBwYXRj aCByZXZpZXcgZm9yIHRoaXMgbWFydmVsbCBzdHVmZj8gWW91IHNob3VsZApoYXZlIHNhaWQgaXQg dG8gbWUgZWFybGllci4KCkJ1dCBhcyBJJ20gcmVhZGluZyBub3csIHRoYXQgSSBzaG91bGQgZ28g YXdheSwgbWF5YmUgeW91IHNob3VsZCBoYXZlIHRvCmZpbmQgYWxzbyBuZXcgcmV2aWV3ZXIgZm9y IGRyaXZlci4gR29vZCBsdWNrIGhlcmUgYXMgdGhlcmUgd2FzIG5vYm9keQp3aG8gZXZlbiB3YW50 ZWQgdG8gZG8gYW55dGhpbmcgaW4gdGhpcyBhcmVhLgoKPiBPciBtYXliZSBJJ20gbWlzc2luZyB5 b3VyIHBvaW50LiAgSSB0aGluayB5b3UncmUgc3VnZ2VzdGluZyB0aGF0IHdlCj4ga2VlcCBwY2kt bXZlYnUgaW4gdGhlIHRyZWUgYnV0IHVuc2VsZWN0YWJsZSBiZWNhdXNlIGl0IGRlcGVuZHMgb24K PiBDT05GSUdfQlJPS0VOLiAgV2hhdCB3b3VsZCBiZSB0aGUgYWR2YW50YWdlIG9mIGRvaW5nIHRo YXQ/Cj4gCj4gQmpvcm4KCldlbGwsIGFsbCBrbm93cyBoZXJlIHRoYXQgZHJpdmVyIGlzIGluIGJh ZCBzdGF0ZS4gSW4gcGFzdCB0aGVyZSB3ZXJlCnJlZ3Jlc3Npb25zIGFuZCBubyBhY2NlcHRlZCBm aXhlcyBmb3IgaXQuIChBdCB0aGF0IHRpbWUgSSBwcmVwYXJlZCBmaXgsCmJ1dCB5b3UgZGlkIG5v dCBsaWtlIGl0IGFuZCBub2JvZHkgZWxzZSBjb21lcyB3aXRoIG90aGVyIGFsdGVybmF0aXZlCnBh dGNoKS4KClRoZXJlIGFyZWEgb3RoZXIgb3B0aW9ucyB3aGljaCBjYW4gYmUgZG9uZSBub3csIGlm IHRoZXJlIGFyZSBvbmx5IHBlb3BsZQpsaWtlIFJ1c3NlbCB3aG8gYXJlIGNvbXBsYWluaW5nIGJ1 dCByZWZ1c2luZyB0byBkbyBhYnNvbHV0ZWx5IG5vdGhpbmcuCkZvciBleGFtcGxlIG1hcmsgZHJp dmVyIGFzIGV4cGVyaW1lbnRhbCAodGhlcmUgaXMgc29tZSBLY29uZmlnIHN5bWJvbApmb3IgaXQp LiBPciBhZGQgYSBuZXcgbWVudWNvbmZpZyBzZWxlY3RhYmxlIHN5bWJvbCB3aGljaCBhcHByb3By aWF0ZWx5Cndhcm4gYWxsIGRpc3RyaWJ1dGlvbnMgYWJvdXQgcHJvYmxlbXMgYW5kIHdvdWxkIGJl IGRlcGVuZGVuY3kgZm9yIG12ZWJ1LgooaWYgeW91IGRvIG5vdCBsaWtlIGJyb2tlbiBzeW1ib2wp LgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgt YXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQu b3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJt LWtlcm5lbAo=